From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02358C433DF for ; Thu, 13 Aug 2020 05:31:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BC39720771 for ; Thu, 13 Aug 2020 05:31:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC39720771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2FC896B000C; Thu, 13 Aug 2020 01:31:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AEF66B000D; Thu, 13 Aug 2020 01:31:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C1B46B000E; Thu, 13 Aug 2020 01:31:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 05FFD6B000C for ; Thu, 13 Aug 2020 01:31:31 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B8C54181AEF1E for ; Thu, 13 Aug 2020 05:31:30 +0000 (UTC) X-FDA: 77144422740.17.trade92_4a026c126ff1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 8520C180D0185 for ; Thu, 13 Aug 2020 05:31:30 +0000 (UTC) X-HE-Tag: trade92_4a026c126ff1 X-Filterd-Recvd-Size: 3115 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Aug 2020 05:31:30 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4D06DD6E; Wed, 12 Aug 2020 22:31:29 -0700 (PDT) Received: from [192.168.0.129] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5D84A3F6CF; Wed, 12 Aug 2020 22:31:27 -0700 (PDT) From: Anshuman Khandual Subject: Re: [PATCH 16/16] debug_vm_pgtable/ppc64: Add a variant of pfn_pte/pmd To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org References: <20200812063358.369514-1-aneesh.kumar@linux.ibm.com> <20200812063358.369514-16-aneesh.kumar@linux.ibm.com> Message-ID: Date: Thu, 13 Aug 2020 11:00:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200812063358.369514-16-aneesh.kumar@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8520C180D0185 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/12/2020 12:03 PM, Aneesh Kumar K.V wrote: > The tests do expect _PAGE_PTE bit set by different page table accessors. > This is not true for the kernel. Within the kernel, _PAGE_PTE bits are > usually set by set_pte_at(). To make the below tests work correctly add test > specific pfn_pte/pmd helpers that set _PAGE_PTE bit. > > pte_t pte = pfn_pte(pfn, prot); > WARN_ON(!pte_devmap(pte_mkdevmap(pte))); > WARN_ON(!pte_savedwrite(pte_mk_savedwrite(pte_clear_savedwrite(pte)))); > > Signed-off-by: Aneesh Kumar K.V > --- > mm/debug_vm_pgtable.c | 65 +++++++++++++++++++++++++++---------------- > 1 file changed, 41 insertions(+), 24 deletions(-) > > diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c > index eea62d5e503b..153c925b5273 100644 > --- a/mm/debug_vm_pgtable.c > +++ b/mm/debug_vm_pgtable.c > @@ -31,6 +31,23 @@ > #include > #include > > +#ifdef CONFIG_PPC_BOOK3S_64 > +static inline pte_t debug_vm_pfn_pte(unsigned long pfn, pgprot_t pgprot) > +{ > + pte_t pte = pfn_pte(pfn, pgprot); > + return __pte(pte_val(pte) | _PAGE_PTE); > + > +} > +static inline pmd_t debug_vm_pfn_pmd(unsigned long pfn, pgprot_t pgprot) > +{ > + pmd_t pmd = pfn_pmd(pfn, pgprot); > + return __pmd(pmd_val(pmd) | _PAGE_PTE); > +} > +#else > +#define debug_vm_pfn_pte(pfn, pgprot) pfn_pte(pfn, pgprot) > +#define debug_vm_pfn_pmd(pfn, pgprot) pfn_pmd(pfn, pgprot) > +#endif Again, no platform specific constructs please. This defeats the whole purpose of this test. If __PAGE_PTE is required for the helpers, then pfn_pmd/pte() could be modified to accommodate that. We dont see similar issues on other platforms, hence could you please explain why ppc64 is different here.