Re: [PATCH 04 of 16] serialize oom killer

Peter Zijlstra
2007-06-09T06:43:47Z

On Fri, 2007-06-08 at 22:03 +0200, Andrea Arcangeli wrote:
> # HG changeset patch
> # User Andrea Arcangeli <andrea@suse.de>
> # Date 1181332960 -7200
> # Node ID baa866fedc79cb333b90004da2730715c145f1d5
> # Parent 532a5f712848ee75d827bfe233b9364a709e1fc1
> serialize oom killer
>
> It's risky and useless to run two oom killers in parallel, let serialize it to
> reduce the probability of spurious oom-killage.
>
> Signed-off-by: Andrea Arcangeli <andrea@suse.de>
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -400,12 +400,15 @@ void out_of_memory(struct zonelist *zone
> unsigned long points = 0;
> unsigned long freed = 0;
> int constraint;
> + static DECLARE_MUTEX(OOM_lock);

I thought we depricated that construct in favour of DEFINE_MUTEX. Also,
putting it in a function like so is a little icky IMHO.