From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_RED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FF0BC4338F for ; Tue, 3 Aug 2021 05:41:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 08BE560EFF for ; Tue, 3 Aug 2021 05:41:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 08BE560EFF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 998FD6B0033; Tue, 3 Aug 2021 01:41:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 949266B0036; Tue, 3 Aug 2021 01:41:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8385C8D0001; Tue, 3 Aug 2021 01:41:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 678436B0033 for ; Tue, 3 Aug 2021 01:41:32 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0491720420 for ; Tue, 3 Aug 2021 05:41:32 +0000 (UTC) X-FDA: 78432672024.27.8E7A3A5 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf30.hostedemail.com (Postfix) with ESMTP id 4BDC1E0085DE for ; Tue, 3 Aug 2021 05:41:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=uwAkekVM3YUihzDR1kquqE04ZiF9bUkpWcr7bm0ku1c=; b=an7jhKrep5fjlnXrbAgvOtNqTo Pa+gpw2pMXTpDnI1mi1Poh3vO3mzOdDihRcH7SrRaMppCQs8ZH/ZbXob2LrWKpL3x1NGVFYsLvFc8 WOmWfig5EdLAX0zloaTkZvDaIJhpjyCRII7VNSEWCHjUcn7wIrKS1dHNpf09SThogXYsJwpvfzjKN clvgA4cGLF3xdrA8rlWOjBHPopUjlBpzY3VFy71mP9vuFna+Dj8Z8cGpflgOwdw1xMa75Fn8kBnYd BilXhRw3bgMlQ+4Ia6TNxj2UFsPhySoUcIVCgtF015bi5ajJM/SveTU8GhMX2TYTskyoHafjqW1wY Etbawong==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAnB1-005Kyq-Ew; Tue, 03 Aug 2021 05:41:20 +0000 Subject: Re: mmotm 2021-08-02-18-51 uploaded (struct user_struct when CONFIG_EPOLL is not set) To: akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, Nicholas Piggin References: <20210803015202.vA3c5O7uP%akpm@linux-foundation.org> From: Randy Dunlap Message-ID: Date: Mon, 2 Aug 2021 22:41:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210803015202.vA3c5O7uP%akpm@linux-foundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4BDC1E0085DE Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=an7jhKre; dmarc=none; spf=none (imf30.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=rdunlap@infradead.org X-Stat-Signature: up138e6chbs93ijytnehrpbq1hc8tzya X-HE-Tag: 1627969291-414863 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/2/21 6:52 PM, akpm@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2021-08-02-18-51 has been uploaded to >=20 > https://www.ozlabs.org/~akpm/mmotm/ >=20 > mmotm-readme.txt says >=20 > README for mm-of-the-moment: >=20 > https://www.ozlabs.org/~akpm/mmotm/ >=20 > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > more than once a week. >=20 > You will need quilt to apply these patches to the latest Linus release = (5.x > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated= in > https://ozlabs.org/~akpm/mmotm/series >=20 > The file broken-out.tar.gz contains two datestamp files: .DATE and > .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-ss= , > followed by the base kernel version against which this patch series is = to > be applied. >=20 I am seeing build errors on i386 or x86_64 when CONFIG_EPOLL is not set: ../kernel/user.c: In function =E2=80=98free_user=E2=80=99: ../kernel/user.c:141:30: error: =E2=80=98struct user_struct=E2=80=99 has = no member named=20 =E2=80=98epoll_watches=E2=80=99; did you mean =E2=80=98nr_watches=E2=80=99= ? percpu_counter_destroy(&up->epoll_watches); ^~~~~~~~~~~~~ nr_watches In file included from ../include/linux/sched/user.h:7:0, from ../kernel/user.c:17: ../kernel/user.c: In function =E2=80=98alloc_uid=E2=80=99: ../kernel/user.c:189:33: error: =E2=80=98struct user_struct=E2=80=99 has = no member named=20 =E2=80=98epoll_watches=E2=80=99; did you mean =E2=80=98nr_watches=E2=80=99= ? if (percpu_counter_init(&new->epoll_watches, 0, GFP_KERNEL)) { ^ ../include/linux/percpu_counter.h:38:25: note: in definition of macro=20 =E2=80=98percpu_counter_init=E2=80=99 __percpu_counter_init(fbc, value, gfp, &__key); \ ^~~ ../kernel/user.c:203:33: error: =E2=80=98struct user_struct=E2=80=99 has = no member named=20 =E2=80=98epoll_watches=E2=80=99; did you mean =E2=80=98nr_watches=E2=80=99= ? percpu_counter_destroy(&new->epoll_watches); ^~~~~~~~~~~~~ nr_watches In file included from ../include/linux/sched/user.h:7:0, from ../kernel/user.c:17: ../kernel/user.c: In function =E2=80=98uid_cache_init=E2=80=99: ../kernel/user.c:225:37: error: =E2=80=98struct user_struct=E2=80=99 has = no member named=20 =E2=80=98epoll_watches=E2=80=99; did you mean =E2=80=98nr_watches=E2=80=99= ? if (percpu_counter_init(&root_user.epoll_watches, 0, GFP_KERNEL)) ^ ../include/linux/percpu_counter.h:38:25: note: in definition of macro=20 =E2=80=98percpu_counter_init=E2=80=99 __percpu_counter_init(fbc, value, gfp, &__key); \ ^~~ --=20 ~Randy