From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 366F1C83F27 for ; Wed, 16 Jul 2025 08:01:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFFA16B0088; Wed, 16 Jul 2025 04:01:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD75A6B0092; Wed, 16 Jul 2025 04:01:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A14626B0095; Wed, 16 Jul 2025 04:01:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 925E06B0088 for ; Wed, 16 Jul 2025 04:01:41 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1C5A5B8075 for ; Wed, 16 Jul 2025 08:01:41 +0000 (UTC) X-FDA: 83669383602.28.B0ABC5C Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf20.hostedemail.com (Postfix) with ESMTP id 100F31C0005 for ; Wed, 16 Jul 2025 08:01:38 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=ljO+xFh6; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf20.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752652899; a=rsa-sha256; cv=none; b=l/Gf2+FFyxGR+/TVuQxhsCveKF2WqBJKAA5y0NLYRTaM9Tby0Ns53zIyHg7cklXg0RLP/d C8+MWCrt8S7mSaBhDPe8L1EW3ZBiORTpn/dPRrgiZEX3c4XD8WCTSL5ULg7HLuwvUMLCFV aJ8nl48Y4FDHTWiHIMEsCZycjYV+fjs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=ljO+xFh6; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf20.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752652899; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x3rasd4RGckjps2nqSbEf6Ca5JxDIgpN3WKYKHYhHA8=; b=3+gMYTJ1GHTwikZwhMS5Uveif6s7PPwZYSR0sO2wJhf3CVeW3ctbk/SQF/QzkYhjtHygsz 9ocMCWIIEKGCSDXdEc3O27dC2tEWY1n3EGZN/O3AHbGQ6MyDfcbStHnbtqlCpvoWH1VQnu VyOdu4TLzQw9q4kTt48LhCeawhUFv+w= Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4bhpRL3bH3z9t13; Wed, 16 Jul 2025 10:01:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1752652894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x3rasd4RGckjps2nqSbEf6Ca5JxDIgpN3WKYKHYhHA8=; b=ljO+xFh6Y1Sje5EQViYAsg+P9EjH3pA2x794jvl2LOaBYpa5FpLuWXqb6yGwU8i8kII6VJ 3Uwwh9BZXTeSxmbw6qvRUllHFvtXV1slM2vXWsXymvRfl1bfB0Dte54ludvDhCTExmlcAr TioWvJNa/8HuqSPiwcw3Rf11XFdcpms1V2BDJQxScDBis+sdgOZ/boFSRyXBXv2YQTpihb N33CmHZMciL5N3CZZWzPAcRl2Fu0Ki5+tVbBfpW/72DHeurb5VJBzIBaYT+e7d/kza/QQY UC5AFH+xhLqSDb1Nlg4rcT76u4MXxhXVYGVMxlSH3zQrV8DIs9ibrwl6nWNpAA== Date: Wed, 16 Jul 2025 10:01:24 +0200 From: "Pankaj Raghav (Samsung)" To: David Hildenbrand Cc: Suren Baghdasaryan , Ryan Roberts , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Vlastimil Babka , Zi Yan , Mike Rapoport , Dave Hansen , Michal Hocko , Lorenzo Stoakes , Andrew Morton , Thomas Gleixner , Nico Pache , Dev Jain , "Liam R . Howlett" , Jens Axboe , linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, x86@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , mcgrof@kernel.org, gost.dev@samsung.com, hch@lst.de, Pankaj Raghav Subject: Re: [PATCH v2 2/5] huge_memory: add huge_zero_page_shrinker_(init|exit) function Message-ID: References: <20250707142319.319642-1-kernel@pankajraghav.com> <20250707142319.319642-3-kernel@pankajraghav.com> <3336b153-7600-4b1a-9acc-0ecde8d32cdc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3336b153-7600-4b1a-9acc-0ecde8d32cdc@redhat.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 100F31C0005 X-Stat-Signature: cicn3uo4shckqshngrkfcp4wpe8cqk7u X-Rspam-User: X-HE-Tag: 1752652898-397761 X-HE-Meta: U2FsdGVkX1/YhdwOOahMPA2iGV9TfDgkmwzu0k18Vo/N+buzem8GzbrS2Nn2LXonT99iu7d/llSoDNb04cUzzHOIV3C1EQ35R7/9s3OVmFL9e22qYGRPxpDbju7Ps5P/s3uulKYAKZVyfoErqHLOyQCEGP/Q6D7fDOgMT1e5YNSR1kQd7haDaZuhpHZgO+CzOQZI7btpyCWmnoYurpxJ/6yaas7431ze3mu5/0iPwu06qMvJp8XxtUIcohFFjAgufO7q2hzS/ZMtZx+9hVGOdk6wuEnO/H4/Y04Ler9/P9AwEv1BRINYoSjcfqYVJelsAhvXWHI4URnNYFoYZ37cXJOBRQWoe2NvGFz1S9guX7kHzevNhTDDefcFMNCfBUkkJgOOj6o0ewHnZkf674aNsmbxQR+nRqdxfhvVs5Vr1t+BoHU/xmZde/TORTw6v6qXoJ/5YM5OYc1lUwbocl9nF1SlQqpnYIVtpDkJO3P9TNr/IgQQ9GjRQl2VRhkpea+YTNRjx3avDI4L9sn8bdbNzj0GEfvUf8GaVsE/hner81V92/F/KS/n2gLSkFOpu1qiYFfL/HDTML43uph+IJH7djYRHD+lWdtq69OhOAyDM/JADg75QhCw9MkgyES9zrh7o+b5M/V5i1iULeiJw9HEWoFwoGyF+BNHSSZ1FSLmD1d2q0ugLhakI4mxsBLaPiP2GF0advwpQ46Mu85Ojkcb+8s4ok4aJvFZUtPKqJyivO0gOrC6F8yi+LDsQl+rQo47ndjYdoI+fAx4NBqgv8juAtWBlByGemkOc05thXVNurO8KAzRjndDpfq+px9xwwaq/UHXu4dpUQmS97hR3NExp7CrRynlrWKM+wo7fvDOJiFuBMqfUUaJJII9qHPPqxRFwKw9Jwqh3t9xZB2eTFw+tFK199qgddh3f4XmH4K5ozar7lVC4Nz5SakdTAkSZiDQ9nLxFWiKGndvNs1EaHz Ltxu7qEN QrDGiNd3WCs9RB5G40HlDbuH679EOPPYB5MamWnjMQarHDvvA02Pt8yb+r13QmTutJAECoR8srqKbCT+pjQpd+zdJdEZ12ZYV+Y7pEk4UAENYjRbqDppY8EuDoPzCnmkJDcrVBMQebguIMwBB5Icf49G3lSp5c3wgUUpTikRRSXOFillUwozwMyTWv7e9yjIYHxh9bv0kOuPVY+yniF+M6g3N7O7NmRVhOBrhiRSEEtY2QsmP99q8shQwx/4RHp6InWbhOdnuw4uVP7lNU6B4E6ThlU5VL/cet8WejNCICMUl0uhPYgdsR8uhXQyrjPcwtjX/bHnisCpD1O10P+9a4vhe0gcW587+RqSN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 15, 2025 at 04:18:26PM +0200, David Hildenbrand wrote: > On 07.07.25 16:23, Pankaj Raghav (Samsung) wrote: > > From: Pankaj Raghav > > > > Add huge_zero_page_shrinker_init() and huge_zero_page_shrinker_exit(). > > As shrinker will not be needed when static PMD zero page is enabled, > > these two functions can be a no-op. > > > > This is a preparation patch for static PMD zero page. No functional > > changes. > > > > Signed-off-by: Pankaj Raghav > > --- > > mm/huge_memory.c | 38 +++++++++++++++++++++++++++----------- > > 1 file changed, 27 insertions(+), 11 deletions(-) > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index d3e66136e41a..101b67ab2eb6 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -289,6 +289,24 @@ static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink, > > } > > static struct shrinker *huge_zero_page_shrinker; > > +static int huge_zero_page_shrinker_init(void) > > +{ > > + huge_zero_page_shrinker = shrinker_alloc(0, "thp-zero"); > > + if (!huge_zero_page_shrinker) > > + return -ENOMEM; > > + > > + huge_zero_page_shrinker->count_objects = shrink_huge_zero_page_count; > > + huge_zero_page_shrinker->scan_objects = shrink_huge_zero_page_scan; > > + shrinker_register(huge_zero_page_shrinker); > > + return 0; > > +} > > + > > +static void huge_zero_page_shrinker_exit(void) > > +{ > > + shrinker_free(huge_zero_page_shrinker); > > + return; > > +} > > While at it, we should rename most of that to "huge_zero_folio" I assume. Sounds good. > > -- > Cheers, > > David / dhildenb >