From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4578C83F1A for ; Mon, 14 Jul 2025 15:18:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3EFF58D000D; Mon, 14 Jul 2025 11:18:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 352548D0001; Mon, 14 Jul 2025 11:18:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 242318D000D; Mon, 14 Jul 2025 11:18:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 123EF8D0001 for ; Mon, 14 Jul 2025 11:18:57 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BC3AA56EF9 for ; Mon, 14 Jul 2025 15:18:56 +0000 (UTC) X-FDA: 83663227872.04.737DEA2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id 7481240002 for ; Mon, 14 Jul 2025 15:18:54 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=E9BtveG+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QMQolox7; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KpbQ25HL; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zJPU3Elo; spf=pass (imf01.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752506334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SH12eXRfFkfNm6HSRFM+mxpcW/B4TZTYFL4rCK3hgXQ=; b=fTu7nnqDiHjGvm+A/wd1+Cj0w51GFANVoOuYwpFFLuXmSLtaeaqNwbym38XewOLaaOOAxf GmtrinC7R6LntcH3OAwi0gdR0m8F6k7QJFAjG7qKRwnHWfmCkK7xKUk679SosMsbFKXapb hLa+SNlir5W8of9WZWOsfAeI5DRSnLQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752506334; a=rsa-sha256; cv=none; b=QccBsFaTHiZjZog77pn5GKa1GZiysJWTvEKK2Ft22vpRVIMkQxneUoMg+UQ748Hsf957r0 eUZxj1bwelu7xAf5j1LmFJdOBvUvtVQE8oZ9l/dILmwSyTSucVxL1CHKaQZx8Jf6fZLxTp SpSK0GZgN+LSZVv2LlbgidOVmFZevcE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=E9BtveG+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QMQolox7; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KpbQ25HL; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zJPU3Elo; spf=pass (imf01.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EE91B2125B; Mon, 14 Jul 2025 15:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752506333; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SH12eXRfFkfNm6HSRFM+mxpcW/B4TZTYFL4rCK3hgXQ=; b=E9BtveG+S/QPZ9wUXe6z7Rg7UWzDBsMvw84LeMAY2i3pRsTXUun81+QVFSstkybrnHnGH8 4rj/77X0ZHIlDejpV3AYTeK6j2CpPXa9Vzc4fOR96R4tA1UfS8eq61y84TI9N8+YCOOoYk +iKEQ0/ve7TfAkYQ7QrJyZZQ7j4VY04= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752506333; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SH12eXRfFkfNm6HSRFM+mxpcW/B4TZTYFL4rCK3hgXQ=; b=QMQolox7gTE7bAg3wqF7FmVJFIOZO6PrdiDgSm++yRKWxxCnPEsP5J1DwyOUKuVk6ykJtA NOUkF2724KuystDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752506332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SH12eXRfFkfNm6HSRFM+mxpcW/B4TZTYFL4rCK3hgXQ=; b=KpbQ25HLi0WkblRNKteDe7N17Vjw1urSrUQjpZbgMcnTxlbeIzSiNGqBs+vOsKYoB5RqcE N9wkIQb3GVVm2ymo/xifXyHJr6C0neXu14lQNgyU+yJwdnIcOI7gtEI9nC9YebnsS2n1r6 HdeFgSClVit9v9vL10peRwLJO4QQ5s8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752506332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SH12eXRfFkfNm6HSRFM+mxpcW/B4TZTYFL4rCK3hgXQ=; b=zJPU3Elo5CMg6ghoSQ2TbVVihuMHrCnftIOZJc5M1QyYJfFNcnuU+pmKS1HulNUOh2o0k9 kvTy6cFQhYGIstDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3EFFB138A1; Mon, 14 Jul 2025 15:18:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id FViPC9wfdWjoMgAAD6G6ig (envelope-from ); Mon, 14 Jul 2025 15:18:52 +0000 Date: Mon, 14 Jul 2025 16:18:50 +0100 From: Pedro Falcato To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , David Hildenbrand , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeff Xu Subject: Re: [PATCH 2/5] mm/mseal: move madvise() logic to mm/madvise.c Message-ID: References: <5d932ec1f9d0ea115aac65067e4cb8241a06e791.1752497324.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d932ec1f9d0ea115aac65067e4cb8241a06e791.1752497324.git.lorenzo.stoakes@oracle.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 7481240002 X-Stat-Signature: rnedakscdjzfkyxnbufhan64yxtaoaw1 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752506334-451942 X-HE-Meta: U2FsdGVkX1+XsVB3Sc586WLMZdtnbNJS9YVtEiN4TFtKnT/qYl8mD4yq37h5RhrdYEQvHRictTvku1Bv0CjV1mL5X1IW55kEpwmrxrFXRP0kyolOoOQ/hWfdrNujiwyi9gAGS6YKNiprIppsopl4xr2nTiRV/bukiChtt8fIyg0I8w7QbJyASlacs1JSCo+vbP0ceyDArq389nz5XMGLcbIFk2erD6BNyIcAgMOzXzDHttEC91WTJf8J17s/VFXqqUbFjVmovXhKHDJijtwMdDScgPsfHXYMN0kevdG+bSb3TAAvVh0AbfQuBAteo6j/ITsXxpwc7XDLpJAtTAdn6RdJ96u4I5V4w8VKVtbRghcw/x4ihesXiHNb/FNqGN7TSBERrDecIqXYYthfvC6N4oTMdDjR2v3zmtJzXl4n18yfHpEUko1/AZpwdUoTv6BoxnmXn2zMvioh2C+CICCNbo5fN6yQBq4k2Q/EXeIejdLzbsxTex6rwB8iMefHt5Di4Xbep7i+7J1NqWXbpWu5uHayCyzobSY9tAjU9WaeLWi0IPxb3bgi52b8O2jOFN7PXNrpzYBAaTvZF6XsJSSDZqlXnvb4RBKxjq3EmmtyE+CBIJktxXtCLRQRO0YMAlVmP9zvGLByRaJyahk9z7HL7lZRudxk1k/NffCi03W6rslqXv2+1/y8RtwiQGtPuWK771MURJily0NPNO4cCbwpjv0h2wjtUB+oOEkkieQbfh8VAcJUEC9EaDzv3zeIeBNBlo9pXR6vlABUZQMVd9qay8yNBGUhf8oiYc9RxV3Gor/Cjw6EkXVGoyPSPa+KpHnLnwKI+hBx7K8nZJxSjszEUtuzrtOep3NUEYCn2oyMqrc2eWECbMu6OelFIMwyrjK7YMTxIEUsnqi2tXGgozDOse+N/H/7jeNOxJzQQSl932xnVxsZavwsVpvXfLgi5AnjMQvD1Z4wYwaiC3Y2gTN rBE2goRR 4whqDcbrNUyGuaLJ+IEFKR3X093kXHX4J93wGRfc+H0sr5Xf+bJwtWwoYPpqa2LjlGok21DHv3sxXcttMP9Cw8SBLzm7VSBO2xdAZSizRUq1CYW4B0Atuj3j6JGnyWapFnd2zcR5x2jKrBgQoq6sbPQYkv74fXoo3xRmrN2kI0iCzfGDMuddILTDInHWfhozdDjtGGunMlrS+qx1pAe5v07tdcS+fpipQ/7ao7I1d2/lLV53AN+qXBTJgEQa/IZor5CtOQudCVH2se4GncrxR6hfO3l1sYkim/l0We1ZwFBS+liHVoFHysUZF990jjbxTSqFk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 14, 2025 at 02:00:37PM +0100, Lorenzo Stoakes wrote: > The madvise() logic is inexplicably performed in mm/mseal.c - this ought to > be located in mm/madvise.c. > > Additionally can_modify_vma_madv() is inconsistently named and, in > combination with is_ro_anon(), is very confusing logic. > > Put a static function in mm/madvise.c instead - can_madvise_modify() - that > spells out exactly what's happening. Also explicitly check for an anon VMA. > > Additionally add commentary to explain what's going on. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Pedro Falcato -- Pedro