From: Minchan Kim <minchan.kim@gmail.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Bob Liu <lliubbo@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
cl@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com,
penberg@cs.helsinki.fi, lethal@linux-sh.org,
a.p.zijlstra@chello.nl, nickpiggin@yahoo.com.au,
dave@linux.vnet.ibm.com, lee.schermerhorn@hp.com,
rientjes@google.com
Subject: Re: [PATCH] code clean rename alloc_pages_exact_node()
Date: Tue, 13 Apr 2010 13:34:52 +0900 [thread overview]
Message-ID: <i2l28c262361004122134of7f96809va209e779ccd44195@mail.gmail.com> (raw)
In-Reply-To: <20100412164335.GQ25756@csn.ul.ie>
On Tue, Apr 13, 2010 at 1:43 AM, Mel Gorman <mel@csn.ul.ie> wrote:
> On Sat, Apr 10, 2010 at 07:49:32PM +0800, Bob Liu wrote:
>> Since alloc_pages_exact_node() is not for allocate page from
>> exact node but just for removing check of node's valid,
>> rename it to alloc_pages_from_valid_node(). Else will make
>> people misunderstanding.
>>
>
> I don't know about this change either but as I introduced the original
> function name, I am biased. My reading of it is - allocate me pages and
> I know exactly which node I need. I see how it it could be read as
> "allocate me pages from exactly this node" but I don't feel the new
> naming is that much clearer either.
Tend to agree.
Then, don't change function name but add some comment?
/*
* allow pages from fallback if page allocator can't find free page in your nid.
* If you want to allocate page from exact node, please use
__GFP_THISNODE flags with
* gfp_mask.
*/
static inline struct page *alloc_pages_exact_node(....
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-13 4:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-10 11:49 [PATCH] code clean rename alloc_pages_exact_node() Bob Liu
2010-04-10 11:49 ` [PATCH] add alloc_pages_exact_node() Bob Liu
2010-04-12 3:38 ` Minchan Kim
2010-04-12 3:43 ` Bob Liu
2010-04-12 16:38 ` Mel Gorman
2010-04-12 3:34 ` [PATCH] code clean rename alloc_pages_exact_node() Minchan Kim
2010-04-12 3:40 ` Bob Liu
2010-04-12 16:43 ` Mel Gorman
2010-04-13 4:34 ` Minchan Kim [this message]
2010-04-13 5:40 ` KAMEZAWA Hiroyuki
2010-04-13 7:09 ` Bob Liu
2010-04-13 7:32 ` KAMEZAWA Hiroyuki
2010-04-13 7:53 ` Minchan Kim
2010-04-13 7:37 ` Minchan Kim
2010-04-13 7:40 ` Minchan Kim
2010-04-13 8:27 ` Mel Gorman
2010-04-16 16:20 ` Christoph Lameter
2010-04-16 16:15 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=i2l28c262361004122134of7f96809va209e779ccd44195@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=lethal@linux-sh.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mel@csn.ul.ie \
--cc=nickpiggin@yahoo.com.au \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).