From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, david@kernel.org
Cc: ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org,
rppt@kernel.org, surenb@google.com, mhocko@suse.com,
baolin.wang@linux.alibaba.com,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, open <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] mm: change to return bool for ptep_test_and_clear_young()
Date: Fri, 20 Mar 2026 11:27:48 +0530 [thread overview]
Message-ID: <ikarxctf.ritesh.list@gmail.com> (raw)
In-Reply-To: <3fa94c3c89fd93fe22c8cb59967f064787d686aa.1773890510.git.baolin.wang@linux.alibaba.com>
Baolin Wang <baolin.wang@linux.alibaba.com> writes:
> Callers use ptep_test_and_clear_young() to clear the young flag and check
> whether it was set. Change the return type to bool to make the intention
> clearer.
>
Right I checked all callers of ptep_test_and_clear_young(). I agree, we
only need bool here.
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> arch/arm64/include/asm/pgtable.h | 8 ++++----
> arch/arm64/mm/contpte.c | 4 ++--
> arch/microblaze/include/asm/pgtable.h | 2 +-
> arch/parisc/include/asm/pgtable.h | 6 +++---
> arch/powerpc/include/asm/book3s/32/pgtable.h | 4 ++--
> arch/powerpc/include/asm/book3s/64/pgtable.h | 6 +++---
> arch/powerpc/include/asm/nohash/pgtable.h | 4 ++--
I looked at it because of powerpc changes, but ended up looking into all
call sites anyways. So overall it LGTM (and I agree that we can remove
the unnecessary externs from function declarations)
With that please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
next prev parent reply other threads:[~2026-03-21 5:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 3:23 [PATCH 0/6] change young flag check functions to return bool Baolin Wang
2026-03-19 3:24 ` [PATCH 1/6] mm: change to return bool for ptep_test_and_clear_young() Baolin Wang
2026-03-19 11:28 ` Lorenzo Stoakes (Oracle)
2026-03-20 2:59 ` Baolin Wang
2026-03-20 5:57 ` Ritesh Harjani [this message]
2026-03-21 5:22 ` Baolin Wang
2026-03-19 3:24 ` [PATCH 2/6] mm: change to return bool for ptep_clear_flush_young()/clear_flush_young_ptes() Baolin Wang
2026-03-19 11:30 ` Lorenzo Stoakes (Oracle)
2026-03-20 3:05 ` Baolin Wang
2026-03-21 5:18 ` Ritesh Harjani
2026-03-19 3:24 ` [PATCH 3/6] mm: change to return bool for pmdp_test_and_clear_young() Baolin Wang
2026-03-19 11:31 ` Lorenzo Stoakes (Oracle)
2026-03-20 3:07 ` Baolin Wang
2026-03-21 5:24 ` Ritesh Harjani
2026-03-19 3:24 ` [PATCH 4/6] mm: change to return bool for pmdp_clear_flush_young() Baolin Wang
2026-03-19 11:33 ` Lorenzo Stoakes (Oracle)
2026-03-20 3:09 ` Baolin Wang
2026-03-19 3:24 ` [PATCH 5/6] mm: change to return bool for pudp_test_and_clear_young() Baolin Wang
2026-03-19 11:34 ` Lorenzo Stoakes (Oracle)
2026-03-21 5:30 ` Ritesh Harjani
2026-03-19 3:24 ` [PATCH 6/6] mm: change to return bool for the MMU notifier's young flag check Baolin Wang
2026-03-19 11:39 ` Lorenzo Stoakes (Oracle)
2026-03-20 3:18 ` Baolin Wang
2026-03-20 3:18 ` [PATCH 0/6] change young flag check functions to return bool Andrew Morton
2026-03-20 3:21 ` Baolin Wang
2026-03-21 5:31 ` Ritesh Harjani
2026-03-21 13:02 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ikarxctf.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox