From: Cong Wang <xiyou.wangcong@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] mm: Warn about costly page allocation
Date: Mon, 9 Jul 2012 12:53:22 +0000 (UTC) [thread overview]
Message-ID: <jtek81$ja5$1@dough.gmane.org> (raw)
In-Reply-To: 20120709084657.GA7915@bbox
On Mon, 09 Jul 2012 at 08:46 GMT, Minchan Kim <minchan@kernel.org> wrote:
>>
>> WARN_ON_ONCE would tell you what is trying to satisfy the allocation.
>
> Do you mean that it would be better to use WARN_ON_ONCE rather than raw printk?
> If so, I would like to insist raw printk because WARN_ON_ONCE could be disabled
> by !CONFIG_BUG.
> If I miss something, could you elaborate it more?
>
Raw printk could be disabled by !CONFIG_PRINTK too, and given that:
config PRINTK
default y
bool "Enable support for printk" if EXPERT
config BUG
bool "BUG() support" if EXPERT
default y
they are both configurable only when ERPERT, so we don't need to
worry much. :)
next prev parent reply other threads:[~2012-07-09 12:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 2:38 [PATCH] mm: Warn about costly page allocation Minchan Kim
2012-07-09 8:22 ` Mel Gorman
2012-07-09 8:46 ` Minchan Kim
2012-07-09 9:12 ` Mel Gorman
2012-07-09 12:50 ` Minchan Kim
2012-07-09 13:05 ` Mel Gorman
2012-07-09 13:19 ` Minchan Kim
2012-07-09 20:53 ` Andrew Morton
2012-07-09 12:53 ` Cong Wang [this message]
2012-07-09 14:12 ` Minchan Kim
2012-07-11 2:45 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jtek81$ja5$1@dough.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).