From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id A86E36B01F5 for ; Tue, 13 Apr 2010 20:02:05 -0400 (EDT) Received: by gwb15 with SMTP id 15so3780786gwb.14 for ; Tue, 13 Apr 2010 17:02:04 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <9918f566ab0259356cded31fd1dd80da6cae0c2b.1271171877.git.minchan.kim@gmail.com> <8b348d9cc1ea4960488b193b7e8378876918c0d4.1271171877.git.minchan.kim@gmail.com> Date: Wed, 14 Apr 2010 09:02:04 +0900 Message-ID: Subject: Re: [PATCH 3/6] change alloc function in alloc_slab_page From: Minchan Kim Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org To: David Rientjes Cc: Andrew Morton , Mel Gorman , KAMEZAWA Hiroyuki , Bob Liu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Lameter , Pekka Enberg List-ID: On Wed, Apr 14, 2010 at 8:55 AM, David Rientjes wrote= : > On Wed, 14 Apr 2010, Minchan Kim wrote: > >> This changlog is bad. >> I will change it with following as when I send v2. >> >> "alloc_slab_page always checks nid =3D=3D -1, so alloc_page_node can't b= e >> called with -1. >> =C2=A0It means node's validity check in alloc_pages_node is unnecessary. >> =C2=A0So we can use alloc_pages_exact_node instead of alloc_pages_node. >> =C2=A0It could avoid comparison and branch as 6484eb3e2a81807722 tried." >> > > Each patch in this series seems to be independent and can be applied > seperately, so it's probably not necessary to make them incremental. Surely. Without considering, I used git-formant-patch -n --thread. I will keep it in mind. Thanks, David. --=20 Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org