From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 0914C6006AB for ; Sun, 2 May 2010 13:40:44 -0400 (EDT) Received: by iwn31 with SMTP id 31so1808573iwn.27 for ; Sun, 02 May 2010 10:40:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20100429162120.GC22108@random.random> References: <1272529930-29505-1-git-send-email-mel@csn.ul.ie> <1272529930-29505-3-git-send-email-mel@csn.ul.ie> <20100429162120.GC22108@random.random> Date: Mon, 3 May 2010 02:40:44 +0900 Message-ID: Subject: Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg_pages() and rmap_walk() during migration by not migrating temporary stacks From: Minchan Kim Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org To: Andrea Arcangeli Cc: Mel Gorman , Andrew Morton , Linux-MM , LKML , KAMEZAWA Hiroyuki , Christoph Lameter , Rik van Riel List-ID: On Fri, Apr 30, 2010 at 1:21 AM, Andrea Arcangeli wrote: > Hi Mel, > > did you see my proposed fix? I'm running with it applied, I'd be > interested if you can test it. Surely it will also work for new > anon-vma code in upstream, because at that point there's just 1 > anon-vma and nothing else attached to the vma. > > http://git.kernel.org/?p=linux/kernel/git/andrea/aa.git;a=commit;h=6efa1dfa5152ef8d7f26beb188d6877525a9dd03 > > I think it's wrong to try to handle the race in rmap walk by making > magic checks on vm_flags VM_GROWSDOWN|GROWSUP and > vma->vm_mm->map_count == 1, when we can fix it fully and simply in > exec.c by indexing two vmas in the same anon-vma with a different > vm_start so the pages will be found at all times by the rmap_walk. > I like this approach than exclude temporal stack while migration. If we look it through viewpoint of performance, Mel and Kame's one look good and simple. But If I look it through viewpoint of correctness, Andrea's one looks good. I mean Mel's approach is that problem is here but let us solve it with there. it makes dependency between here and there. And In future, if temporal stack and rmap code might be problem, we also should solve it in there. :) So I support this one. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org