Re: [PATCH v3 3/3] selftests/nommu: add nommu mmap and mremap behavior tests

[Hajime Tazaki <thehajime@gmail.com>]

On Mon, 28 Sep 2026 21:34:15 +0900,
Mark Brown wrote:

> > +	ksft_print_msg("[RUN] Testing: %s\n", tcase->name);
> 
> > +		if (fd < 0) {
> > +			ksft_test_result_skip("Failed to setup temp node: %s\n",
> > +					      tcase->pathname);
> 
> Your test reports should use a consistant string when reporting the
> result for a given test, that way tooling can tie results together
> between different runs.  Report the diagnostic information with a
> separate print.
> 
> > +	if (result == KSFT_PASS)
> > +		ksft_finished();
> > +
> > +	ksft_exit_fail();
> > +}
> 
> Just unconditionally call ksft_finshed(), it will check the counts of
> reported tests and exit with an appropriate error code - you don't need
> to manually collate the results in your test code.

thanks for the comments, and I understand all of them.   I will revise
those in next spin.

-- Hajime