linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Jimenez <mroberto@cpti.cetuc.puc-rio.br>
To: mroberto@cpti.cetuc.puc-rio.br,
	Andrew Morton <akpm@linux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Christoph Lameter <cl@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] MM: Fix NR_SECTION_ROOTS == 0 when using using sparsemem extreme.
Date: Wed, 5 May 2010 19:19:27 -0300	[thread overview]
Message-ID: <n2pcecb6d8f1005051519ze48b22a0t8548311839f510b0@mail.gmail.com> (raw)
In-Reply-To: <1273093366-3388-1-git-send-email-mroberto@cpti.cetuc.puc-rio.br>

I have done a limited test of the patch, I don't think the actual code
has been reached, any help would be appreciated.

I did a small patch to /proc/meminfo to check that NR_SECTION_ROOTS is
now non-zero:

$ cat /proc/meminfo
NR_SECTION_ROOTS=1
NR_MEM_SECTIONS=32
SECTIONS_PER_ROOT=512
SECTIONS_SHIFT=5
MAX_PHYSMEM_BITS=32
SECTION_SIZE_BITS=27
...

On Wed, May 5, 2010 at 18:02, Marcelo Roberto Jimenez
<mroberto@cpti.cetuc.puc-rio.br> wrote:
> Got this while compiling for ARM/SA1100:
>
> mm/sparse.c: In function '__section_nr':
> mm/sparse.c:135: warning: 'root' is used uninitialized in this function
>
> This patch follows Russell King's suggestion for a new calculation for
> NR_SECTION_ROOTS. Thanks also to Sergei Shtylyov for pointing out the
> existence of the macro DIV_ROUND_UP.
>
> Signed-off-by: Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>

  reply	other threads:[~2010-05-05 22:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05 21:02 [PATCH] MM: Fix NR_SECTION_ROOTS == 0 when using using sparsemem extreme Marcelo Roberto Jimenez
2010-05-05 22:19 ` Marcelo Jimenez [this message]
2010-05-19 16:14   ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=n2pcecb6d8f1005051519ze48b22a0t8548311839f510b0@mail.gmail.com \
    --to=mroberto@cpti.cetuc.puc-rio.br \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).