Re: [PATCH v4 2/2] rust: alloc: move `NumaNode` to the `numa` module

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rust: missing #[inline] on NumaNode::as_raw()
--

commit 642cdfa1b2261df4d8bb7af89b382fd608fe93f2
Author: Andreas Hindborg <a.hindborg@kernel.org>

rust: alloc: move `NumaNode` to the `numa` module

This commit moves the NumaNode type from the alloc module to the numa
module and adds an as_raw() accessor so callers outside the numa module
can obtain the raw node ID.

Link: https://lore.kernel.org/all/aiZvKPFCkqJUsP0a@google.com/

> diff --git a/rust/kernel/numa.rs b/rust/kernel/numa.rs
> index 164e622d325f8..4a3a880308f3d 100644
> --- a/rust/kernel/numa.rs
> +++ b/rust/kernel/numa.rs
[ ... ]
> @@ -27,3 +30,33 @@ pub fn num_online_nodes() -> u32 {
>          bindings::nr_online_nodes
>      }
>  }
> +
> +/// Non Uniform Memory Access (NUMA) node identifier.
> +#[derive(Clone, Copy, PartialEq)]
> +pub struct NumaNode(i32);
> +
> +impl NumaNode {
> +    /// Create a new NUMA node identifier (non-negative integer).
> +    ///
> +    /// Returns [`EINVAL`] if a negative id or an id exceeding [`bindings::MAX_NUMNODES`] is
> +    /// specified.
> +    pub fn new(node: i32) -> Result<Self> {
> +        // MAX_NUMNODES never exceeds 2**10 because NODES_SHIFT is 0..10.
> +        if node < 0 || node >= bindings::MAX_NUMNODES as i32 {
> +            return Err(EINVAL);
> +        }
> +        Ok(Self(node))
> +    }
> +
> +    /// Get the raw representation of this node identifier.
> +    pub(crate) fn as_raw(self) -> i32 {
> +        self.0
> +    }

[Severity: Low]
As reported by Sashiko on v3 [1], this isn't a bug, but should
NumaNode::as_raw() in rust/kernel/numa.rs be marked #[inline] since it is
a small accessor function in the kernel crate called by
ReallocFunc::call() in rust/kernel/alloc/allocator.rs?

[1] https://lore.kernel.org/r/20260929-cpu-helpers-v3-3-e968ce5ee613@kernel.org

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261030-cpu-helpers-v4-0-a8d840d34837@kernel.org?part=2