Re: [PATCH v2] selftests/mm: mlock2-tests: fix fclose(NULL) in is_vmflag_set()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests/mm: missing Fixes trailer for fclose(NULL) fix in
  is_vmflag_set()
--

commit 38a7fefcf9bd0b1ed77197eeaab78f5845d74dfd
Author: Hongfu Li <lihongfu@kylinos.cn>

> selftests/mm: mlock2-tests: fix fclose(NULL) in is_vmflag_set()
>
> is_vmflag_set() jumps to the shared 'out' label when
> seek_to_smaps_entry() fails. smaps is NULL on that path, and the
> code at the 'out' label calls fclose(smaps) unconditionally.
> fclose(NULL) is undefined behaviour, so the test crashes before
> it can report a test result.
>
> Return early on that error path instead, so smaps is always valid
> at the 'out' label.
>
> get_value_for_name() follows the same pattern. Return early on the
> seek_to_smaps_entry() error path there as well, and drop the now
> redundant 'if (smaps)' guard on the fclose().
>
> Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>

[Severity: Low]
Since this fixes the fclose(NULL) crash in is_vmflag_set(), should this
include:

  Fixes: b3b0d09c7a23 ("selftests: vm: add tests for lock on fault")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-for-mlock2-v2-1-f62195fc8394@kylinos.cn?part=1