Re: [PATCH] selftests/mm: allocate nr_pages based on pmd size for uffd pmd_move tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] selftests/mm: build failure from calling removed
  read_pmd_pagesize()
--

commit baaff8c2bca44f86cbdf0bcae24ee9317be43974
Author: John J. Coleman <jocolema@redhat.com>

selftests/mm: allocate nr_pages based on pmd size for uffd pmd_move tests

This commit adds a pre_alloc callback for the move-pmd uffd unit tests to
size nr_pages to twice the PMD page size divided by the base page size.

Link: https://lore.kernel.org/all/20261103202049.499206-1-jocolema@redhat.com

> diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c
> index 9641f4730a355..9668dccc11599 100644
> --- a/tools/testing/selftests/mm/uffd-unit-tests.c
> +++ b/tools/testing/selftests/mm/uffd-unit-tests.c
> @@ -2484,6 +2484,20 @@ static void uffd_mmap_changing_test(uffd_global_test_opts_t *gopts, uffd_test_ar
>  	uffd_test_pass();
>  }
>  
> +static int set_pmd_pagesize_nr_pages(uffd_global_test_opts_t *gopts, const char **errmsg)
> +{
> +	uint64_t pmd_pagesize = read_pmd_pagesize();

[Severity: Medium]
Should this call pmd_psize() instead of read_pmd_pagesize()?  Commit
3fe017016527 ("kselftest: mm: rename read_pmd_pagesize() to pmd_psize()")
renamed this helper, so calling read_pmd_pagesize() breaks the build of
uffd-unit-tests.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113040045.1439391-1-jocolema@redhat.com?part=1