From: sashiko-bot@kernel.org
To: shao.mingyin@zte.com.cn, akpm@linux-foundation.org, david@kernel.org
Cc: linux-mm@kvack.org, virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH] mm/balloon: fix NR_BALLOON_PAGES accounting on migration failure
Date: Sun, 15 Nov 2026 16:47:19 +0000 [thread overview]
Message-ID: <sashiko-outbox-215655@kernel.org> (raw)
In-Reply-To: <20261115004708909xx05JgB9nXnOCG0zL7h_K@zte.com.cn>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mm/balloon: duplicate subject line in commit message body
--
commit d7902e64fbea27d19919ebb1f5426990572ba432
Author: Shao Mingyin <shao.mingyin@zte.com.cn>
> mm/balloon: fix NR_BALLOON_PAGES accounting on migration failure
>
> mm/balloon: fix NR_BALLOON_PAGES accounting on migration failure
>
> A balloon driver's -ENOENT migration result means that the old page was
> deflated but the replacement was not inflated. vmw_balloon returns this
> when its deflate operation succeeds and the subsequent inflate fails.
>
> balloon_page_migrate() accounts the deflation and frees the old page,
> but does not decrement NR_BALLOON_PAGES. Each such failure therefore
> leaves one extra page in the per-node count, which also contributes to
> the Balloon value in /proc/meminfo.
>
> Decrement the counter on the old page's node, matching normal dequeue
> accounting.
>
> Fixes: 4d689474e1b2 ("balloon_compaction: update the NR_BALLOON_PAGES state")
> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
[Severity: Low]
This isn't a bug, but the commit message body repeats the subject line at
the top.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261115004708909xx05JgB9nXnOCG0zL7h_K@zte.com.cn?part=1
prev parent reply other threads:[~2026-11-15 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 16:47 [PATCH] mm/balloon: fix NR_BALLOON_PAGES accounting on migration failure shao.mingyin
2026-11-14 17:31 ` Lorenzo Stoakes (ARM)
2026-11-15 16:47 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215655@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=eperezma@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shao.mingyin@zte.com.cn \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox