Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: shao.mingyin@zte.com.cn, akpm@linux-foundation.org,
	liam@infradead.org, ljs@kernel.org
Cc: linux-mm@kvack.org, vbabka@kernel.org, jannh@google.com,
	pfalcato@suse.de
Subject: Re: [PATCH] mm/vma: restore VMA iterator on full-range merge failure
Date: Sun, 15 Nov 2026 16:47:25 +0000	[thread overview]
Message-ID: <sashiko-outbox-215657@kernel.org> (raw)
In-Reply-To: <20261115004655564ix3vefI54RZ3HhYOmxuKX@zte.com.cn>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mm/vma: duplicated subject line in commit message body
--

commit 53321f02a2e2d093a67d34a87521909e373ff074
Author: Shao Mingyin <shao.mingyin@zte.com.cn>

> mm/vma: restore VMA iterator on full-range merge failure
>
> mm/vma: restore VMA iterator on full-range merge failure
>
> vma_merge_existing_range() moves the iterator to the previous VMA when
> merging to the left. If the range spans the whole middle VMA and a
> vm_ops->close() hook prevents removing it, the function returns without
> restoring the iterator.
>
> An mprotect() walk can then visit the middle VMA again. Restore the
> iterator to the range start, as the abort path already does. Extend the
> existing close-hook merge test to check the iterator after this failure.
> No crash or data corruption has been observed in this case.
>
> Fixes: 01c373e9a5ce2 ("mm: rework vm_ops->close() handling on VMA merge")
> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>

[Severity: Low]
This isn't a bug, but the commit subject line is repeated at the start of
the commit message body.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115004655564ix3vefI54RZ3HhYOmxuKX@zte.com.cn?part=1


      parent reply	other threads:[~2026-11-15 16:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 16:46 [PATCH] mm/vma: restore VMA iterator on full-range merge failure shao.mingyin
2026-11-14 17:14 ` Lorenzo Stoakes (ARM)
2026-11-14 18:58   ` shao.mingyin
2026-11-14 19:47     ` Gregory Price (Meta)
2026-11-14 21:15       ` shao.mingyin
2026-11-15 16:47 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-215657@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=jannh@google.com \
    --cc=liam@infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=pfalcato@suse.de \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shao.mingyin@zte.com.cn \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox