From: sashiko-bot@kernel.org
To: "Randy Dunlap" <rdunlap@infradead.org>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"David Hildenbrand" <david@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jason Gunthorpe" <jgg@nvidia.com>,
"Leon Romanovsky" <leonro@nvidia.com>,
linux-mm@kvack.org, "Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
linux-sound@vger.kernel.org, "Jens Axboe" <axboe@kernel.dk>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
"Jason Wang" <jasowangio@gmail.com>,
"David Heidelberg" <david@ixit.cz>,
"Chas Williams" <3chas3@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, "Helge Deller" <deller@gmx.de>,
dri-devel@lists.freedesktop.org,
MPT-FusionLinux.pdl@broadcom.com,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
linux-scsi@vger.kernel.org,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Zhihao Cheng" <chengzhihao1@huawei.com>,
linux-mtd@lists.infradead.org,
"Neill Kapron" <nkapron@google.com>,
"Andrey Konovalov" <andreyknvl@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, "Juergen Gross" <jgross@suse.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Sean Christopherson" <seanjc@google.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
kvm@vger.kernel.org, virtualization@lists.linux.dev,
"Jan Kara" <jack@suse.cz>, "Theodore Ts'o" <tytso@mit.edu>,
linux-ext4@vger.kernel.org, "Mike Marshall" <hubcap@omnibond.com>,
devel@lists.orangefs.org, "Paulo Alcantara" <pc@manguebit.org>,
"Namjae Jeon" <linkinjeon@kernel.org>,
"Jaegeuk Kim" <jaegeuk@kernel.org>, "Chao Yu" <chao@kernel.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Tzung-Bi Shih" <tzungbi@kernel.org>,
"Benson Leung" <bleung@chromium.org>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
amd-gfx@lists.freedesktop.org,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
intel-gfx@lists.freedesktop.org,
"Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 10/12] docs: ioctl-number: update FS entries
Date: Sun, 15 Nov 2026 20:27:54 +0000 [thread overview]
Message-ID: <sashiko-outbox-215810@kernel.org> (raw)
In-Reply-To: <20261114202653.3113381-11-rdunlap@infradead.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] docs: ioctl-number: ext4 00-2F ioctl range points to
fs/ext4/ext4.h instead of uapi/linux/ext4.h
--
commit 9072a8199d2be085dc5ab2567392180faf810c6d
Author: Randy Dunlap <rdunlap@infradead.org>
docs: ioctl-number: update FS entries
This commit updates the header file paths and sequence number ranges for
filesystem ioctls in Documentation/userspace-api/ioctl/ioctl-number.rst.
> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index 87e547be9e2ac..abc89b6288ba3 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
[ ... ]
> @@ -275,7 +276,7 @@ Code Seq# Include File Comments
> 'f' 00-1F linux/ext2_fs.h conflict!
> 'f' 00-1F linux/ext3_fs.h conflict!
> 'f' 00-0F fs/jfs/jfs_dinode.h conflict!
> -'f' 00-0F fs/ext4/ext4.h conflict!
> +'f' 00-2F fs/ext4/ext4.h conflict!
[Severity: Low]
Should this entry point to uapi/linux/ext4.h (or both headers) instead of
only fs/ext4/ext4.h?
Commit 519fe1bae7e2 ("ext4: Add a uapi header for ext4 userspace APIs")
moved the EXT4_IOC_* definitions spanning 0x03 through 0x2E into
include/uapi/linux/ext4.h, leaving only the compat EXT4_IOC32_* definitions
(0x03 through 0x08) in fs/ext4/ext4.h.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261114202653.3113381-1-rdunlap@infradead.org?part=10
next prev parent reply other threads:[~2026-11-15 20:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 20:26 [PATCH 00/12] docs: ioctl-number: update entries Randy Dunlap
2026-11-14 20:26 ` [PATCH 01/12] docs: ioctl-number: update MM entries Randy Dunlap
2026-11-15 16:58 ` David Hildenbrand (Arm)
2026-11-14 20:26 ` [PATCH 02/12] docs: ioctl-number: update sound entries Randy Dunlap
2026-11-15 1:19 ` Takashi Sakamoto
2026-11-15 20:27 ` sashiko-bot
2026-11-14 20:26 ` [PATCH 03/12] docs: ioctl-number: update block entries Randy Dunlap
2026-11-14 20:26 ` [PATCH 04/12] docs: ioctl-number: update networking entries Randy Dunlap
2026-11-15 20:27 ` sashiko-bot
2026-11-14 20:26 ` [PATCH 05/12] docs: ioctl-number: update video/fbdev entries Randy Dunlap
2026-11-14 20:26 ` [PATCH 06/12] docs: ioctl-number: update SCSI entries Randy Dunlap
2026-11-14 20:26 ` [PATCH 07/12] docs: ioctl-number: update MTD entries Randy Dunlap
2026-11-15 20:27 ` sashiko-bot
2026-11-14 20:26 ` [PATCH 08/12] docs: ioctl-number: update USB entries Randy Dunlap
2026-11-14 20:26 ` [PATCH 09/12] docs: ioctl-number: update virtualization entries Randy Dunlap
2026-11-14 20:26 ` [PATCH 10/12] docs: ioctl-number: update FS entries Randy Dunlap
2026-11-15 20:27 ` sashiko-bot [this message]
2026-11-14 20:26 ` [PATCH 11/12] docs: ioctl-number: update platform entries Randy Dunlap
2026-11-14 20:26 ` [PATCH 12/12] docs: ioctl-number: update DRM entries Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215810@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=3chas3@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andreyknvl@gmail.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bleung@chromium.org \
--cc=chao@kernel.org \
--cc=chengzhihao1@huawei.com \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=david@ixit.cz \
--cc=david@kernel.org \
--cc=deller@gmx.de \
--cc=devel@lists.orangefs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@kernel.org \
--cc=eperezma@redhat.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=hubcap@omnibond.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jani.nikula@linux.intel.com \
--cc=jasowangio@gmail.com \
--cc=jgg@nvidia.com \
--cc=jgross@suse.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=leonro@nvidia.com \
--cc=linkinjeon@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=matthew.brost@intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=mkp@kernel.org \
--cc=mst@redhat.com \
--cc=nkapron@google.com \
--cc=pabeni@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pc@manguebit.org \
--cc=perex@perex.cz \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=rodrigo.vivi@intel.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=seanjc@google.com \
--cc=simona@ffwll.ch \
--cc=skhan@linuxfoundation.org \
--cc=sstabellini@kernel.org \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tursulin@ursulin.net \
--cc=tytso@mit.edu \
--cc=tzungbi@kernel.org \
--cc=vigneshr@ti.com \
--cc=virtualization@lists.linux.dev \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox