Re: [RFC PATCH 01/27] mm/damon/api: introduce struct damon_report

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mm/damon: nonexistent fields in struct damon_report kernel-doc
  comment
--

commit 919e8293a0141a206eb1e31c857deac8b6249a6d
Author: SJ Park <sj@kernel.org>

mm/damon/api: introduce struct damon_report

This commit defines enum damon_report_type and struct damon_report to
represent data attribute reports.

> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index 06bd92981af21..5c32ddebf4625 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
> @@ -751,6 +751,29 @@ struct damon_intervals_goal {
>  	unsigned long max_sample_us;
>  };
>  
> +/**
> + * enum damon_report_type - Type of &struct damon_report.
> + */
> +enum damon_report_type {
> +	NR_DAMON_REPORT_TYPES,
> +};
> +
> +/**
> + * struct damon_report - Data attribute report information.
> + *
> + * @type:	Type of the report.
> + * @addr_range:	The address range of the memory to report for.
> + *
> + * Note that the @start_addr and @end_adr represents an end-open range.
> + */
> +struct damon_report {
> +	enum damon_report_type type;
> +	struct damon_addr_range addr_range;

[Severity: Low]
The kernel-doc comment refers to @start_addr and @end_adr (with a typo in
"end_adr"), but struct damon_report embeds @addr_range (a struct
damon_addr_range with @start and @end fields) rather than defining those
fields directly.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115202849.99134-1-sj@kernel.org?part=1