From: sashiko-bot@kernel.org
To: "Huacai Chen" <chenhuacai@loongson.cn>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Huacai Chen" <chenhuacai@kernel.org>
Cc: linux-mm@kvack.org, "Tiezhu Yang" <yangtiezhu@loongson.cn>
Subject: Re: [PATCH V2] lib/smp_processor_id: Don't warn if there is only one CPU
Date: Mon, 16 Nov 2026 09:55:56 +0000 [thread overview]
Message-ID: <sashiko-outbox-216668@kernel.org> (raw)
In-Reply-To: <20261115095503.2922598-1-chenhuacai@loongson.cn>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] lib/smp_processor_id: check_preemption_disabled() skips
checks on !CONFIG_SMP
- [Low] lib/smp_processor_id: missing Fixes trailer on stable bug-fix
commit
--
commit 62cd1e08e5d017184a1415887d93a1188fd3f001
Author: Huacai Chen <chenhuacai@kernel.org>
> lib/smp_processor_id: Don't warn if there is only one CPU
>
> When CONFIG_DEBUG_PREEMPT is enabled on a Non-SMP (single-core) kernel,
> calls to smp_processor_id() in preemptible contexts trigger some false
> positive "BUG: using smp_processor_id() in preemptible" warnings, which
> are harmless noise because the process always executes on CPU 0 and CPU
> migration is impossible.
>
> Here are some of the trimmed log messages:
>
> Call Trace:
> [<9000000000d33e28>] show_stack+0xf8/0x1c0
> [<9000000000d2fdac>] dump_stack_lvl+0x4c/0x78
> [<9000000002456fc0>] check_preemption_disabled.isra.0+0x100/0x110
> [<9000000002456ff8>] debug_smp_processor_id+0x18/0x40
> [<9000000000d31118>] init_cache_level+0x18/0x90
> [<9000000001adbe2c>] detect_cache_attributes+0x4c/0x640
> [<9000000001adc44c>] cacheinfo_cpu_online+0x1c/0x310
> [<9000000000d5ae04>] cpuhp_issue_call.constprop.0+0x94/0xd0
> [<9000000000d5b278>] __cpuhp_setup_state_cpuslocked+0x208/0x320
> [<9000000000d30148>] do_one_initcall+0x68/0x200
> [<90000000024711b8>] kernel_init_freeable+0x1fc/0x294
> [<900000000245824c>] kernel_init+0x20/0x134
> [<9000000002455b54>] ret_from_kernel_thread+0x24/0x1d0
> [<9000000000d31650>] ret_from_kernel_thread_asm+0xc/0x9c
>
> This warning only exists for the !CONFIG_SMP build. This is because for
> CONFIG_SMP cpuhp_issue_call() invokes callbacks in cpuhp_thread_fun()
> which is a percpu thread, but for !CONFIG_SMP build it invoke callbacks
> in the init process which is not a percpu thread. And there is such a
> skip condition in check_preemption_disabled():
>
> if (is_percpu_thread())
> goto out;
>
> Since there is only one CPU for the !CONFIG_SMP, we can simply skip the
> warning if (!IS_ENABLED(CONFIG_SMP)) in check_preemption_disabled(). The
> effect is partially reverting 570a752b7a9bd03b50 ("lib/smp_processor_id:
> Use is_percpu_thread() instead of nr_cpus_allowed"), because now in the
> UP case nr_cpus_allowed is 1 but PF_NO_SETAFFINITY is unset.
>
> Cc: stable@vger.kernel.org
> Reported-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
[Severity: Low]
Since this commit is tagged for stable and addresses the !CONFIG_SMP
behavior changed when is_percpu_thread() stopped unconditionally returning
true on UP builds, should it include a Fixes: tag such as:
Fixes: cac5cefbade9 ("sched/smp: Make SMP unconditional")
Fixes: 06ddd17521bf ("sched/smp: Always define is_percpu_thread() and scheduler_ipi()")
> diff --git a/lib/smp_processor_id.c b/lib/smp_processor_id.c
> index 94b3f6b195388..be079b9085045 100644
> --- a/lib/smp_processor_id.c
> +++ b/lib/smp_processor_id.c
> @@ -22,6 +22,9 @@ unsigned int check_preemption_disabled(const char *what1, const char *what2)
> if (is_percpu_thread())
> goto out;
>
> + if (!IS_ENABLED(CONFIG_SMP))
> + goto out;
> +
> if (current->migration_disabled)
> goto out;
[Severity: Medium]
As reported by Peter Zijlstra on v1 [1], does returning early on
!IS_ENABLED(CONFIG_SMP) disable all CONFIG_DEBUG_PREEMPT checks in
check_preemption_disabled() on UP builds?
check_preemption_disabled() also backs __this_cpu_preempt_check(), which
guards non-atomic __this_cpu_*() read-modify-write operations that can
still race across same-CPU preemption on a preemptible UP kernel, and
suppresses warnings for smp_processor_id() callers that would be broken on
SMP. Because !IS_ENABLED(CONFIG_SMP) is a compile-time constant, this
also turns the remainder of check_preemption_disabled(), including the
current->migration_disabled check made unconditional of CONFIG_SMP by
2885daf47081 ("lib/smp_processor_id: Make migration check unconditional of
SMP"), into dead code on !CONFIG_SMP.
In the reported trace, init_cache_level(unsigned int cpu) in
arch/loongarch/kernel/cacheinfo.c already receives cpu as an argument but
reads current_cpu_data via smp_processor_id() instead of cpu_data[cpu],
while cpuhp_issue_call() invokes the callback directly in preemptible task
context on !CONFIG_SMP.
[1] https://lore.kernel.org/r/20261111170600.GS1779021@noisy.programming.kicks-ass.net
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261115095503.2922598-1-chenhuacai@loongson.cn?part=1
prev parent reply other threads:[~2026-11-16 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 9:55 [PATCH V2] lib/smp_processor_id: Don't warn if there is only one CPU Huacai Chen
2026-11-16 9:55 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216668@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bsegall@google.com \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vincent.guittot@linaro.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox