Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Max Kellermann" <max.kellermann@ionos.com>,
	akpm@linux-foundation.org, kasong@tencent.com,
	qi.zheng@linux.dev, shakeel.butt@linux.dev, baohua@kernel.org,
	axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com,
	baoquan.he@linux.dev, baolin.wang@linux.alibaba.com,
	david@kernel.org, ljs@kernel.org, liam@infradead.org,
	vbabka@kernel.org, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, hannes@cmpxchg.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 1/5] include/linux/rculist_nulls: add hlist_nulls_add_behind_rcu()
Date: Tue, 17 Nov 2026 08:14:43 +0000	[thread overview]
Message-ID: <sashiko-outbox-218403@kernel.org> (raw)
In-Reply-To: <20261116081403.216452-2-max.kellermann@ionos.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] rculist_nulls: commit message mismatches
  hlist_nulls_add_behind_last_rcu()
--

commit 8be860a8b1d9e4863e4165df073c841c355f9d25
Author: Max Kellermann <max.kellermann@ionos.com>

> include/linux/rculist_nulls: add hlist_nulls_add_behind_rcu()
>
> Move some code from hlist_nulls_add_tail_rcu() to the new function
> hlist_nulls_add_behind_rcu() for callers that already know the last
> node of an `hlist_nulls` list, to allow constant-time appends.
>
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

[Severity: Low]
The commit subject and message refer to hlist_nulls_add_behind_rcu(),
whereas the helper added by the patch is named
hlist_nulls_add_behind_last_rcu().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116081403.216452-1-max.kellermann@ionos.com?part=1


  reply	other threads:[~2026-11-17  8:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  8:13 [PATCH v3 0/5] mm: multi-gen LRU: reduce memcg rotation overhead Max Kellermann
2026-11-16  8:13 ` [PATCH v3 1/5] include/linux/rculist_nulls: add hlist_nulls_add_behind_rcu() Max Kellermann
2026-11-17  8:14   ` sashiko-bot [this message]
2026-11-16  8:14 ` [PATCH v3 2/5] mm/vmscan: move code to lru_gen_{add,del}_memcg() Max Kellermann
2026-11-16  8:14 ` [PATCH v3 3/5] mm/mglru: cache the last memcg node, make tail insertion constant time Max Kellermann
2026-11-16  8:14 ` [PATCH v3 4/5] mm/mglru: avoid redundant rotations of young memcgs Max Kellermann
2026-11-16  8:14 ` [PATCH v3 5/5] mm/mglru: reschedule between memcg reclaim attempts Max Kellermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218403@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=baoquan.he@linux.dev \
    --cc=david@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kasong@tencent.com \
    --cc=liam@infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=max.kellermann@ionos.com \
    --cc=mhocko@suse.com \
    --cc=qi.zheng@linux.dev \
    --cc=rppt@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=weixugc@google.com \
    --cc=yuanchu@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox