Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arnd Bergmann" <arnd@kernel.org>, linux-mm@kvack.org
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Andreas Larsson" <andreas@gaisler.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"David Hildenbrand (Arm)" <david@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Jason Gunthorpe" <jgg@nvidia.com>,
	"Linus Walleij" <linusw@kernel.org>,
	"Lorenzo Stoakes (ARM)" <ljs@kernel.org>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Madhavan Srinivasan" <maddy@linux.ibm.com>,
	"Malin Jonsson" <malin.jonsson@est.tech>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Michal Simek" <monstr@monstr.eu>,
	"Mike Rapoport" <rppt@kernel.org>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Nishanth Menon" <nm@ti.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Russell King" <linux@armlinux.org.uk>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	x86@kernel.org
Subject: Re: [PATCH v3 04/10] powerpc: kvm: allow flexible PAGE_OFFSET
Date: Tue, 17 Nov 2026 12:49:57 +0000	[thread overview]
Message-ID: <sashiko-outbox-218799@kernel.org> (raw)
In-Reply-To: <20261116124832.662455-5-arnd@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] powerpc: kvm: incomplete SR restoration in LOAD_HOST_SEGMENTS
--

commit 32f84cc08116a09feebba0ce8cd2fcce44ce22ae
Author: Arnd Bergmann <arnd@arndb.de>

powerpc: kvm: allow flexible PAGE_OFFSET

This commit replaces hardcoded 0xc0000000 assumptions in PowerPC KVM code
with expressions derived from PAGE_OFFSET.

> diff --git a/arch/powerpc/kvm/book3s_32_sr.S b/arch/powerpc/kvm/book3s_32_sr.S
> index 6cfcd20d46686..f38377c30014f 100644
> --- a/arch/powerpc/kvm/book3s_32_sr.S
> +++ b/arch/powerpc/kvm/book3s_32_sr.S
> @@ -113,8 +113,8 @@
>  
>          li      r0, 4
>          mtctr   r0
> -	LOAD_REG_IMMEDIATE(r3, 0x20000000 | (0x111 * 0xc))
> -        lis     r4, 0xc000
> +	LOAD_REG_IMMEDIATE(r3, 0x20000000 | (0x111 * (PAGE_OFFSET >> 28)))
> +        lis     r4, (PAGE_OFFSET >> 16)
>  3:      mtsrin  r3, r4
>          addi    r3, r3, 0x111     /* increment VSID */
>          addis   r4, r4, 0x1000    /* address of next segment */

[Severity: High]
Does LOAD_HOST_SEGMENTS leave host kernel segment registers holding guest
values on VM exit when PAGE_OFFSET is not 0xc0000000?

LOAD_GUEST_SEGMENTS overwrites all 16 segment registers on guest entry.
On exit, this loop keeps the iteration count in r0 hardcoded to 4, so
when PAGE_OFFSET is below 0xc0000000 it only restores 4 segments starting
at PAGE_OFFSET and leaves the upper kernel segment registers up to SR15
with guest values, causing subsequent host accesses to upper kernel
memory to translate through guest segment registers.

In addition, switch_mmu_context() called after this loop only restores
user segments below ALIGN(TASK_SIZE, SZ_256M) via update_user_segment(),
while Book3S-32 places MODULES_VADDR in the segment below PAGE_OFFSET.
Should this loop start at NUM_USER_SEGMENTS and run for
16 - NUM_USER_SEGMENTS iterations, matching load_segment_registers in
arch/powerpc/kernel/head_book3s_32.S?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116124832.662455-1-arnd@kernel.org?part=4


  parent reply	other threads:[~2026-11-17 12:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 12:48 [PATCH v3 00/10] mm: highmem cleanups Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 01/10] ARM: remove support for highmem on VIVT Arnd Bergmann
2026-11-17 12:49   ` sashiko-bot
2026-11-16 12:48 ` [PATCH v3 02/10] ARM: drop CONFIG_HIGHPTE support Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 03/10] ARM: pxa: support arbitrary PAGE_OFFSET Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 04/10] powerpc: kvm: allow flexible PAGE_OFFSET Arnd Bergmann
2026-11-16 13:38   ` Christophe Leroy (CS GROUP)
2026-11-16 22:54     ` Arnd Bergmann
2026-11-17 12:49   ` sashiko-bot [this message]
2026-11-16 12:48 ` [PATCH v3 05/10] ARM: add CONFIG_VMSPLIT_2G_OPT option Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 06/10] arch/*: increase lowmem size to avoid highmem use Arnd Bergmann
2026-11-17 12:49   ` sashiko-bot
2026-11-16 12:48 ` [PATCH v3 07/10] ARM: defconfig: turn off highmem in favor of CONFIG_VMSPLIT_2G_OPT Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 08/10] mm: remove ARCH_NEEDS_KMAP_HIGH_GET Arnd Bergmann
2026-11-17 10:05   ` David Hildenbrand (Arm)
2026-11-16 12:48 ` [PATCH v3 09/10] mm: drop HIGHPTE support altogether Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 10/10] mm: print pte in __print_bad_page_map_pgtable() Arnd Bergmann
2026-11-16 13:00   ` Mike Rapoport
2026-11-17 12:50   ` sashiko-bot
2026-11-17 10:07 ` [PATCH v3 00/10] mm: highmem cleanups David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218799@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=andreas@gaisler.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=chleroy@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@kernel.org \
    --cc=hpa@zytor.com \
    --cc=jgg@nvidia.com \
    --cc=l.stach@pengutronix.de \
    --cc=linusw@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@armlinux.org.uk \
    --cc=ljs@kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=malin.jonsson@est.tech \
    --cc=mingo@redhat.com \
    --cc=monstr@monstr.eu \
    --cc=mpe@ellerman.id.au \
    --cc=nm@ti.com \
    --cc=npiggin@gmail.com \
    --cc=richard@nod.at \
    --cc=rppt@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tglx@linutronix.de \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox