From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F3C4606A31C for ; Wed, 18 Nov 2026 05:09:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=R/xqUGrj Received: by kanga.kvack.org (Postfix) id 71C036B05B0; Wed, 18 Nov 2026 00:09:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CC7C6B05B2; Wed, 18 Nov 2026 00:09:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E51A6B05B3; Wed, 18 Nov 2026 00:09:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 300C56B05B0 for ; Wed, 18 Nov 2026 00:09:48 -0500 (EST) Received: from smtpin26.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AFA76140605 for ; Wed, 18 Nov 2026 05:09:47 +0000 (UTC) X-FDA: 85447062414.26.B55AA21 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf31.hostedemail.com (Postfix) with ESMTP id EA59020003 for ; Wed, 18 Nov 2026 05:09:45 +0000 (UTC) Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="R/xqUGrj"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf31.hostedemail.com: domain of sashiko-bot@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sashiko-bot@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1794978586; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N8ecUXIE9NFI+o21qW2ZRILVB8vvpu2X3KPk366UveA=; b=oZuMBIObf+dxGnTmK6kWVsbiyAPAeg5UMJoxPiRLsjIbA/JBUnnooQuUs5Fap0Azu6W50Z jKgbtHM8du9PGFb4rSFR8bObv7LcP1jncoxHQcNBhSsrv0zDuqTUSdCgMk1ZYDHT46ZFMS HWgPRmd+7UWipU8ZmwIXdC1I2EPK+kg= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="R/xqUGrj"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf31.hostedemail.com: domain of sashiko-bot@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sashiko-bot@kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1794978586; b=3Mvs3XY+p0l+MyP9CYTh9XVYzzQSbCz0EIm7ZZ1ldMRO9NHqKl1yq0R3RGyRgCDn4ZnsDv VdzwBV+mscETluzU+2pd4GfwTpjORi7icmaQJrfGSB8o6qYtYcCxl70OgoOzhoj5xel7ax ru4wynNk6IE3AEKPze0jDiGCo4qnhYU= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id DEEF943073; Wed, 18 Nov 2026 05:09:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C5701F000C4; Wed, 18 Nov 2026 05:09:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794978584; bh=N8ecUXIE9NFI+o21qW2ZRILVB8vvpu2X3KPk366UveA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=R/xqUGrjkpvyjh9rxGZyESrTZe0TORZlvBjonU+H/UBJFk8D/Zm0EDTrCQdVbSnFF Q43DKXUHgxz4Ta0Z+uPbAkwwdYmqum097ZagvjTjlY7Puxd/giCpIEh0R5sH/CeXgB wgdQtHzHDHVE0mnlV+CQOw2GjD5ZAG/YvN9iAicimqYlQOOnD6CiPzLKT2MYpTuyeq iaR+Mo2y87Fwv2ajL6w1y3ANyDU2FB6fvekv5/y+SOX+oUvYcs93yTc+1jMR4aXPA3 2b8Z4WqbqjQ6h7W2NlUp6F1z9xLRje7q7ElsnCrcA3PS2JJN4r30LUhnwFEpzX4W7Z D5/3T3Z2U8kXg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [RFC PATCH 03/13] rootns: Track init lifecycle via copy_process() and pid_namespace Reply-To: sashiko-reviews@lists.linux.dev To: "Jarkko Sakkinen" Cc: linux-mm@kvack.org, linux-security-module@vger.kernel.org, "Alexander Viro" , "Andrew Morton" , "Ben Segall" , "Christian Brauner" , "David Hildenbrand" , "David Howells" , "Davidlohr Bueso" , "Dietmar Eggemann" , "Ingo Molnar" , "Jan Kara" , "Jonathan Corbet" , "Juri Lelli" , "Kees Cook" , "K Prateek Nayak" , "Liam R. Howlett" , "Lorenzo Stoakes" , "Manfred Spraul" , "Mel Gorman" , "Michal Hocko" , "Mike Rapoport" , "Neal Gompa" , "Paul Moore" , "Pavel Tikhomirov" , "Peter Zijlstra" , "Randy Dunlap" , "Serge Hallyn" , "Shuah Khan" , "Steven Rostedt" , "Suren Baghdasaryan" , "Valentin Schneider" , "Vincent Guittot" , "Vlastimil Babka" In-Reply-To: <20261117050841.3289652-4-jarkko@kernel.org> References: <20261117050841.3289652-1-jarkko@kernel.org> <20261117050841.3289652-4-jarkko@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 18 Nov 2026 05:09:42 +0000 X-Rspamd-Queue-Id: EA59020003 X-Stat-Signature: y3sic1yxxj1fio7zy8xpds7gdf6nuct4 X-Rspamd-Server: rspam01 X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Rspam-User: X-HE-Tag: 1794978585-745972 X-HE-Meta: U2FsdGVkX1+It9Vkj69GdN+W5LrfG/22cJdkYJK1vvx1Z10/W2gAe+7yyOwKpk2JyaiCay0NX/T0dkRQPciFeCDUIsCE2pRAlilweEuYHTedFGweZvsEFSsAnZuwZ85pBWjGnrXmhA1nf0Dnu3g8K40c3nX9a5sUjFuRYRdCi+BUJ4c8OSmhymoAJ9+W7Uz2MtjjxiemrB+1/39yLpfRr3y0XMfRqzNVkZEtrzwtjJcJVBdSKmbOwE0/iqZFycLt/Pmd9HJHX8WxRaIXESGecwex3yrjZqCEydM1aU801zQjNi2IjqhRwxenjkSIOb9s7kyTslU6BIYVf8VFWOJgoL8XvIb7Gu41+NIKyEuHB1XpKAkjkyN75oa1/iH9F0+odiGqcwSk9ga1Mbc+iPCG/jGWikw6MKtO6bZv+L6dZS7CHsvRiRSpg3RjRGa9xIYbEfY14/gz+vYiRP5SrPs6+TBDknOYxXpuLOW9fy9rr8vbsMdyAuRozy3W+XkzrR2SAx1z7JY5wKxrRsjHjcaySahhlNcbI/wM/sfSim6q3OveNTl1ouGC0UOkhG8rUsIN8DKzNltGDH9qwp4r+dCW5OId/A9Md2rQ3myrWWKX/f+OwGkwExLVyl50450xotr/60ny8qSh9sdAYh2Xr49jVCWNvD14mMlJmhZiYbsrwJ3bwKZHzwiEtQE0grMpz6rTYD2z7JejsfUi3Z7AC89g0kow5MgU15SqY81K9IU1yPJ3uV0StdOBP21EN2KaPsoE2e5hPd6xgiO1lJrSYIthOtd55KX6lr9KBJaXdFhz/37hlAntznsrfk22iqhoQAmsWlicDgL9c/ZDnKIPJCOwLlBJT9nV1uSGt73F+hNwXwNTSfRd+DdNnhBHCkDrPvRcAInHUtc5g1d9OmaO3OF/7DIRopVR7tNXFiOMq/r5sFv41rWsLsqFb83oz1DmYg5WxVUEGW/u1/MIZaCEZVy 08Cn1bN5 nw3AG4XF8CtmrWEmFuRgniQtvzrZqYhIjjeAICeGI98A2jgsXHIii81iBPNMgnwn3BhZroKs/tS1hCdHauVVjFJnRzGoFrUVzLHexZ26mcBdYNtJyMs8dBL6ynwsJcAGp4kwB2fJCJk8xp5nr7j9bPiVsYjpNgp8abVm7KNyg/7qP9tY1QakaCtTHLLf/2tcA5gUbIxz2XBXfNTMa5GATyFeNNgMY8arV6gNxWrbZ+0j2Z6VozfzkjXDBW1kRnBgcJP4/95Q/H0O8o7x1fDP1R2Gf0+8eKfjY+NMIshu3KpU8k1B5zfeabuLWY7HS946TBjnQM5Q//XIchqO3kApe4DLSP1mEI7jSzjpBHYcA+91EjBf0TXeeNuJoTSfyS/tsYnYkP1GmcK6x/ua3y/Jxf4ipxiJz3+EGzGpCfAXn3Z8QXvpIiwtiFTVTqyY6av36h3c7sdT/L04Wey5fRSy4T4f/7EcmWewEvO5HzrPQvki8iEy+wcTVE/DAupv9n2nQUDBRrYwJjKoaZIAVhtqaa/YZBqtJ53FbmBDmCvJ/WDZMQvxLeTV+jXBHktlmcECyEDnm40fd7dMFMhxrTuvJHKWcqvdYY/PCINWcllqWBCAZEiX2JS+Xix/c2UPn69HKsdcQLCzksfZOvfs= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: Thank you for your contribution! Sashiko AI review found 4 potential issues to consider: - [High] rootns: UAF and refcount imbalance in exit_rootns() via unreferenced pid_ns->rootns - [High] rootns: unreferenced pid_ns->rootns pointer in exit_rootns() causes UAF - [Medium] rootns: copy_rootns() publishes init_pid before attach_pid(PIDTYPE_PID) - [Medium] rootns: missing is_child_reaper() and locked state checks in copy_rootns() -- commit 257575ec869d3f0e55e6c1a6f99ef3b0751d2a44 Author: Jarkko Sakkinen rootns: Track init lifecycle via copy_process() and pid_namespace This commit adds rootns lifecycle tracking hooks to copy_process(), create_new_namespaces(), and zap_pid_ns_processes() to record the bootstrapped init task's PID and capture its exit status and resource usage when the PID namespace terminates. > diff --git a/kernel/fork.c b/kernel/fork.c > index 5efceb8d58a78..99e22b3cd213e 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c [ ... ] > @@ -2565,6 +2566,7 @@ __latent_entropy struct task_struct *copy_process( > attach_pid(p, PIDTYPE_TGID); > attach_pid(p, PIDTYPE_PGID); > attach_pid(p, PIDTYPE_SID); > + copy_rootns(p, NULL); > __this_cpu_inc(process_counts); > } else { > current->signal->nr_threads++; [Severity: Medium] Does calling copy_rootns() before attach_pid(p, PIDTYPE_PID) publish c->init_pid and ROOTNS_RUNNING before pid->tasks[PIDTYPE_PID] is populated? CPU0 CPU1 copy_process() attach_pid(p, PIDTYPE_TGID) copy_rootns(p, c) spin_lock(&c->lock) c->init_pid =3D get_task_pid(p, ...) c->state =3D ROOTNS_RUNNING spin_unlock(&c->lock) __rootns_kill() spin_lock(&c->lock) pid =3D get_pid(c->init_pid) spin_unlock(&c->lock) kill_pid(pid, sig, priv) ... pid_task(pid, PIDTYPE_PID) --> NULL (-ESRCH) attach_pid(p, PIDTYPE_PID) __rootns_kill() does not take tasklist_lock, so if a signal is sent during this window (for example from rootns_release() when ROOTNS_KILL_ON_CLOSE is set), kill_pid() fails with -ESRCH and drops the signal, leaving the container init process running. > diff --git a/kernel/rootns.c b/kernel/rootns.c > index e75d918b93ec5..e3b203322ae23 100644 > --- a/kernel/rootns.c > +++ b/kernel/rootns.c [ ... ] > @@ -105,3 +106,42 @@ bool is_rootns_file(struct file *file) > { > return file->f_op =3D=3D &rootns_fops; > } > + > +void copy_rootns(struct task_struct *tsk, struct rootns *c) > +{ > + if (likely(!c || READ_ONCE(c->state) !=3D ROOTNS_FORKING)) > + return; > + > + scoped_guard(spinlock, &c->lock) { > + get_rootns(c); > + WRITE_ONCE(c->init_pid, get_task_pid(tsk, PIDTYPE_TGID)); > + WRITE_ONCE(c->state, ROOTNS_RUNNING); > + } > + wake_up_all(&c->waitq); > +} [Severity: Medium] Can copy_rootns() record a non-reaper task as c->init_pid or race with exit_rootns() to overwrite ROOTNS_DEAD back to ROOTNS_RUNNING? In commit "rootns: Add rootns_create() system call", create_rootns() sets ns->pid_ns_for_children->rootns =3D c and marks the PID namespace active in pid_ns_tree before rootns_enter() is called. A host task with CAP_SYS_ADMIN can open that PID namespace via open_by_handle_at(), join it via setns(CLONE_NEWPID), and fork() PID 1 without bootstrapping c. Because copy_process() calls copy_rootns() for any thread_group_leader(p) rather than checking is_child_reaper(pid), a later rootns_enter() spawns PID 2 and commits it as c->init_pid. Furthermore, copy_rootns() checks c->state =3D=3D ROOTNS_FORKING outside c->lock without re-checking under the lock: CPU0 CPU1 copy_rootns(tsk, c) READ_ONCE(c->state) =3D=3D ROOTNS_FORKING zap_pid_ns_processes(pid_ns) exit_rootns(pid_ns, me) spin_lock(&c->lock) c->state =3D ROOTNS_DEAD spin_unlock(&c->lock) put_rootns(c) spin_lock(&c->lock) get_rootns(c) c->init_pid =3D ... c->state =3D ROOTNS_RUNNING <-- overwrites ROOTNS_DEAD spin_unlock(&c->lock) Checking is_child_reaper(pid) and re-checking c->state =3D=3D ROOTNS_FORKING under c->lock would prevent both issues. > + > +void exit_rootns(struct pid_namespace *pid_ns, struct task_struct *tsk) > +{ > + struct rootns *c =3D pid_ns->rootns; > + struct task_struct *leader; > + struct rusage rusage; > + int status; > + > + if (!c) > + return; > + > + leader =3D tsk->group_leader; > + status =3D (tsk->signal->flags & SIGNAL_GROUP_EXIT) ? > + tsk->signal->group_exit_code : leader->exit_code; > + getrusage(leader, RUSAGE_BOTH, &rusage); > + > + scoped_guard(spinlock, &c->lock) { > + c->exit_code =3D status; > + c->rusage =3D rusage; > + WRITE_ONCE(c->state, ROOTNS_DEAD); > + } > + > + pid_ns->rootns =3D NULL; > + wake_up_poll(&c->waitq, EPOLLHUP); > + put_rootns(c); > +} [Severity: High] Can exit_rootns() drop an unheld reference on c when pid_ns was entered without copy_rootns()? In commit "rootns: Add rootns_create() system call", create_rootns() sets ns->pid_ns_for_children->rootns =3D c without taking a reference on c; the matching get_rootns(c) only happens in copy_rootns() when bootstrapping in ROOTNS_FORKING state. If a privileged host process enters pid_ns via open_by_handle_at() and setns(CLONE_NEWPID) and forks a child reaper, copy_rootns() is called with c =3D=3D NULL and never increments c->usage. W= hen that child reaper exits, zap_pid_ns_processes() -> exit_rootns() sees pid_ns->rootns =3D=3D c and calls put_rootns(c), dropping the open rootns f= ile descriptor's own reference and freeing c while the file descriptor is still open. [Severity: High] Can exit_rootns() dereference a dangling pid_ns->rootns pointer after the rootns file descriptor has been closed? Because create_rootns() stores an unreferenced c in pid_ns->rootns and put_rootns() frees c without clearing pid_ns->rootns, any reference that outlives the rootns file descriptor before rootns_enter() runs leaves pid_ns->rootns pointing to freed memory. If a process holds an nsfs file descriptor to pid_ns, closes the rootns file descriptor (freeing c), and then enters pid_ns via setns(CLONE_NEWPID), forks, and exits, zap_pid_ns_processes() -> exit_rootns() dereferences the freed c and double-frees it via put_rootns(c). Assigning pid_ns->rootns =3D get_rootns(= c) in copy_rootns() when the bootstrap init task is attached would avoid storing an unreferenced pointer in create_rootns(). --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261117050841.3289= 652-1-jarkko@kernel.org?part=3D3