Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	tglx@kernel.org, peterz@infradead.org
Cc: mingo@redhat.com, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	vschneid@redhat.com, kprateek.nayak@amd.com, paulmck@kernel.org,
	boqun@kernel.org, shuah@kernel.org, kees@kernel.org,
	viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
	oleg@redhat.com, bestswngs@gmail.com, xmei5@asu.edu,
	xujiakai24@mails.ucas.ac.cn, linux-mm@kvack.org
Subject: Re: [PATCH 02/17] sched/mmcid: Give no concurrency ID to user workers
Date: Wed, 18 Nov 2026 16:17:38 +0000	[thread overview]
Message-ID: <sashiko-outbox-221445@kernel.org> (raw)
In-Reply-To: <11039c504295ef6ee0eef55981993d8f5d1f40ce.1794932121.git.mathieu.desnoyers@efficios.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] sched/mmcid: PF_USER_WORKER affinity updates still widen
  mm_cpus_allowed()
--

commit 2c82f544b589f4baafbe2b43fe16613e89fb4361
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

sched/mmcid: Give no concurrency ID to user workers

This commit skips PF_USER_WORKER tasks in sched_mm_cid_fork() so that
io_uring and vhost worker threads do not consume concurrency IDs or
count toward mm_cid user accounting.

> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index f2a981d418ebe..7e213e88ac286 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -11000,7 +11000,11 @@ static void sched_mm_cid_fork(struct task_struct *t)
>  	struct mm_struct *mm = t->mm;
>  	bool percpu = false, flip = false;
>  
> -	if (!mm)
> +	/*
> +	 * A user worker (io_uring, vhost) never returns to user space and
> +	 * has no rseq area. It needs no CID.
> +	 */
> +	if (!mm || (t->flags & PF_USER_WORKER))
>  		return;
>  
>  	WARN_ON_ONCE(t->mm_cid.cid != MM_CID_UNSET);

[Severity: Medium]
Can affinity updates on a PF_USER_WORKER task still widen
mm_cpus_allowed(p->mm)?

Although sched_mm_cid_fork() leaves t->mm_cid.active unset for user
workers, t->mm remains set and set_cpus_allowed_common() still passes p->mm
to mm_update_cpus_allowed() without checking whether the task is a user
worker:

kernel/sched/core.c:set_cpus_allowed_common() {
	cpumask_copy(&p->cpus_mask, ctx->new_mask);
	p->nr_cpus_allowed = cpumask_weight(ctx->new_mask);
	mm_update_cpus_allowed(p->mm, ctx->new_mask);
}

For example, when a process is restricted by a cpuset (leaving
p->user_cpus_ptr NULL) and creates an io_uring with IORING_SETUP_SQPOLL,
io_sq_thread() calls set_cpus_allowed_ptr(current, cpu_online_mask).
Because current->user_cpus_ptr is NULL, __set_cpus_allowed_ptr() leaves
ctx->new_mask unmasked and mm_update_cpus_allowed() merges cpu_online_mask
into mm_cpus_allowed(p->mm).  That permanently inflates
mm->mm_cid.nr_cpus_allowed, max_cids and pcpu_thrs, which can switch the mm
out of per-CPU mode and hand user threads CIDs larger than the number of
CPUs they can run on.

Should set_cpus_allowed_common() skip mm_update_cpus_allowed() when
p->flags & PF_USER_WORKER (or when !p->mm_cid.active)?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794932121.git.mathieu.desnoyers@efficios.com?part=2


  reply	other threads:[~2026-11-18 16:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 16:17 [PATCH 00/17] sched/mmcid: fixes for execve, mode switches and affinity Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 01/17] sched/mmcid: Give a CID to a task that joins its mm while running Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 02/17] sched/mmcid: Give no concurrency ID to user workers Mathieu Desnoyers
2026-11-18 16:17   ` sashiko-bot [this message]
2026-11-17 16:17 ` [PATCH 03/17] sched/mmcid: Reset stale state when the first user joins an mm Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 04/17] sched/mmcid: Let a running joiner take its CID after the fixups Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 05/17] sched/mmcid: Take the allowed CPUs of the first user when it joins Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 06/17] sched/mmcid: Synchronize MM teardown with affinity updates Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 07/17] selftests/rseq: Test the concurrency ID after a failed execve Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 08/17] selftests/rseq: Test the concurrency ID after the last user fails execve Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 09/17] selftests/rseq: Test the concurrency IDs across ownership mode switches Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 10/17] selftests/rseq: Test the upper bound of the concurrency IDs Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 11/17] selftests/rseq: Test affinity changes made by another process Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 12/17] selftests/rseq: Test an affinity change by another process during execve Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 13/17] selftests/rseq: Test concurrent thread creation and forced migration Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 14/17] selftests/rseq: Test the concurrency IDs after the affinity is widened Mathieu Desnoyers
2026-11-18 16:17   ` sashiko-bot
2026-11-17 16:17 ` [PATCH 15/17] selftests/rseq: Test two race windows of the concurrency ID mode switches Mathieu Desnoyers
2026-11-17 16:17 ` [PATCH 16/17] selftests/rseq: Test affinity changes while a task replaces or drops its mm Mathieu Desnoyers
2026-11-18 16:17   ` sashiko-bot
2026-11-17 16:17 ` [PATCH 17/17] selftests/rseq: Test the last user after an affinity change during execve Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221445@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bestswngs@gmail.com \
    --cc=boqun@kernel.org \
    --cc=brauner@kernel.org \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=jack@suse.cz \
    --cc=juri.lelli@redhat.com \
    --cc=kees@kernel.org \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-mm@kvack.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shuah@kernel.org \
    --cc=tglx@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=vschneid@redhat.com \
    --cc=xmei5@asu.edu \
    --cc=xujiakai24@mails.ucas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox