Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kairui Song" <kasong@tencent.com>, linux-mm@kvack.org
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Muchun Song" <muchun.song@linux.dev>,
	"Qi Zheng" <qi.zheng@linux.dev>,
	"Ying Huang" <ying.huang@linux.alibaba.com>,
	"Chris Li" <chrisl@kernel.org>,
	"Baoquan He" <baoquan.he@linux.dev>,
	"Nico Pache" <nico.pache@linux.dev>,
	"Usama Arif" <usama.arif@linux.dev>,
	"Michal Hocko" <mhocko@kernel.org>,
	"Roman Gushchin" <roman.gushchin@linux.dev>,
	"Shakeel Butt" <shakeel.butt@linux.dev>,
	"David Hildenbrand" <david@kernel.org>,
	"Lorenzo Stoakes" <ljs@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	"Barry Song" <baohua@kernel.org>,
	"Axel Rasmussen" <axelrasmussen@google.com>,
	"Yuanchu Xie" <yuanchu@google.com>, "Wei Xu" <weixugc@google.com>,
	"Vlastimil Babka" <vbabka@kernel.org>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Nhat Pham" <nphamcs@gmail.com>,
	"Youngjun Park" <youngjun.park@lge.com>,
	"Zi Yan" <ziy@nvidia.com>, "Gregory Price" <gourry@gourry.net>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Ryan Roberts" <ryan.roberts@arm.com>,
	"Dev Jain" <dev.jain@arm.com>,
	"Lance Yang" <lance.yang@linux.dev>,
	"Hugh Dickins" <hughd@google.com>, "SJ Park" <sj@kernel.org>,
	"David Rientjes" <rientjes@google.com>,
	"Yu Zhao" <yuzhao@google.com>,
	"Vernon Yang" <vernon2gm@gmail.com>,
	"Zicheng Wang" <wangzicheng@honor.com>,
	"Chen Ridong" <chenridong@xiaomi.com>,
	"Tal Zussman" <tz2294@columbia.edu>,
	"Kairui Song" <ryncsn@gmail.com>,
	"Xiang Liu" <liuxiang.277@bytedance.com>,
	"Ehab Ababneh" <ehab.ababneh@intel.com>,
	"Zhao Zhenzhuo" <zhaozhengzhuo@uniontech.com>,
	"Lian Wang" <lianux.mm@gmail.com>,
	"Joanne Koong" <joannelkoong@gmail.com>,
	"Kunwu Chan" <kunwu.chan@gmail.com>,
	"Hui Zhu" <hui.zhu@linux.dev>,
	damon@lists.linux.dev, tj@kernel.org, mkoutny@suse.com
Subject: Re: [PATCH v5 15/17] mm/mglru: folio LRU refs based active/inactive number accounting
Date: Wed, 18 Nov 2026 21:29:27 +0000	[thread overview]
Message-ID: <sashiko-outbox-221996@kernel.org> (raw)
In-Reply-To: <20261119-mglru-fg-v5-15-9eee2fe97a2d@tencent.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] mm/mglru: raw folio_clear_referenced() in lru_deactivate()
  paths
--

commit b8ed2e873fb1f3b844c7ba1fec4ae00c0c04fb88
Author: Kairui Song <kasong@tencent.com>

mm/mglru: folio LRU refs based active/inactive number accounting

This commit switches MGLRU active/inactive LRU size accounting from
generation-window tracking to per-folio reference count thresholds
(LRU_REFS_ACTIVATED).

> diff --git a/mm/folio.c b/mm/folio.c
> index 06c9cde834f76..3b5ae5b516504 100644
> --- a/mm/folio.c
> +++ b/mm/folio.c

[ ... ]

> @@ -552,10 +523,12 @@ static void lru_lazyfree(struct lruvec *lruvec, struct folio *folio)
>  	    folio_test_swapcache(folio) || folio_test_unevictable(folio))
>  		return;
>  
> -	lru_gen_clear_refs(folio);
>  	lruvec_del_folio(lruvec, folio);
>  	folio_clear_active(folio);
> -	folio_clear_referenced(folio);
> +	if (lru_gen_enabled())
> +		__folio_set_lru_refs(folio, 0);
> +	else
> +		folio_clear_referenced(folio);

[Severity: Medium]
Should lru_deactivate_file() and lru_deactivate() also call
__folio_set_lru_refs(folio, 0) when lru_gen_enabled() is true, like
lru_lazyfree() does here?

Although deactivate_file_folio() and folio_deactivate() call
folio_reset_lru_refs(folio) before queuing the folio into the per-CPU
batch, the folio stays on the LRU list until the batch drains, so
concurrent accesses can increment its refs count in the meantime.  When
the batch drains, lru_deactivate_file() and lru_deactivate() still call
raw folio_clear_referenced(folio):

mm/folio.c:lru_deactivate() {
	...
	lruvec_del_folio(lruvec, folio);
	folio_clear_active(folio);
	folio_clear_referenced(folio);
	lruvec_add_folio(lruvec, folio);
	...
}

Under MGLRU, folio_clear_referenced() clears only bit 0 (PG_referenced) of
the multi-bit refs counter, leaving PG_workingset and LRU_REFS_MASK set.
If the folio was accessed at least twice while queued in the batch,
lruvec_add_folio() sees the surviving upper refs bits and fails to place
the folio in the oldest generation (or re-adds it as active if refs
reached >= 4).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-mglru-fg-v5-0-9eee2fe97a2d@tencent.com?part=15


  reply	other threads:[~2026-11-18 21:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 21:03 [PATCH v5 00/17] mm/mglru: frequency guided promotion (MGLRU-FG) and flag cleanup Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 01/17] mm/mglru: rename the generation offset in lru_gen_folio_seq() Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 02/17] mm/memcontrol: allow update of LRU statistic without holding LRU lock Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 03/17] mm/mglru: make generation page counters atomic Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 04/17] mm/memcg: add folio-based lruvec live helper Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 05/17] mm/mglru: skip the flags cmpxchg when nothing changes Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 06/17] mm/mglru: frequency guided workingset promotion (MGLRU-FG) Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 07/17] mm/mglru: make folio lru referenced times count a generic API Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 08/17] mm/mglru: move add/del LRU size accounting out of lru_gen_update_size() Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 09/17] mm/mglru, gup: mark folios referenced via a fast helper Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 10/17] mm/mglru, smaps: convert to LRU refs based operations for MGLRU Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 11/17] mm/damon: " Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 12/17] mm/khugepaged: " Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 13/17] mm/madvise: adapt for " Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 14/17] mm/huge_memory: mark folio as accessed more accurately on split Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 15/17] mm/mglru: folio LRU refs based active/inactive number accounting Kairui Song via B4 Relay
2026-11-18 21:29   ` sashiko-bot [this message]
2026-11-18 21:03 ` [PATCH v5 16/17] mm/mglru: make folio_inc_lru_refs lruvec lockless Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 17/17] mm/mglru: make folio_test_workingset() work based on folio LRU refs Kairui Song via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221996@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=baoquan.he@linux.dev \
    --cc=chenridong@xiaomi.com \
    --cc=chrisl@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=ehab.ababneh@intel.com \
    --cc=gourry@gourry.net \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=hui.zhu@linux.dev \
    --cc=joannelkoong@gmail.com \
    --cc=kasong@tencent.com \
    --cc=kunwu.chan@gmail.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=lianux.mm@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=liuxiang.277@bytedance.com \
    --cc=ljs@kernel.org \
    --cc=mhocko@kernel.org \
    --cc=mkoutny@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=nico.pache@linux.dev \
    --cc=nphamcs@gmail.com \
    --cc=qi.zheng@linux.dev \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=ryan.roberts@arm.com \
    --cc=ryncsn@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=sj@kernel.org \
    --cc=surenb@google.com \
    --cc=tj@kernel.org \
    --cc=tz2294@columbia.edu \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=vernon2gm@gmail.com \
    --cc=wangzicheng@honor.com \
    --cc=weixugc@google.com \
    --cc=willy@infradead.org \
    --cc=ying.huang@linux.alibaba.com \
    --cc=youngjun.park@lge.com \
    --cc=yuanchu@google.com \
    --cc=yuzhao@google.com \
    --cc=zhaozhengzhuo@uniontech.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox