From: sashiko-bot@kernel.org
To: "Andrew Morton" <akpm@linux-foundation.org>,
"Christian Brauner" <brauner@kernel.org>
Cc: linux-mm@kvack.org,
syzbot+4324f771847cecb27c54@syzkaller.appspotmail.com,
"Hugh Dickins" <hughd@google.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Miklos Szeredi" <mszeredi@redhat.com>
Subject: Re: [PATCH] shmem: consume the reserved xattr space despite remount
Date: Thu, 19 Nov 2026 18:23:23 +0000 [thread overview]
Message-ID: <sashiko-outbox-223766@kernel.org> (raw)
In-Reply-To: <00461f0c866d4a4eb9f50792f0e1f3d0.1@linux-foundation.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] shmem: Fixes trailer subject omits trailing pointer asterisks
--
commit 2c1ee388f6f3d6454e93c257214769e6a996663f
Author: Andrew Morton <akpm@linux-foundation.org>
> shmem: consume the reserved xattr space despite remount
>
> Creating a tmpfs inode can trigger WARN_ON(ispace) in shmem_initxattrs()
> when a concurrent remount sets nr_inodes=0. With panic_on_warn enabled,
> this warning can panic the machine.
>
> shmem_initxattrs() reserves space for the security xattrs while inode
> limits are enabled. It later tests max_inodes again before consuming that
> reservation for each installed xattr. If remount disables the limit
> between those steps, successfully installed xattrs leave a nonzero
> reservation behind.
>
> Use the remaining reservation, rather than the current mount policy, to
> decide whether to subtract the installed xattr's space. This also leaves
> the failure path with only the unconsumed reservation to refund.
>
> An initially unlimited filesystem cannot acquire an inode limit through
> remount: shmem_reconfigure() rejects that transition.
>
> Link: https://lore.kernel.org/20261105082717.c459bb33778fcf27e5675082@linux-foundation.org
> Fixes: 076e5cef28e2 ("simple_xattr: change interface to pass struct simple_xattrs")
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Reported-by: <syzbot+4324f771847cecb27c54@syzkaller.appspotmail.com>
> Closes: https://syzkaller.appspotcom/bug?extid=4324f771847cecb27c54
> Tested-by: syzbot+4324f771847cecb27c54@syzkaller.appspotmail.com
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
> Cc: Miklos Szeredi <mszeredi@redhat.com>
> Cc: Christian Brauner <brauner@kernel.org>
[Severity: Low]
The subject in the Fixes: tag is missing the trailing " **" from commit
076e5cef28e2 ("simple_xattr: change interface to pass struct simple_xattrs **").
Should this be:
Fixes: 076e5cef28e2 ("simple_xattr: change interface to pass struct simple_xattrs **")
--
Sashiko AI review · https://sashiko.dev/#/patchset/00461f0c866d4a4eb9f50792f0e1f3d0.1@linux-foundation.org?part=1
prev parent reply other threads:[~2026-11-19 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 18:23 [PATCH] shmem: consume the reserved xattr space despite remount Andrew Morton
2026-11-19 14:30 ` Christian Brauner
2026-11-19 18:23 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223766@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=mszeredi@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=syzbot+4324f771847cecb27c54@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox