Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yifan Feng" <evanfengff@gmail.com>, "SJ Park" <sj@kernel.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-mm@kvack.org
Subject: Re: [PATCH] mm/damon/core: fix damos_walk() hang with zero watermarks interval
Date: Fri, 20 Nov 2026 00:31:36 +0000	[thread overview]
Message-ID: <sashiko-outbox-224267@kernel.org> (raw)
In-Reply-To: <20261120001300.11809-1-evanfengff@gmail.com>

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] mm/damon: missing Signed-off-by trailer in commit message
- [Low] mm/damon: commit message body is an unedited mailing-list reply
- [Low] mm/damon: missing Fixes trailer for damos_walk() commit
  bf0eaba0ff9c
--

commit 47dbaffa25c5043afa14731164c912784e9890e4
Author: Yifan Feng <evanfengff@gmail.com>

> mm/damon/core: fix damos_walk() hang with zero watermarks interval
>
> On Wed, 18 Nov 2026 17:42:46 -0800 SJ Park <sj@kernel.org> wrote:
>
> [...]
> > But, this could make has_schemes_to_apply has false positive.  How about
> > calling damos_Walk_cancel() when has_schemes_to_apply is false, like below?
>
> Thanks for the review.  You are right about the false positive.
>
> I tried your change.  It fixes the hang, but has_schemes_to_apply is also
> false whenever no scheme has reached its next_apply_sis yet, so it cancels
> the walks of activated schemes too.  In my test (one stat scheme, default
> intervals) 18 of 20 update_schemes_tried_regions writes got -ECANCELED,
> and two selftests fail: sysfs_update_schemes_tried_regions_wss_estimation.py
> and sysfs_update_schemes_tried_regions_hang.py.
>
> What do you think about cancelling only when no scheme is activated?
>
> '''

[Severity: High]
The commit message is missing a Signed-off-by: trailer, which is required by
Documentation/process/submitting-patches.rst to certify the Developer's
Certificate of Origin.

[Severity: Low]
This isn't a code bug, but the commit description is an unedited mailing-list
reply ending with trailing single quotes rather than a standalone changelog
explaining why damos_walk() hangs with a zero watermarks interval and how
tracking activated schemes in kdamond_apply_schemes() resolves it.

[Severity: Low]
This fixes the damos_walk() hang when all schemes are deactivated with a zero
watermarks interval.  Should the commit message include:

  Fixes: bf0eaba0ff9c ("mm/damon/core: implement damos_walk()")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120001300.11809-1-evanfengff@gmail.com?part=1


  reply	other threads:[~2026-11-20  0:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 23:50 [PATCH] mm/damon/core: fix damos_walk() hang with zero watermarks interval Yifan Feng
2026-11-19  1:42 ` SJ Park
2026-11-20  0:13   ` Yifan Feng
2026-11-20  0:31     ` sashiko-bot [this message]
2026-11-20  0:49     ` SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224267@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=evanfengff@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox