From: sashiko-bot@kernel.org
To: "Ard Biesheuvel" <ardb+git@google.com>, linux-mm@kvack.org
Cc: "Ard Biesheuvel" <ardb@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Kent Overstreet" <kent.overstreet@linux.dev>,
"Hao Ge" <hao.ge@linux.dev>
Subject: Re: [PATCH v2] alloc_tag: Use __ prefixed ELF section names
Date: Fri, 20 Nov 2026 17:04:06 +0000 [thread overview]
Message-ID: <sashiko-outbox-225620@kernel.org> (raw)
In-Reply-To: <20261119170353.1835737-2-ardb+git@google.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] alloc_tag: missing Fixes: trailer for unprefixed alloc_tags
section name
--
commit 72a9298bf692412bdfb714d9d138e27a153a508b
Author: Ard Biesheuvel <ardb@kernel.org>
> alloc_tag: Use __ prefixed ELF section names
>
> The compiler will emit static relocations related to a section .foo into
> a separate section called .rela.foo, i.e., it just appends the section
> name to the string ".rela"
>
> When section names start with . or __, this results in section names
> that are correctly matched by the various pattern rules in the various
> linker scripts across the tree.
>
> Without any such leading delimiter, it may lead to spurious warnings
> such as
>
> >> ld: warning: orphan section `.relaalloc_tags' from `init/main.o' being placed in section `.rela.dyn'
> ld: warning: dot moved backwards before `.rela.dyn'
> ld: .tmp_vmlinux1: section `.rela.dyn' can't be allocated in segment 1
>
> Fix this by renaming the section to __alloc_tags. While at it, tweak the
> headers so that the definition appears only a single time.
>
> Cc: Suren Baghdasaryan <surenb@google.com>
> Cc: Kent Overstreet <kent.overstreet@linux.dev>
> Cc: Hao Ge <hao.ge@linux.dev>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
[Severity: Low]
Since this fixes the unprefixed alloc_tags section name that causes
orphan .relaalloc_tags linker warnings and build failures, should this
include a Fixes: tag?
Fixes: 22d407b164ff ("lib: add allocation tagging support for memory allocation profiling")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119170353.1835737-2-ardb+git@google.com?part=1
prev parent reply other threads:[~2026-11-20 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 17:03 [PATCH v2] alloc_tag: Use __ prefixed ELF section names Ard Biesheuvel
2026-11-20 17:04 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225620@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=hao.ge@linux.dev \
--cc=kent.overstreet@linux.dev \
--cc=linux-mm@kvack.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox