From: sashiko-bot@kernel.org
To: "Jarkko Sakkinen" <jarkko@kernel.org>
Cc: linux-mm@kvack.org, linux-security-module@vger.kernel.org,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Andreas Larsson" <andreas@gaisler.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Andy Lutomirski" <luto@kernel.org>,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
"Arnd Bergmann" <arnd@arndb.de>,
"Ben Segall" <bsegall@google.com>,
"Borislav Petkov" <bp@alien8.de>,
"Casey Schaufler" <casey@schaufler-ca.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Christian Brauner" <brauner@kernel.org>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Chris Zankel" <chris@zankel.net>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"David Hildenbrand" <david@kernel.org>,
"David Howells" <dhowells@redhat.com>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"David S. Miller" <davem@davemloft.net>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Hallgrimur H. Gunnarsson" <halg@google.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Helge Deller" <deller@gmx.de>, "H. Peter Anvin" <hpa@zytor.com>,
"Ingo Molnar" <mingo@redhat.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Jan Kara" <jack@suse.cz>,
"John Johansen" <john.johansen@canonical.com>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"Jonathan Corbet" <corbet@lwn.net>,
"Josef Bacik" <josef@toxicpanda.com>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Kees Cook" <kees@kernel.org>,
"K Prateek Nayak" <kprateek.nayak@amd.com>,
"Liam R. Howlett" <liam@infradead.org>,
"Lorenzo Stoakes" <ljs@kernel.org>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Magnus Lindholm" <linmag7@gmail.com>,
"Manfred Spraul" <manfred@colorfullife.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Matt Turner" <mattst88@gmail.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Mel Gorman" <mgorman@suse.de>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Michal Hocko" <mhocko@suse.com>,
"Michal Simek" <monstr@monstr.eu>,
"Mike Rapoport" <rppt@kernel.org>, "Neal Gompa" <neal@gompa.dev>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Moore" <paul@paul-moore.com>,
"Paul Walmsley" <pjw@kernel.org>,
"Pavel Tikhomirov" <ptikhomirov@virtuozzo.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Rich Felker" <dalias@libc.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Serge Hallyn" <sergeh@kernel.org>,
"Shrikanth Hegde" <sshegde@linux.ibm.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Thomas Gleixner" <tglx@kernel.org>,
"Valentin Schneider" <vschneid@redhat.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
"Vlastimil Babka" <vbabka@kernel.org>,
"Will Deacon" <will@kernel.org>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Zygmunt Krynicki" <zygmunt.krynicki@canonical.com>
Subject: Re: [RFC PATCH v4 09/14] fs: Support MOVE_MOUNT_T_MNTNS in move_mount()
Date: Fri, 20 Nov 2026 22:44:48 +0000 [thread overview]
Message-ID: <sashiko-outbox-226301@kernel.org> (raw)
In-Reply-To: <20261119224312.1037966-10-jarkko@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] fs: cross-userns mount locking bypass in attach_recursive_mnt()
--
commit 5e90ce5c3ee9b66d7c6a41077c19c225ae139217
Author: Jarkko Sakkinen <jarkko@kernel.org>
fs: Support MOVE_MOUNT_T_MNTNS in move_mount()
This commit adds the MOVE_MOUNT_T_MNTNS flag to move_mount() so that
detached anonymous mount trees can be attached directly into a target
mount namespace specified by an nsfs file descriptor.
> diff --git a/fs/namespace.c b/fs/namespace.c
> index dfe0ee9ecdcd0..36ed48c3f6467 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
[ ... ]
> @@ -2632,7 +2642,8 @@ enum mnt_tree_flags_t {
> * Otherwise a negative error code is returned.
> */
> static int attach_recursive_mnt(struct mount *source_mnt,
> - const struct pinned_mountpoint *dest)
> + const struct pinned_mountpoint *dest,
> + bool move_mntns)
> {
> struct mount *dest_mnt = dest->parent;
> struct mountpoint *dest_mp = dest->mp;
> @@ -2641,6 +2652,7 @@ static int attach_recursive_mnt(struct mount *source_mnt,
> struct user_namespace *user_ns = ns->user_ns;
> struct pinned_mountpoint root = {};
> struct mountpoint *shorter = NULL;
> + struct mnt_namespace *src_ns;
> struct mount *child, *p;
> struct mount *top;
> struct hlist_node *n;
> @@ -2662,6 +2674,7 @@ static int attach_recursive_mnt(struct mount *source_mnt,
> user_ns = current->nsproxy->mnt_ns->user_ns;
> else
> user_ns = ns->user_ns;
> + src_ns = moving ? NULL : source_mnt->mnt_ns;
>
> /*
> * Preallocate a mountpoint in case the new mounts need to be
> @@ -2694,6 +2707,12 @@ static int attach_recursive_mnt(struct mount *source_mnt,
> if (err)
> goto out_cleanup_ids;
>
> + if (move_mntns && src_ns && src_ns->user_ns != user_ns) {
> + lock_mnt_tree(source_mnt);
> + if (list_empty(&source_mnt->mnt_expire))
> + source_mnt->mnt.mnt_flags |= MNT_LOCKED;
> + }
[Severity: High]
Does calling lock_mnt_tree(source_mnt) after propagate_mnt() leave
secondary copies unlocked when MOVE_MOUNT_T_MNTNS attaches a tree onto a
shared destination mount across user namespaces?
When IS_MNT_SHARED(dest_mnt) is true, propagate_mnt() clones source_mnt
into tree_list before source_mnt is locked here, so the clones do not
inherit MNT_LOCK_* or MNT_LOCKED (and copy_tree() silently skips unlocked
nsfs submounts instead of failing with -EPERM). Then the tree_list loop
checks:
fs/namespace.c:attach_recursive_mnt() {
...
hlist_for_each_entry_safe(child, n, &tree_list, mnt_hash) {
struct mount *q;
hlist_del_init(&child->mnt_hash);
/* Notice when we are propagating across user namespaces */
if (child->mnt_parent->mnt_ns->user_ns != user_ns)
lock_mnt_tree(child);
...
}
Because user_ns is dest_mnt->mnt_ns->user_ns rather than src_ns->user_ns,
secondary copies propagated to peer or slave mounts in the target user
namespace match user_ns and skip lock_mnt_tree(child), allowing root in
the target user namespace to unmount masking submounts or clear read-only,
nosuid, nodev, and noexec flags.
In addition, if a foreign anonymous mount from another user namespace was
previously attached via regular move_mount() as a submount of an anonymous
mount tree already owned by the target user namespace, commit_tree() set
the submount's mnt_ns to the anonymous tree without setting MNT_LOCKED on
that submount's root, and attaching the anonymous tree with
MOVE_MOUNT_T_MNTNS skips lock_mnt_tree() because src_ns->user_ns already
equals user_ns.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119224312.1037966-1-jarkko@kernel.org?part=9
next prev parent reply other threads:[~2026-11-20 22:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 22:42 [RFC PATCH v4 00/14] Namespace for namespace roots Jarkko Sakkinen
2026-11-19 22:42 ` [RFC PATCH v4 01/14] nsproxy: Pass nsproxy to create_new_namespaces() Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 02/14] rootns: Add core infrastructure for root namespaces Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 03/14] rootns: Track init lifecycle via copy_process() and pid_namespace Jarkko Sakkinen
2026-11-20 13:18 ` Alexander Mikhalitsyn
2026-11-20 13:30 ` Jarkko Sakkinen
2026-11-20 15:24 ` Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 04/14] rootns: Add rootns() system call Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 05/14] rootns: Add ROOTNS_WAIT ioctl Jarkko Sakkinen
2026-11-20 22:44 ` sashiko-bot
2026-11-19 22:43 ` [RFC PATCH v4 06/14] rootns: Add ROOTNS_KILL ioctl Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 07/14] fork: Support CLONE_INTO_ROOTNS in clone3() Jarkko Sakkinen
2026-11-20 10:33 ` Jarkko Sakkinen
2026-11-20 12:47 ` Jarkko Sakkinen
2026-11-20 22:44 ` sashiko-bot
2026-11-19 22:43 ` [RFC PATCH v4 08/14] fs: Support FSCONFIG_SET_ROOTNS in fsconfig() Jarkko Sakkinen
2026-11-20 22:44 ` sashiko-bot
2026-11-19 22:43 ` [RFC PATCH v4 09/14] fs: Support MOVE_MOUNT_T_MNTNS in move_mount() Jarkko Sakkinen
2026-11-20 22:44 ` sashiko-bot [this message]
2026-11-19 22:43 ` [RFC PATCH v4 10/14] security: Add rootns LSM hooks Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 11/14] arch: Wire up rootns() system call Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 12/14] docs: Document root namespace uAPI Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 13/14] selftests/rootns: Add root namespace test suite Jarkko Sakkinen
2026-11-20 22:44 ` sashiko-bot
2026-11-19 22:43 ` [RFC PATCH v4 14/14] MAINTAINERS: Add entry for ROOT NAMESPACE Jarkko Sakkinen
2026-11-20 5:58 ` [RFC PATCH v4 00/14] Namespace for namespace roots Jarkko Sakkinen
2026-11-20 10:10 ` Jarkko Sakkinen
2026-11-20 10:24 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-226301@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=andreas@gaisler.com \
--cc=anna-maria@linutronix.de \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=bsegall@google.com \
--cc=casey@schaufler-ca.com \
--cc=catalin.marinas@arm.com \
--cc=chleroy@kernel.org \
--cc=chris@zankel.net \
--cc=corbet@lwn.net \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gor@linux.ibm.com \
--cc=halg@google.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jack@suse.cz \
--cc=jarkko@kernel.org \
--cc=jcmvbkbc@gmail.com \
--cc=john.johansen@canonical.com \
--cc=josef@toxicpanda.com \
--cc=juri.lelli@redhat.com \
--cc=kees@kernel.org \
--cc=kprateek.nayak@amd.com \
--cc=liam@infradead.org \
--cc=linmag7@gmail.com \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ljs@kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=maddy@linux.ibm.com \
--cc=manfred@colorfullife.com \
--cc=mark.rutland@arm.com \
--cc=mattst88@gmail.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=neal@gompa.dev \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul@paul-moore.com \
--cc=peterz@infradead.org \
--cc=pjw@kernel.org \
--cc=ptikhomirov@virtuozzo.com \
--cc=rdunlap@infradead.org \
--cc=richard.henderson@linaro.org \
--cc=ritesh.list@gmail.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sergeh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=sshegde@linux.ibm.com \
--cc=surenb@google.com \
--cc=svens@linux.ibm.com \
--cc=tglx@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=vbabka@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vincenzo.frascino@arm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
--cc=ysato@users.sourceforge.jp \
--cc=zygmunt.krynicki@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox