Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Shakeel Butt" <shakeel.butt@linux.dev>,
	"Tejun Heo" <tj@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutny" <mkoutny@suse.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Michal Hocko" <mhocko@kernel.org>,
	"Roman Gushchin" <roman.gushchin@linux.dev>,
	"Muchun Song" <muchun.song@linux.dev>, "Jan Kara" <jack@suse.cz>,
	"Matthew Wilcox" <willy@infradead.org>,
	"David Hildenbrand" <david@kernel.org>,
	"Vlastimil Babka" <vbabka@kernel.org>, "Zi Yan" <ziy@nvidia.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Nico Pache" <nico.pache@linux.dev>,
	"Usama Arif" <usama.arif@linux.dev>,
	"Kiryl Shutsemau" <kas@kernel.org>,
	"Lorenzo Stoakes" <ljs@kernel.org>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Meta kernel team" <kernel-team@meta.com>,
	linux-mm@kvack.org, dsterba@suse.cz
Subject: Re: [RFC PATCH 2/7] mm/gup: handle memory.high overage while populating
Date: Sun, 22 Nov 2026 03:06:03 +0000	[thread overview]
Message-ID: <sashiko-outbox-227657@kernel.org> (raw)
In-Reply-To: <20261122024737.2741569-3-shakeel.butt@linux.dev>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] mm: unsigned long overflow to 0 in populate_chunk_end() near
  top of address space
--

commit ec48ff5e44f8914e2b82f0cee190a74feb7645ec
Author: Shakeel Butt <shakeel.butt@linux.dev>

mm/gup: handle memory.high overage while populating

This commit chunks page fault-in loops in __mm_populate() and
madvise_populate() into 2 MiB ranges and drops mmap_lock between chunks to
handle pending memory.high overage.

> diff --git a/mm/internal.h b/mm/internal.h
> index de4593b3e3b60..12f7b4b1254fe 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -948,6 +948,33 @@ extern long populate_vma_page_range(struct vm_area_struct *vma,
>  		unsigned long start, unsigned long end, int *locked);
>  extern long faultin_page_range(struct mm_struct *mm, unsigned long start,
>  		unsigned long end, bool write, int *locked);
> +
> +/*
> + * __mm_populate() and madvise_populate() fault in at most
> + * POPULATE_CHUNK_SIZE at a time, and handle memory.high overage between
> + * chunks with mmap_lock dropped, so other tasks don't wait for them.
> + */
> +#define POPULATE_CHUNK_SIZE	SZ_2M
> +
> +static inline unsigned long populate_chunk_end(unsigned long start,
> +					       unsigned long end)
> +{
> +	return min(end, round_down(start, POPULATE_CHUNK_SIZE) +
> +			POPULATE_CHUNK_SIZE);
> +}

[Severity: High]
Can populate_chunk_end() overflow to 0 when start is within the top
POPULATE_CHUNK_SIZE (2 MiB) of the unsigned long address space?

When start >= ULONG_MAX - POPULATE_CHUNK_SIZE + 1,
round_down(start, POPULATE_CHUNK_SIZE) + POPULATE_CHUNK_SIZE wraps to 0, so
min(end, 0) returns 0. Passing 0 as end to populate_vma_page_range() or
faultin_page_range() underflows nr_pages = (end - start) / PAGE_SIZE to
(0 - start) / PAGE_SIZE, faulting pages past the requested end boundary. If a
VMA in that range has VM_LOCKONFAULT set (for example, on 32-bit parisc or
64-bit s390 where TASK_SIZE reaches the top 2 MiB), populate_vma_page_range()
returns that wrapped nr_pages and __mm_populate() computes
nend = nstart + ret * PAGE_SIZE == 0, looping forever from address 0 with
mmap_read_lock(mm) held.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122024737.2741569-1-shakeel.butt@linux.dev?part=2


  reply	other threads:[~2026-11-22  3:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22  2:47 [RFC PATCH 0/7] memcg: effective high limit that avoids isolation issues Shakeel Butt
2026-11-22  2:47 ` [RFC PATCH 1/7] memcg: add helpers to handle memory.high overage in long operations Shakeel Butt
2026-11-22  2:47 ` [RFC PATCH 2/7] mm/gup: handle memory.high overage while populating Shakeel Butt
2026-11-22  3:06   ` sashiko-bot [this message]
2026-11-22  2:47 ` [RFC PATCH 3/7] mm, fs: handle memory.high overage in buffered reads and writes Shakeel Butt
2026-11-22  3:06   ` sashiko-bot
2026-11-22  2:47 ` [RFC PATCH 4/7] mm/shmem: handle memory.high overage in fallocate and reads Shakeel Butt
2026-11-22  2:47 ` [RFC PATCH 5/7] mm/khugepaged: handle memory.high overage in MADV_COLLAPSE Shakeel Butt
2026-11-22  2:47 ` [RFC PATCH 6/7] memcg: remove synchronous memory.high enforcement Shakeel Butt
2026-11-22  3:06   ` sashiko-bot
2026-11-22  2:47 ` [RFC PATCH 7/7] selftests/cgroup: make test_memcg_high_sync check that throttling holds Shakeel Butt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227657@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=brauner@kernel.org \
    --cc=david@kernel.org \
    --cc=dsterba@suse.cz \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=kas@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@kernel.org \
    --cc=mkoutny@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=nico.pache@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=surenb@google.com \
    --cc=tj@kernel.org \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=willy@infradead.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox