Re: PATCH: Bug in invalidate_inode_pages()?

Juan J. Quintela
2000-05-08T23:55:52Z

>>>>> "linus" == Linus Torvalds <torvalds@transmeta.com> writes:

Hi

linus> On 9 May 2000, Juan J. Quintela wrote:
>> I think that I have found a bug in invalidate_inode_pages.
>> It results that we don't remove the pages from the
>> &inode->i_mapping->pages list, then when we return te do the next loop
>> through all the pages, we can try to free a page that we have freed in
>> the previous pass.

linus> This is what "remove_inode_page()" does. Maybe that's not quite clear
linus> enough, so this function may certainly need some comments or something
linus> like that, but your patch is wrong (it will now delete the thing twice,
linus> which can and will result in list corruption).

Then there is the same inode->i_mapping_>pages list and page->list?
If that is the case I think that I would make one comment there
indicating that.

Later, Juan.

--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy