linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Ming Li" <mingli199x@qq.com>
To: "Andrew Morton" <akpm@linux-foundation.org>,
	"Michal Hocko" <mhocko@suse.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	"David Rientjes" <rientjes@google.com>,
	"Vlastimil Babka" <Babkavbabka@suse.cz>,
	"Tejun Heo" <tj@kernel.org>
Cc: linux-mm <linux-mm@kvack.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] mm: put activate_page_pvecs and others pagevec together
Date: Mon, 11 Apr 2016 09:16:29 +0800	[thread overview]
Message-ID: <tencent_396EED8911B375260606A8A3@qq.com> (raw)

hi, I have been studying mm and learn agexxx, at the very beginning I felt confuse when I saw activatexxx, after I learned the whole thing I understood that it's similar with other pagevec's function. Can we put it with other pagevec together? I think it is easier for newbies to read and understand.

regards,



Signed-off-by: Ming Li <mingli199x@qq.com>

---
mm/swap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/swap.c b/mm/swap.c
index 09fe5e9..5c9901c 100644
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -47,6 +47,9 @@ static DEFINE_PER_CPU(struct pagevec, lru_add_pvec);
static DEFINE_PER_CPU(struct pagevec, lru_rotate_pvecs);
static DEFINE_PER_CPU(struct pagevec, lru_deactivate_file_pvecs);
static DEFINE_PER_CPU(struct pagevec, lru_deactivate_pvecs);
+#ifdef CONFIG_SMP
+static DEFINE_PER_CPU(struct pagevec, activate_page_pvecs);
+#endif

/*
* This path almost never happens for VM activity - pages are normally
@@ -274,8 +277,6 @@ static void __activate_page(struct page *page, struct lruvec *lruvec,
}

#ifdef CONFIG_SMP
-static DEFINE_PER_CPU(struct pagevec, activate_page_pvecs);
-
static void activate_page_drain(int cpu)
{
struct pagevec *pvec = &per_cpu(activate_page_pvecs, cpu);
-- 
1.8.3.1

             reply	other threads:[~2016-04-11  1:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11  1:16 Ming Li [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-04-11  1:36 [PATCH] mm: put activate_page_pvecs and others pagevec together Ming Li
2016-04-27 21:03 ` Andrew Morton
2016-04-11  1:16 Ming Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_396EED8911B375260606A8A3@qq.com \
    --to=mingli199x@qq.com \
    --cc=Babkavbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=rientjes@google.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).