[PATCH] mm: put activate_page_pvecs and others pagevec together

[PATCH] mm: put activate_page_pvecs and others pagevec together

[Ming Li]

hi, I have been studying mm and learn agexxx, at the very beginning I felt confuse when I saw activatexxx, after I learned the whole thing I understood that it's similar with other pagevec's function. Can we put it with other pagevec together? I think it is easier for newbies to read and understand.

regards,



Signed-off-by: Ming Li <mingli199x@qq.com>

---
mm/swap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/swap.c b/mm/swap.c
index 09fe5e9..5c9901c 100644
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -47,6 +47,9 @@ static DEFINE_PER_CPU(struct pagevec, lru_add_pvec);
static DEFINE_PER_CPU(struct pagevec, lru_rotate_pvecs);
static DEFINE_PER_CPU(struct pagevec, lru_deactivate_file_pvecs);
static DEFINE_PER_CPU(struct pagevec, lru_deactivate_pvecs);
+#ifdef CONFIG_SMP
+static DEFINE_PER_CPU(struct pagevec, activate_page_pvecs);
+#endif

/*
* This path almost never happens for VM activity - pages are normally
@@ -274,8 +277,6 @@ static void __activate_page(struct page *page, struct lruvec *lruvec,
}

#ifdef CONFIG_SMP
-static DEFINE_PER_CPU(struct pagevec, activate_page_pvecs);
-
static void activate_page_drain(int cpu)
{
struct pagevec *pvec = &per_cpu(activate_page_pvecs, cpu);
-- 
1.8.3.1

[PATCH] mm: put activate_page_pvecs and others pagevec together

[Ming Li]

hi, I have been studying mm and learn agexxx, at the very beginning I felt confuse when I saw activatexxx, after I learned the whole thing I understood that it's similar with other pagevec's function. Can we put it with other pagevec together? I think it is easier for newbies to read and understand.

regards,



Signed-off-by: Ming Li <mingli199x@qq.com>

---
mm/swap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/swap.c b/mm/swap.c
index 09fe5e9..5c9901c 100644
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -47,6 +47,9 @@ static DEFINE_PER_CPU(struct pagevec, lru_add_pvec);
static DEFINE_PER_CPU(struct pagevec, lru_rotate_pvecs);
static DEFINE_PER_CPU(struct pagevec, lru_deactivate_file_pvecs);
static DEFINE_PER_CPU(struct pagevec, lru_deactivate_pvecs);
+#ifdef CONFIG_SMP
+static DEFINE_PER_CPU(struct pagevec, activate_page_pvecs);
+#endif

/*
* This path almost never happens for VM activity - pages are normally
@@ -274,8 +277,6 @@ static void __activate_page(struct page *page, struct lruvec *lruvec,
}

#ifdef CONFIG_SMP
-static DEFINE_PER_CPU(struct pagevec, activate_page_pvecs);
-
static void activate_page_drain(int cpu)
{
struct pagevec *pvec = &per_cpu(activate_page_pvecs, cpu);
-- 
1.8.3.1

[PATCH] mm: put activate_page_pvecs and others pagevec together

[Ming Li]

hi, i`m sorry, I made some mistakes in last email. I have been studying mm and learn age_activate_anon(), at the very beginning I felt confuse when I saw activate_page_pvecs, after I learned the whole thing I understood that it's similar with other pagevec's function. Can we put it with other pagevec together? I think it is easier for newbies to read and understand.

regards,



Signed-off-by: Ming Li <mingli199x@qq.com>

---
mm/swap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/swap.c b/mm/swap.c
index 09fe5e9..5c9901c 100644
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -47,6 +47,9 @@ static DEFINE_PER_CPU(struct pagevec, lru_add_pvec);
static DEFINE_PER_CPU(struct pagevec, lru_rotate_pvecs);
static DEFINE_PER_CPU(struct pagevec, lru_deactivate_file_pvecs);
static DEFINE_PER_CPU(struct pagevec, lru_deactivate_pvecs);
+#ifdef CONFIG_SMP
+static DEFINE_PER_CPU(struct pagevec, activate_page_pvecs);
+#endif

/*
* This path almost never happens for VM activity - pages are normally
@@ -274,8 +277,6 @@ static void __activate_page(struct page *page, struct lruvec *lruvec,
}

#ifdef CONFIG_SMP
-static DEFINE_PER_CPU(struct pagevec, activate_page_pvecs);
-
static void activate_page_drain(int cpu)
{
struct pagevec *pvec = &per_cpu(activate_page_pvecs, cpu);
-- 
1.8.3.1

Re: [PATCH] mm: put activate_page_pvecs and others pagevec together

[Andrew Morton]

On Mon, 11 Apr 2016 09:36:46 +0800 "Ming Li" <mingli199x@qq.com> wrote:

> hi, i`m sorry, I made some mistakes in last email. I have been studying mm and learn age_activate_anon(), at the very beginning I felt confuse when I saw activate_page_pvecs, after I learned the whole thing I understood that it's similar with other pagevec's function. Can we put it with other pagevec together? I think it is easier for newbies to read and understand.

Welcome to kernel development ;)

Your email client is mangling the patches in several ways.  Please sort
that out for next time - mail yourself a patch, check that it applies.

The changelog text wasn't very conventional.  I rewrote it to

: Put the activate_page_pvecs definition next to those of the other
: pagevecs, for clarity.

and I changed the title to 

Subject: mm/swap.c: put activate_page_pvecs and other pagevecs together

because "mm" is a big place!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>