linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, torvalds@linux-foundation.org,
	peterz@infradead.org, anton@redhat.com,
	jkenisto@linux.vnet.ibm.com, rostedt@goodmis.org,
	oleg@redhat.com, tglx@linutronix.de, linux-mm@kvack.org,
	hpa@zytor.com, linux-kernel@vger.kernel.org, andi@firstfloor.org,
	hch@infradead.org, ananth@in.ibm.com,
	masami.hiramatsu.pt@hitachi.com, acme@infradead.org,
	srikar@linux.vnet.ibm.com
Subject: [tip:perf/uprobes] tracing: Modify is_delete, is_return from int to bool
Date: Mon, 7 May 2012 21:07:06 -0700	[thread overview]
Message-ID: <tip-3a6b76661da8e92124a813b43607f5bec1a618de@git.kernel.org> (raw)
In-Reply-To: <20120409091133.8343.65289.sendpatchset@srdronam.in.ibm.com>

Commit-ID:  3a6b76661da8e92124a813b43607f5bec1a618de
Gitweb:     http://git.kernel.org/tip/3a6b76661da8e92124a813b43607f5bec1a618de
Author:     Srikar Dronamraju <srikar@linux.vnet.ibm.com>
AuthorDate: Mon, 9 Apr 2012 14:41:33 +0530
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 7 May 2012 14:29:35 +0200

tracing: Modify is_delete, is_return from int to bool

is_delete and is_return can take utmost 2 values and are better
of being a boolean than a int. There are no functional changes.

Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Jim Keniston <jkenisto@linux.vnet.ibm.com>
Cc: Linux-mm <linux-mm@kvack.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Anton Arapov <anton@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20120409091133.8343.65289.sendpatchset@srdronam.in.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/trace/trace_kprobe.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index 580a05e..4f935f8 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -651,7 +651,7 @@ static struct trace_probe *alloc_trace_probe(const char *group,
 					     void *addr,
 					     const char *symbol,
 					     unsigned long offs,
-					     int nargs, int is_return)
+					     int nargs, bool is_return)
 {
 	struct trace_probe *tp;
 	int ret = -ENOMEM;
@@ -944,7 +944,7 @@ static int split_symbol_offset(char *symbol, unsigned long *offset)
 #define PARAM_MAX_STACK (THREAD_SIZE / sizeof(unsigned long))
 
 static int parse_probe_vars(char *arg, const struct fetch_type *t,
-			    struct fetch_param *f, int is_return)
+			    struct fetch_param *f, bool is_return)
 {
 	int ret = 0;
 	unsigned long param;
@@ -977,7 +977,7 @@ static int parse_probe_vars(char *arg, const struct fetch_type *t,
 
 /* Recursive argument parser */
 static int __parse_probe_arg(char *arg, const struct fetch_type *t,
-			     struct fetch_param *f, int is_return)
+			     struct fetch_param *f, bool is_return)
 {
 	int ret = 0;
 	unsigned long param;
@@ -1089,7 +1089,7 @@ static int __parse_bitfield_probe_arg(const char *bf,
 
 /* String length checking wrapper */
 static int parse_probe_arg(char *arg, struct trace_probe *tp,
-			   struct probe_arg *parg, int is_return)
+			   struct probe_arg *parg, bool is_return)
 {
 	const char *t;
 	int ret;
@@ -1162,7 +1162,7 @@ static int create_trace_probe(int argc, char **argv)
 	 */
 	struct trace_probe *tp;
 	int i, ret = 0;
-	int is_return = 0, is_delete = 0;
+	bool is_return = false, is_delete = false;
 	char *symbol = NULL, *event = NULL, *group = NULL;
 	char *arg;
 	unsigned long offset = 0;
@@ -1171,11 +1171,11 @@ static int create_trace_probe(int argc, char **argv)
 
 	/* argc must be >= 1 */
 	if (argv[0][0] == 'p')
-		is_return = 0;
+		is_return = false;
 	else if (argv[0][0] == 'r')
-		is_return = 1;
+		is_return = true;
 	else if (argv[0][0] == '-')
-		is_delete = 1;
+		is_delete = true;
 	else {
 		pr_info("Probe definition must be started with 'p', 'r' or"
 			" '-'.\n");

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2012-05-08  4:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09  9:11 [PATCH 1/3] tracing: Modify is_delete, is_return from int to bool Srikar Dronamraju
2012-04-09  9:11 ` [PATCH 2/3] tracing: Extract out common code for kprobes/uprobes trace events Srikar Dronamraju
2012-04-12 12:47   ` Masami Hiramatsu
2012-05-08  4:08   ` [tip:perf/uprobes] tracing: Extract out common code for kprobes/ uprobes " tip-bot for Srikar Dronamraju
2012-04-09  9:11 ` [PATCH 3/3] tracing: Provide trace events interface for uprobes Srikar Dronamraju
2012-04-11 10:30   ` [PATCH UPDATED " Srikar Dronamraju
2012-04-12 13:02     ` Masami Hiramatsu
2012-04-12 14:49       ` Srikar Dronamraju
2012-04-13  2:28         ` Masami Hiramatsu
2012-04-12 13:14     ` Steven Rostedt
2012-04-14 11:12       ` Ingo Molnar
2012-04-16  9:22         ` Srikar Dronamraju
2012-04-20  9:57         ` Srikar Dronamraju
2012-05-08  4:09     ` [tip:perf/uprobes] " tip-bot for Srikar Dronamraju
2012-05-08  4:12     ` [PATCH UPDATED 3/3] " Ingo Molnar
2012-05-08  8:30       ` Peter Zijlstra
2012-05-08  8:50         ` Srikar Dronamraju
2012-05-08  9:20           ` Ingo Molnar
2012-05-08  9:19             ` Srikar Dronamraju
2012-04-12 12:42 ` [PATCH 1/3] tracing: Modify is_delete, is_return from int to bool Masami Hiramatsu
2012-05-08  4:07 ` tip-bot for Srikar Dronamraju [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-3a6b76661da8e92124a813b43607f5bec1a618de@git.kernel.org \
    --to=srikar@linux.vnet.ibm.com \
    --cc=acme@infradead.org \
    --cc=ananth@in.ibm.com \
    --cc=andi@firstfloor.org \
    --cc=anton@redhat.com \
    --cc=hch@infradead.org \
    --cc=hpa@zytor.com \
    --cc=jkenisto@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).