From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 398FBC83F1B for ; Fri, 11 Jul 2025 19:17:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C08D56B009A; Fri, 11 Jul 2025 15:17:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB9EF6B009C; Fri, 11 Jul 2025 15:17:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD00D6B009D; Fri, 11 Jul 2025 15:17:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 992EE6B009A for ; Fri, 11 Jul 2025 15:17:31 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3F1B0805E7 for ; Fri, 11 Jul 2025 19:17:31 +0000 (UTC) X-FDA: 83652942702.19.7F4548B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 75E66A0011 for ; Fri, 11 Jul 2025 19:17:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VqcQoHXn; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of alx@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=alx@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752261449; a=rsa-sha256; cv=none; b=Rrq3g3Nym8Ona1+kN5zTjelPBLPARrs0hXO2my+Pkw6wxYRd0FMWgrMJAv7CaI7ouSo7+h vtgsNdnqVfwrVTPbcgaAJKwray2120I6nf//00dWV5F9eamhwSg6MfYTb/4Sv25CaUtxT6 6VFJp0CJyVXJlkJ0mGCVUr+MtkEV17Y= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VqcQoHXn; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of alx@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=alx@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752261449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Sue4U5h07UOwUTxFMzgE6eTiGZQCUp/7S+alX1FYF0=; b=oIBovPL0FUcS9KnnXgCemzNfzHjyU7AGkHVMqX8K6cQAud7LJ8Liz75ywrVPef1uD2hwYa JRJuiHw3v7wRJd7Flh+5fljpJWw2jirVAeIpyy87aKbWYYonF6We2KkD3X3v7CbJtScl/T HpFofYJ/+ZE3QkFaAcPm4Bnetz8dVlU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 580FF5C5D56; Fri, 11 Jul 2025 19:17:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34C1DC4CEED; Fri, 11 Jul 2025 19:17:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752261448; bh=cnwXPm+/VNTBwjjvNe6tPqkD4dF66c733bbdlBZZNUA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VqcQoHXnKdfggPdW7n5guANWD5ndb/jrsaz0GwPn5c+oGfLUKx+9N7vGNViLnCx5N F7BUqiwvDjP8Zzpee2lr+F859rAMzUuuAgSbqTAkv0T2d9QD3Rb4kFpWpOTIHdjYm8 s0iOvroIM2aLuCx0Eg1Ed9ScxbfgrTexwAq0T/waNzFZCjp5LzYaRx+YT1At69tAQg JJ4ujuJGGiJiTedoUkN2tjfeM6cnKF7bq1h0AsFw4dBVd1/PtZmHbnCLLFgxIxc928 rszWuN431xni2f8dJtz31gaRi3voyVeL3TIX9OFFv5fPrulYxjYYgh3/Z6SUu1Cn0i 0gKNswrayJzuw== Date: Fri, 11 Jul 2025 21:17:20 +0200 From: Alejandro Colomar To: David Laight Cc: Linus Torvalds , linux-mm@kvack.org, linux-hardening@vger.kernel.org, Kees Cook , Christopher Bazley , shadow <~hallyn/shadow@lists.sr.ht>, linux-kernel@vger.kernel.org, Andrew Morton , kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Marco Elver , Christoph Lameter , David Rientjes , Vlastimil Babka , Roman Gushchin , Harry Yoo , Andrew Clayton , Rasmus Villemoes , Michal Hocko , Al Viro , Martin Uecker , Sam James , Andrew Pinski Subject: Re: [RFC v5 6/7] sprintf: Add [v]sprintf_array() Message-ID: References: <04c1e026a67f1609167e834471d0f2fe977d9cb0.1752182685.git.alx@kernel.org> <20250711184343.5eabd457@pumpkin> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="744n7ojxglqyswg3" Content-Disposition: inline In-Reply-To: <20250711184343.5eabd457@pumpkin> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 75E66A0011 X-Stat-Signature: ruqzb4s91ar4w6wt16gc4hetok4k1z9j X-Rspam-User: X-HE-Tag: 1752261449-203211 X-HE-Meta: U2FsdGVkX1+goZGJIbXdF6VvQPbVLs2MUhvLxD42l58jlfE4Jhju8TIP5H7Lu7YwdovZpiWNzCdhVGtUuBYJo7/vzUNL/OAk8Aft6BfvPvigggYIIox6v/lRwzeVN7YsIiTtap7rSjzXX0ThDzZZOl7EuUMNwDYjWpWr7jTpT4YJcd4+7a8+JvV3QEjnglGNXg7rqSG5VxlAb3A6JcK+pD+seQA3/LcpVnmL2zMfBZAh12zwUt0QziNwrvMxJeeK7SDs6J8rxCY+WCfZRpSauz3wcN000FydpufJJbQhS/XBO01ZBkW6Kmfk1zn+SIQqRCiA5E6GeWvDYsaYY1j/8f2Zp4H1TcC0CC9umzY0wK3MKRAZ1mASyDOkZe0kCMtJlpK/d6y+pHX7FggXscBCscufCNoURbvE30R9Rc1Iu3iXB42M6O6ve+gLcKB57OEQHs7glKvUC9EXLslJCG90d9TAd/fyJwNX6Zvf6qYHYiAQk/MOpyqhF1iZvo5tdr7GQqDKmr0GnTxbbT/fEE0d1pQ+BG6jXcEAyWgqvkCnMSiyVwgSaASh2mchIkMs6yOSYgaPSacFdsOhnulVcftDcbvZbxSMWDsrGM9zQp2rmGtSDiDWlFcbpXSGzRNZkN6oLyScHcKhZlu1gUrBy1W0SCBgQiOkYCgwnFj6NQ63aU9wxs/JSEZDU8Wq3hlvht0lT2wFO0W0a327ii40+kNu02njrUpbYSfNByupHR0lFL9ElBGE/f4FVZYpdWF276WBV0tcjyNrda8yP5PXMB9l683nDogthzy67YFos99advsac7aLeaWmiOqEkE7Tw7IZ9bzpdn/NtWFedbg6+VqeOH4oOhzAPsCshRBnsnRQ1VLXiJmtSIzLs2JtFFc/D+cUrZeYrGA1NtjudCYpUhilppazBTyEmiZQldlNVNkpilgjI3CE0MY9M19Wa95+ndPKEx8Jzj05rcMLkhTVtQt Hw1eow2w puXxJz8hRWGjzHLJdHnWfATB8JcsjHWCLbXZpIc6l2TjSeQo2jl/LSjWtGOSJOJlUrTviAbVQpGSk7E7SsYQ6vOvswqzJAV770lA0wZbc01lkCd5Cuf0vh/f2OUvkNrwdPgmiOQRNQw2Auj6k3/J1Z1acEkXNkVnkRsxUmLT14iHM5LTyXATCQkAnOUY7oJNnntt/lE0z/NzHenjbJzYAKgcu0m/x+s1Rvy7ZsGIYMkDsHNZQDhv6XoMmuzI2etOaWlA4vy76tHi1s2/BqfOXcaetVDcJCQos8auBYGwcJADmOrxlTfHQo3KQ8mhx2Pd/7Omlgq9EFdq5o/7zMTCamX/CLt6bxd4JcxTXZNWU7vC0YG4uop2ReyR7uLGLEa+q2m5aots0l40Qw5tM5OTuKjMQ/dEMf72kJaRmqltlzhYONruRpS9zShSRgHKpb5PdqRLK7ArpCDJOmDU/kLf8mUbkxVud71DyEon75Y+Murx5mT7sGAS986RxNqkMt8Kkk/m5AQ/WvPb14qo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --744n7ojxglqyswg3 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable From: Alejandro Colomar To: David Laight Cc: Linus Torvalds , linux-mm@kvack.org, linux-hardening@vger.kernel.org, Kees Cook , Christopher Bazley , shadow <~hallyn/shadow@lists.sr.ht>, linux-kernel@vger.kernel.org, Andrew Morton , kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Marco Elver , Christoph Lameter , David Rientjes , Vlastimil Babka , Roman Gushchin , Harry Yoo , Andrew Clayton , Rasmus Villemoes , Michal Hocko , Al Viro , Martin Uecker , Sam James , Andrew Pinski Subject: Re: [RFC v5 6/7] sprintf: Add [v]sprintf_array() References: <04c1e026a67f1609167e834471d0f2fe977d9cb0.1752182685.git.alx@kernel.org> <20250711184343.5eabd457@pumpkin> MIME-Version: 1.0 In-Reply-To: <20250711184343.5eabd457@pumpkin> Hi David, On Fri, Jul 11, 2025 at 06:43:43PM +0100, David Laight wrote: > On Fri, 11 Jul 2025 01:23:49 +0200 > Alejandro Colomar wrote: >=20 > > Hi Linus, > >=20 > > [I'll reply to both of your emails at once] > >=20 > > On Thu, Jul 10, 2025 at 02:58:24PM -0700, Linus Torvalds wrote: > > > You took my suggestion, and then you messed it up. > > >=20 > > > Your version of sprintf_array() is broken. It evaluates 'a' twice. > > > Because unlike ARRAY_SIZE(), your broken ENDOF() macro evaluates the > > > argument. =20 > >=20 > > An array has no issue being evaluated twice (unless it's a VLA). On the > > other hand, I agree it's better to not do that in the first place. > > My bad for forgetting about it. Sorry. >=20 > Or a function that returns an array... Actually, I was forgetting that the array could be gotten from a pointer to array: int (*ap)[42] =3D ...; ENDOF(ap++); // Evaluates ap++ Anyway, fixed in v6. Cheers, Alex --=20 --744n7ojxglqyswg3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmhxYzoACgkQ64mZXMKQ wqkjfQ/7B1Jy0fUNlWDy/S4747BI6FB8QvtJDXSmUh+9JUnYeA3/UC+7bZqstMwk GNhbO5oX4r84xDPdJIpjEtKv7qkA9VkBWVG13PS6irDPYfqXblRyzEV6U9bissR2 Qc+WUC7mmpZvUXCjQXyVTsw4SHsfot41d2A+45wpof5Nc3lZXgzQD4Z56iH9PV6Z /iyu8MGKu+eiso+/DaPStdC7xXj3acrjZK2L+JUuVmq28TBJnRcl6cUsvZITFg69 rq/XCYTJGjMEa9tLrn51Q2/TNTV+okSrLJl+0txHm1vCsVZ9L+GJ8VTIMkhAZft6 m3nYday4EgSz7QXrXYvj/LcpVfwrMRosgiEfHY4zL/7V55sObXyhrukHIpyaUfxu q9E2T9FertPMmgKdNSadfJSht+uoRR8evxf8Xtry13aUqi7E3tIGL8/tCymdZAPq 6nANf7I8A8m/FBAMVtyg0mZS233L0oRG4hhWcG+umzzH6wwX9fDdNpB4X0FQMRJG 32U3uJbXK6GKcKU+igB9QpTW1DZlqXIGpT3rfLMweKoXOtfyNzZs51g7DMzVoYWh Gl2Y0AO/rvYjwKhQydwVxukWpdtqJ9j3wiegSl2EKQx+4nZH0z7eKiRvOaG1N0TO wEFZe8rebmqPxSLrJX6mKcTvOfvU4+5y/tStHrgRZ2ONh5BiGsg= =Ka9G -----END PGP SIGNATURE----- --744n7ojxglqyswg3--