From: Minchan Kim <minchan.kim@gmail.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"kosaki.motohiro@jp.fujitsu.com" <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: error at compaction (Re: mmotm 2010-04-15-14-42 uploaded
Date: Tue, 20 Apr 2010 18:50:23 +0900 [thread overview]
Message-ID: <x2u28c262361004200250h2c38894i9adbd85d8fb7b1d8@mail.gmail.com> (raw)
In-Reply-To: <20100420084454.GD19264@csn.ul.ie>
On Tue, Apr 20, 2010 at 5:44 PM, Mel Gorman <mel@csn.ul.ie> wrote:
> On Tue, Apr 20, 2010 at 05:32:13PM +0900, Minchan Kim wrote:
>>
>> Yes. Then, Let's add comment like split_page. :)
>> /*
>> * Note: this is probably too low level an operation for use in drivers.
>> * Please consult with lkml before using this in your driver.
>> */
>>
>
> I can, but the comment that was there says it's like split_page except the
> page is already free. This also covers not using it in a driver.
I see. In addition, you already mentioned "As this is only being used
for migration".
I missed one.
I don't have any against one.
Will you repost v2 which move split_free_pages out of compaction.c?
Anyway, feel free to add my reviewed-by sign.
Thanks, Mel.
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
>
> --
> Mel Gorman
> Part-time Phd Student Linux Technology Center
> University of Limerick IBM Dublin Software Lab
>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-20 9:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201004152210.o3FMA7KV001909@imap1.linux-foundation.org>
2010-04-15 23:38 ` [PATCH -mmotm] vmstat: fix build errors when PROC_FS is disabled Randy Dunlap
2010-04-16 16:03 ` mmotm 2010-04-15-14-42 uploaded (shmem, CGROUP_MEM_RES_CTLR) Randy Dunlap
2010-04-19 1:49 ` Daisuke Nishimura
2010-04-19 2:17 ` Randy Dunlap
2010-04-19 10:01 ` error at compaction (Re: mmotm 2010-04-15-14-42 uploaded KAMEZAWA Hiroyuki
2010-04-19 18:14 ` Mel Gorman
2010-04-19 19:39 ` Mel Gorman
2010-04-20 2:30 ` KAMEZAWA Hiroyuki
2010-04-20 2:39 ` Minchan Kim
2010-04-20 3:07 ` KAMEZAWA Hiroyuki
2010-04-20 3:58 ` Minchan Kim
2010-04-20 4:24 ` KAMEZAWA Hiroyuki
2010-04-20 8:20 ` Mel Gorman
2010-04-20 8:32 ` Minchan Kim
2010-04-20 8:44 ` Mel Gorman
2010-04-20 9:50 ` Minchan Kim [this message]
2010-04-20 9:58 ` Mel Gorman
2010-04-20 10:14 ` Minchan Kim
2010-04-21 8:28 ` KAMEZAWA Hiroyuki
2010-04-21 9:48 ` KAMEZAWA Hiroyuki
2010-04-21 10:20 ` Mel Gorman
2010-04-21 16:52 ` Minchan Kim
2010-04-21 23:01 ` Minchan Kim
2010-04-20 2:35 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x2u28c262361004200250h2c38894i9adbd85d8fb7b1d8@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).