From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qc0-f173.google.com (mail-qc0-f173.google.com [209.85.216.173]) by kanga.kvack.org (Postfix) with ESMTP id 5479E6B00D8 for ; Thu, 6 Nov 2014 18:26:24 -0500 (EST) Received: by mail-qc0-f173.google.com with SMTP id x3so1713643qcv.32 for ; Thu, 06 Nov 2014 15:26:24 -0800 (PST) From: Jeff Moyer Subject: Re: [PATCH v5 2/7] vfs: Define new syscalls preadv2,pwritev2 References: Date: Thu, 06 Nov 2014 18:25:50 -0500 In-Reply-To: (Milosz Tanski's message of "Wed, 5 Nov 2014 16:14:48 -0500") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: Milosz Tanski Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, Mel Gorman , Volker Lendecke , Tejun Heo , Theodore Ts'o , Al Viro , linux-api@vger.kernel.org, Michael Kerrisk , linux-arch@vger.kernel.org, linux-mm@kvack.org Milosz Tanski writes: > New syscalls that take an flag argument. This change does not add any specific > flags. > > Signed-off-by: Milosz Tanski > Reviewed-by: Christoph Hellwig > --- > fs/read_write.c | 176 ++++++++++++++++++++++++++++++-------- > include/linux/compat.h | 6 ++ > include/linux/syscalls.h | 6 ++ > include/uapi/asm-generic/unistd.h | 6 +- > mm/filemap.c | 5 +- > 5 files changed, 158 insertions(+), 41 deletions(-) > > diff --git a/fs/read_write.c b/fs/read_write.c > index 94b2d34..907735c 100644 > --- a/fs/read_write.c > +++ b/fs/read_write.c > @@ -866,6 +866,8 @@ ssize_t vfs_readv(struct file *file, const struct iovec __user *vec, > return -EBADF; > if (!(file->f_mode & FMODE_CAN_READ)) > return -EINVAL; > + if (flags & ~0) > + return -EINVAL; > > return do_readv_writev(READ, file, vec, vlen, pos, flags); > } > @@ -879,21 +881,23 @@ ssize_t vfs_writev(struct file *file, const struct iovec __user *vec, > return -EBADF; > if (!(file->f_mode & FMODE_CAN_WRITE)) > return -EINVAL; > + if (flags & ~0) > + return -EINVAL; > > return do_readv_writev(WRITE, file, vec, vlen, pos, flags); > } Hi, Milosz, You've checked for invalid flags for the normal system calls, but not for the compat variants. Can you add that in, please? Thanks! Jeff -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org