From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B905C83F1A for ; Fri, 18 Jul 2025 09:52:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D3976B0093; Fri, 18 Jul 2025 05:52:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 283D76B0095; Fri, 18 Jul 2025 05:52:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19A0C6B0096; Fri, 18 Jul 2025 05:52:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 040BF6B0093 for ; Fri, 18 Jul 2025 05:52:10 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A1912C03AC for ; Fri, 18 Jul 2025 09:52:09 +0000 (UTC) X-FDA: 83676919578.08.521291C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 622CD40010 for ; Fri, 18 Jul 2025 09:52:07 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PfMAu2qu; spf=pass (imf01.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752832327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ux/hzx5C176HvRqmPS/Ipsjetu2RZl8NkYz5HyuD+7A=; b=N++AJk3r+LAcraSWjQ6mJJrsHvzL2yeGvEtxWwv+bRfrp8Rif4vt6n+PfAGXUJuKbiyzJd Yt8WWoseUiwngYF8u6ie+OcdV6rRi/+ndQa4NFOrln7wCQxTCrDpxAO1cj4awHOvh2VhDJ 8K59Gpy92c0QB/MD4g+Tsjbkyz2nNWM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752832327; a=rsa-sha256; cv=none; b=3PeVBGRcO1o75sKIsCHxdAKHOlU/TW2hUwRxdi1rUyd5ByuNTemIo97Dg4laKqC9dnCLRw BsOKDcQxAB177NBb/cE7sh23Cjc2J/1heAwYWQJAGrLEtizkom+I9/l8wl/rBVqGUheR7R CLYlGECdhCLEl/uAD7QXurinRfAsZgQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PfMAu2qu; spf=pass (imf01.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752832326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ux/hzx5C176HvRqmPS/Ipsjetu2RZl8NkYz5HyuD+7A=; b=PfMAu2qusihNSD8ApK22lLyhMlb0CpS0p1yH0QLIteWzoqFruki6FKzooGbQDLfSO1vIPN 9Zv3ljf2C7Emt98tg18DLN+ceo1Hp5lTNPyLqh2u8XslaoNcLJy1UqkI0iCRgP52hlRVW4 2kRUwgliUB0LBfb5GuODceZ5jIeqPaQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-7icnyx3AO6qCG-WkOUvtLA-1; Fri, 18 Jul 2025 05:52:05 -0400 X-MC-Unique: 7icnyx3AO6qCG-WkOUvtLA-1 X-Mimecast-MFC-AGG-ID: 7icnyx3AO6qCG-WkOUvtLA_1752832324 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45639e6a320so6525215e9.3 for ; Fri, 18 Jul 2025 02:52:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752832323; x=1753437123; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ux/hzx5C176HvRqmPS/Ipsjetu2RZl8NkYz5HyuD+7A=; b=MyVMcIUdcPX/ShGSQPlIkIopAO7IQM6lmSlGwGaRs4rKkcOqzbBhludit4wfM7O/7Z QFy8KpJ0NarUg9T+WpNXIFTtUoe07jLTG2Cnni90toz4+OG5wI+nFCMzYa1vGVnm25JH BeY/Jlfec/f1oYUvXwvtmZI0flgPZhe9nL+Le+T9RaLkUM4rUuWVgdfeeKOYkfcyus6P z5z0takGLV8S8botzN3Kzn96HODdFDfcoJNhExiCc2hSn3lPcqF96zEb3R/kVrBFKBbg smIrLb4ZCuTDa0RtKePVlBbP/d5Jm5aLPRfsTrYh8+9OGB42bn3+d3GR5/w4BiF1xT64 YnpA== X-Forwarded-Encrypted: i=1; AJvYcCVM+xTWzhWleIy0U62husuZkUnFueYRz0WBZxUoz9jBGIoiw6aKmo2mwgm8oed6TL0jG4b3Mn/s+g==@kvack.org X-Gm-Message-State: AOJu0Ywuti0b1XZebJKwzx2hkQCIQfud63kCpouDAg9ljfeoCc8DTXLr NUG+L/iEj4KfsXlaH7ECXBHaHYVeHbjdSkN3NkzmkoqG5qHC/bMgoaOMeN3SrH6qw9hLoQ6sYUA vamkxhw5IaYSRsUPopQbCB0h53P8UXbig5nx7zKgk027oTNRgMJnaoskabeudR1iiLtDr5Nxmuy 4NhkQjtmmMjKTDBmguhwd4IWWcS5sfE2dmzEiO X-Gm-Gg: ASbGncsp54qyijcvfV+iR4iUFXTfGIw8YK5TisbItsqfoRqGqz+MlV2mBVIVMxHFcIS u+PG3EetDBCkw9Y/eh8fhdDzqtVBQyTxBSnA18dQT7nb4r3UQXYomd1u8rZvRqeCUxifbdNFcns xrwxddKKKtdd0u3dhbqSf2mDt8HDbpgw3O7F/ODkdGv5XSjX64gWGTRZpNhc0RvVEsatBTcXDKx JWo3RMVYWCctcdB0ZPA9nuZibeldxFjpriw4SF61VBKTm2g645ZVIRg/qE0vNwky4naCMZOF1C0 VSo2e345/M4Aeu/oXrWIMT0RU5nMsZotar6969sMVLp2TtB3nNJ4yd1UDlPUaIwgoeDxClAVGRK qFNNcDmDZo01KZoZDQhng/d0S X-Received: by 2002:a05:6000:4028:b0:3a6:d967:380c with SMTP id ffacd0b85a97d-3b60e512866mr7457768f8f.36.1752832323568; Fri, 18 Jul 2025 02:52:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1SmrX8lGfL+0KhzfNKuD00GVP8Jo/phR2+TCQIYTwdF1q4Q4M8vr6EMgyQhgkZDbAylcJ7Q== X-Received: by 2002:a05:6000:4028:b0:3a6:d967:380c with SMTP id ffacd0b85a97d-3b60e512866mr7457737f8f.36.1752832323102; Fri, 18 Jul 2025 02:52:03 -0700 (PDT) Received: from vschneid-thinkpadt14sgen2i.remote.csb (213-44-135-146.abo.bbox.fr. [213.44.135.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca2bcc3sm1376864f8f.27.2025.07.18.02.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jul 2025 02:52:02 -0700 (PDT) From: Valentin Schneider To: Frederic Weisbecker , LKML Cc: Frederic Weisbecker , Andrew Morton , Ingo Molnar , Marcelo Tosatti , Michal Hocko , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Vlastimil Babka , linux-mm@kvack.org Subject: Re: [PATCH 5/6] sched/isolation: Introduce isolated task work In-Reply-To: <20250703140717.25703-6-frederic@kernel.org> References: <20250703140717.25703-1-frederic@kernel.org> <20250703140717.25703-6-frederic@kernel.org> Date: Fri, 18 Jul 2025 11:52:01 +0200 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tiMg0vJR4bg8XtcLut_5h4uA8MjFd-LqjeJNO58e5kQ_1752832324 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 622CD40010 X-Stat-Signature: 1888tt9p4p16z6uf1rw31nm5ik7oxfm7 X-Rspam-User: X-HE-Tag: 1752832327-728617 X-HE-Meta: U2FsdGVkX18kAFMDR00Z6ruaD0LEP5C0l01hRkIYv+xbgnK1me6EwDw2IRmsJ8XdzKSOkPoRZgTGghVYMPoSQjkljIw1kdnkcN/DfdenjImiactIXPIARTaLf/G6894Mm+ZtNDHCVn9HLl+cicUpul5cgrshpylo21BL7L4gjlNIR7+NyLN5GsBWHuDcT3U0MOAXVUUZAGIm4CnZ73Y5PBHWuDqAO1l0QJonIa5gNFUlr35rs8vwjceJvODxZYRVUTSz0uA4dVb9vuiGpCOg6xrxCOuGFUwRF9fTB7wHBYl986KLHn6wDmpIiyt/Ar3ic3Ym1R2WBk/Kr/ujp+u3SYDfR5zB7q+YBJGWbIqYL+J59RetmjaXr2njRSL5k0GlT9CsNNu4rYaoUCTDL0E63QrM7y3VTkY+8oHvYBkGqXZP1QQwkV9azRj6k81RUSd+TMvW+Ep5NRmTzdb9K9jfM/4euGhLsWcL6cotSSznTbbt3ljhzyes4Xpq8m/Jlh3ZrlINNm/YEkk+YtMUuitpTeBdhp2YaUZ+r/iaeEB/MBFOgc9aP+3NUo+ujl/s446ipMfKZDS5X5rg4tdGvnVj7CEEKL4W8h/qtrIPszeaSzdSh8rRvEcHHBFpC8nFDXpWuWjA/+3Ep2NBaesSdeSsgvECc5LWwcEExhHselhNaQNZcARTLuUMQQfFGe7ARRiU1aMFDWwGx0tF5OYxUDGhuoOeNxLkIu7nGHI6KZypV3if2WLM+Xr2cBN6KwZGvF4m+HN/nhd+bRDXv89DwaXdgnkXDQaAA50uW35stwPQffpJ1Fnb6JAZASJdi4B6lSO3aZDhM2USNMq+WA7kmlZ5xrerm7lQ/SmLblyHsljfHWH962BmageMoOVd1+3nR39CDbo7zGzfZy756TK9B1wjgUXoMVgI556RCjAboibyKjC5werZgjLMqqauk2uxlNuTvB39Cqwtx3ubyfgw/KF LeauSdeR l2SerLCnZIuyBrWYnfXuOsHCJTTAYgZeDzUhZYRngVhpLUw3QBXNzG21pDBhGixsCcRjcZdD6UufDxIRrf0RmLcTau9wAlncP06S4rR5lZ+F6jzi9mzX+cuyjdMtoFys5bpeVDjz5nkUfl1U/A6nBYcgwTDZDe4VTzfD9nhr6pdrB1xu6d1nCj8BFgDUTWAGKkbe6Sl9qmR9npQmGqNyFsVEK+kkxxoP3geVAYj8H78SVvVmb3859yyw0REhHafXQ7JDG53obEHIYbtuJ2Jjw58WUrtw9U8e1B6DNtNowGjJSoHsyf07R4njL5v5bSc6J5ZAAG4WQvzKkAntGsMILTjXGwOyUwfR6wYM5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/07/25 16:07, Frederic Weisbecker wrote: > @@ -77,4 +77,21 @@ static inline bool cpu_is_isolated(int cpu) > cpuset_cpu_is_isolated(cpu); > } > > +#if defined(CONFIG_NO_HZ_FULL_WORK) > +extern int __isolated_task_work_queue(void); > + > +static inline int isolated_task_work_queue(void) > +{ > + if (!housekeeping_cpu(raw_smp_processor_id(), HK_TYPE_KERNEL_NOISE)) > + return -ENOTSUPP; > + Am I being dense or this condition the opposite of what we want? That is, AIUI we want isolated_task_work() to run on NOHZ_FULL/isolated CPUs' resume-to-userspace path, so this should bail if the current CPU *is* a housekeeping CPU. > + return __isolated_task_work_queue(); > +} > +