linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vasily Gorbik <gor@linux.ibm.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org,
	linux-mm@kvack.org, liam.howlett@oracle.com,
	richard.weiyang@gmail.com
Subject: Re: [PATCH v3 5/6] maple_tree: add sufficient height
Date: Tue, 11 Mar 2025 16:53:08 +0100	[thread overview]
Message-ID: <your-ad-here.call-01741708388-ext-3173@work.hours> (raw)
In-Reply-To: <04bd1284-ff3b-4b3d-899d-9a1e3705df28@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 816 bytes --]

On Tue, Mar 11, 2025 at 10:40:17AM -0400, Sidhartha Kumar wrote:
> Would you be able to rerun this test with the following diff applied and
> CONFIG_DEBUG_MAPLE_TREE=y so I can check the state of the tree to easier
> reproduce the error?
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index ea1f0acac118..74a4b1924a55 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -1153,8 +1153,11 @@ static inline struct maple_node *mas_pop_node(struct
> ma_state *mas)
>         unsigned int req = mas_alloc_req(mas);
> 
>         /* nothing or a request pending. */
> -       if (WARN_ON(!total))
> +       if (WARN_ON(!total)) {
> +               mas_dump(mas);
> +               mt_dump(mas->tree, mt_dump_hex);
>                 return NULL;
> +       }

Sure, please find vmcore-dmesg.txt.xz attached

[-- Attachment #2: vmcore-dmesg.txt.xz --]
[-- Type: application/x-xz, Size: 508568 bytes --]

  reply	other threads:[~2025-03-11 15:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 20:48 [PATCH v3 0/6] Track node vacancy to reduce worst case allocation counts Sidhartha Kumar
2025-02-27 20:48 ` [PATCH v3 1/6] maple_tree: convert mas_prealloc_calc() to take in a maple write state Sidhartha Kumar
2025-02-27 20:48 ` [PATCH v3 2/6] maple_tree: use height and depth consistently Sidhartha Kumar
2025-02-27 20:48 ` [PATCH v3 3/6] maple_tree: use vacant nodes to reduce worst case allocations Sidhartha Kumar
2025-02-27 20:48 ` [PATCH v3 4/6] maple_tree: break on convergence in mas_spanning_rebalance() Sidhartha Kumar
2025-02-27 20:48 ` [PATCH v3 5/6] maple_tree: add sufficient height Sidhartha Kumar
2025-03-10 18:13   ` Vasily Gorbik
2025-03-10 21:01     ` Sidhartha Kumar
2025-03-10 22:27       ` Andrew Morton
2025-03-11 14:40     ` Sidhartha Kumar
2025-03-11 15:53       ` Vasily Gorbik [this message]
2025-02-27 20:48 ` [PATCH v3 6/6] maple_tree: reorder mas->store_type case statements Sidhartha Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=your-ad-here.call-01741708388-ext-3173@work.hours \
    --to=gor@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=liam.howlett@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=richard.weiyang@gmail.com \
    --cc=sidhartha.kumar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).