From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Daniel Axtens <dja@axtens.net>, kbuild test robot <lkp@intel.com>,
kbuild-all@lists.01.org, Johannes Weiner <hannes@cmpxchg.org>,
Dmitry Vyukov <dvyukov@google.com>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-scsi@vger.kernel.org
Subject: Re: [hnaz-linux-mm:master 156/523] include/linux/string.h:307:9: note: in expansion of macro '__underlying_strncpy'
Date: Tue, 19 May 2020 22:08:53 -0400 [thread overview]
Message-ID: <yq17dx7wej4.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20200519184847.5affb9238b7358ac0d18c98e@linux-foundation.org> (Andrew Morton's message of "Tue, 19 May 2020 18:48:47 -0700")
Andrew,
> /* Vendor Identification */
>>>> strncpy(&inqdata[16], "RAID controller ", 16);
> That strncpy() will indeed fail to copy the trailing null, but it looks
> like that null isn't appropriate in the inquiry data.
Correct. These protocol strings are fixed-length / space-padded.
I.e. not null-terminated.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-05-20 2:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 9:23 [hnaz-linux-mm:master 156/523] include/linux/string.h:307:9: note: in expansion of macro '__underlying_strncpy' kbuild test robot
2020-05-19 14:42 ` Daniel Axtens
2020-05-20 1:48 ` Andrew Morton
2020-05-20 2:08 ` Martin K. Petersen [this message]
2020-05-20 3:57 ` Daniel Axtens
2020-05-19 14:42 ` Daniel Axtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17dx7wej4.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dja@axtens.net \
--cc=dvyukov@google.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox