From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34627CA101E for ; Tue, 3 Sep 2024 06:27:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B06708D013F; Tue, 3 Sep 2024 02:27:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A911B8D0139; Tue, 3 Sep 2024 02:27:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E2E68D013F; Tue, 3 Sep 2024 02:27:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6D5808D0139 for ; Tue, 3 Sep 2024 02:27:40 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1D258808FF for ; Tue, 3 Sep 2024 06:27:40 +0000 (UTC) X-FDA: 82522445880.13.CC1A89D Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf22.hostedemail.com (Postfix) with ESMTP id 5838DC0012 for ; Tue, 3 Sep 2024 06:27:37 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=rzESbfHi; spf=pass (imf22.hostedemail.com: domain of svens@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=svens@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725344783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VgrxN144iUPf7NqeoMOyzsSN98GEfqKoLsawzlynxPg=; b=YytGLMYHWiKtEAnr8jRDi2VSRvgVPzx5+4YyUkpggx1PhyEAUgt3F8ccaYZlEo92wjiHL3 lHrr1a8On6KfTazelWXMkZFZoSiwErhMgloO5i/M4Ys5vOx4P68DlrhCuI/m+27+ci1h2N oWdJnV6AUWsYKX/WBhg8vRODCu9SIKw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=rzESbfHi; spf=pass (imf22.hostedemail.com: domain of svens@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=svens@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725344783; a=rsa-sha256; cv=none; b=asPEGbheIWMQeyhvE0ATkMLTNG2AS5oC0sP7eGddxtj8LuQD9V1eyv2QVwdpEgsD4Plh1G srgZaH5onfdXxSJy5ZgtKqgseLOSBP0WVJkIliMy3r+UFZG/VVc2U/fF5dXMGKtspz1gAH bf9p67+FFZPm96uTKdV+obSDSIQ/eIM= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 482MmnT9025891; Tue, 3 Sep 2024 06:27:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=pp1; bh=VgrxN144iUPf7NqeoMOyzsSN98 GEfqKoLsawzlynxPg=; b=rzESbfHimjo981rF1eOvgpMSjsCQ2UXY78JmMhDEPZ DPh07gQoAfNtgrqCnJFv+HngQ73My+guTlInZU4UAvE+Dm9dcfsYpQEIqRqoVG6I obVtiqyrCd8ZtLNynhBiS1xKvLMAi/spun5PMu9Eab4stcoNMpzU0EqMEfHF9k64 +Lwt5vXL3GQWmcwF7+U+6eOVKzqSx/n6WbnE3sku4HNati9Ia2vVLoEPV1PxeuvG 3fui9eN9a0KkNJJxBS5E1cd0jLPmZSXe5AuC2X3sdunUJeNgYrgy4e73/Bna0Inl PYj52ozWBoOg+tVNxtsqs4KH9vbGLWVO9WCW8G0uWdcA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41brkqmhru-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Sep 2024 06:27:23 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4836RNUi007387; Tue, 3 Sep 2024 06:27:23 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41brkqmhrr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Sep 2024 06:27:23 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4832HPjd012052; Tue, 3 Sep 2024 06:27:22 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 41cegpse6m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Sep 2024 06:27:22 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4836RKVJ14483918 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 3 Sep 2024 06:27:20 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1289B2004D; Tue, 3 Sep 2024 06:27:20 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9BD9820040; Tue, 3 Sep 2024 06:27:19 +0000 (GMT) Received: from tuxmaker.linux.ibm.com (unknown [9.152.85.9]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 3 Sep 2024 06:27:19 +0000 (GMT) From: Sven Schnelle To: Linus Torvalds Cc: Andrew Morton , Nathan Chancellor , Michael Ellerman , linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, christophe.leroy@csgroup.eu, jeffxu@google.com, Liam.Howlett@oracle.com, linux-kernel@vger.kernel.org, npiggin@gmail.com, oliver.sang@intel.com, pedro.falcato@gmail.com, linux-um@lists.infradead.org, linux-s390@vger.kernel.org, Ravi Bangoria , Steven Rostedt Subject: Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping In-Reply-To: (Linus Torvalds's message of "Mon, 2 Sep 2024 14:02:56 -0700") References: <20240812082605.743814-1-mpe@ellerman.id.au> <20240819185253.GA2333884@thelio-3990X> <20240902134953.e834bc2e57d36b1d3b1397e4@linux-foundation.org> Date: Tue, 03 Sep 2024 08:27:19 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 9aSqu6fFfWss73YgKp0gBlzFQVIXapXn X-Proofpoint-ORIG-GUID: OxhEA4e_rV3dfcm0C7DWi8uVqyGWdHzl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-02_06,2024-09-02_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1011 mlxscore=0 impostorscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 adultscore=0 mlxlogscore=970 bulkscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2409030046 X-Stat-Signature: whgymizf7nyckz5zd4az8ogtfm4h94iy X-Rspam-User: X-Rspamd-Queue-Id: 5838DC0012 X-Rspamd-Server: rspam02 X-HE-Tag: 1725344857-386063 X-HE-Meta: U2FsdGVkX1/ivdIKYptqVgIbIV0bvxbYAnSuZXyxsXTNwkgO5KGvUCy4Dskhj4ARdzOOh8tx5KyEmWEnAEbp3+z+uEvKqzq+RF/hDhergN7Tq8zXKuGCLe31m7MzmfBAnYLc/hQGblisLhjxsoix8LpfiwrZFlqDS6o34JjiImhhQM8uIkAtWqWaKvP+fHafvIwafh1Mpv2Ik/AMF5ezeE1t+qZ/67+iHWRhp+bR3q0jQcXrm9Jn18uAoSGKYZxKHhLmZBXy9dwd5aKvK9lauA8Um9gqqby2J8GBQO7Mhfxt0xPmmfYd8zuJbmqOwU1lp++p5Zu6Hs+rbYvBUv02s6059PVeaZyaHkLeSVAo+Hbj+Mau+EUyaowTYik4A+czIMz57sqbu1Uiqwxl/XWkWbR9W0+ks7RKNPIcnLrjU116dGcsVomhpmMzdULCQammUJtn7ATZ8qPjXZr/6X9dLZv6nw+asZ4GWfT0oC5Vjv90ZxrLdvVf2j3MNv6ogu5FecDvKvG6uwsApzz+EV/P8Vii2t+s4prUin+ZIy+h8J6eyarZviNnGTDWXaUbrnv2Qs71bTROJd/wXsGHD1a9Dn8eraxKl3FU+vXQZDEnnnJqzAPaPje9ptqpo7N5FN4Mb6CygQpehBuM/jMlg1kFfCpoTIeO8xeXXsEGqznXmWBXdh97bREyQMohlg/l0gGR50R65ZvUfUjQmVNESl+yaZ3phGvdI+VBCn3LXXQKvaeW//B6JkvfVNULRCpg3XaPhG5uDktRbX/JArB8KGSQJeSdXxBeng7McTkyN0d3c3nUQkfOEgyDWfVMnxk6xLcdzMeSqK929hxOKvvbhXAenRLhiXlXB/U6YteHtUttA42gRjKYMaD0MTISERiv8ESYLujFKNGPsXXWshNkmvTkBBKhqH9fzGpixkAaoJyusG4SlGKn2ntXTdi93V/P0iNcCrjRe8VEpmf0FRp2DsU /6FBoKFc 0Sr43hnX1jonG/w7P2YEjqmizYgwxV123MNwMpL+tSJRmE4PN9Q74NvpShIqjlEffD8mksDDcDWbJkZrcv+H8Zi6yjF3TZ6amNgBUgPOPUg1EdXGQ/yJ4rqnR2f5KwGIx/0Qlj+DuvTpGv8xxlYXyHMA/obHhBqzCrZgqRhPvAjeF3e3eXIwR9hJUZTEoWnBPpiS4lzDdw6m+wgyP3MuNpZ4GNqmEbhUKXiDZxs8i2q6JbbTqqvYHKShU+nc6PrEmJtlT+Efc5V3fGcuU+jEPA7A60CIjfbmgvBixhW2C9BHEWq9s4oRhqjnywiYlIBqTBc// X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Linus Torvalds writes: > On Mon, 2 Sept 2024 at 13:49, Andrew Morton wrote: >> >> uprobe_clear_state() is a pretty simple low-level thing. Side-effects >> seem unlikely? > > I think uprobe_clear_state() should be removed from fork.c entirely, > made 'static', and then we'd have > > area->xol_mapping.close = uprobe_clear_state; > > in __create_xol_area() instead (ok, the arguments change, instead of > looking up "mm->uprobes_state.xol_area", it would get it as the vma > argument) > > That's how it should always have been, except we didn't have a close() function. > > Hmm? Indeed, that's much better. I'll prepare a patch. Thanks!