From: Minchan Kim <minchan.kim@gmail.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
cl@linux-foundation.org, lee.schermerhorn@hp.com,
rientjes@google.com, Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Rik van Riel <riel@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Troels Liebe Bentsen <tlb@rapanden.dk>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] exit: fix oops in sync_mm_rss
Date: Wed, 31 Mar 2010 11:48:20 +0900 [thread overview]
Message-ID: <z2z28c262361003301948h64378b8bkbbd29ed810862ce5@mail.gmail.com> (raw)
In-Reply-To: <20100331111202.a94b233a.kamezawa.hiroyu@jp.fujitsu.com>
On Wed, Mar 31, 2010 at 11:12 AM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Wed, 31 Mar 2010 10:57:18 +0900
> Minchan Kim <minchan.kim@gmail.com> wrote:
>
>> On Wed, Mar 31, 2010 at 9:41 AM, KAMEZAWA Hiroyuki
>
>> > Doesn't make sense ?
>> >
>>
>> Nitpick.
>> How about moving sync_mm_rss into after check !mm of exit_mm?
>>
> Hmm.
> ==
> sync_mm_rss(tsk, tsk->mm);
> group_dead = atomic_dec_and_test(&tsk->signal->live);
> if (group_dead) {
> hrtimer_cancel(&tsk->signal->real_timer);
> exit_itimers(tsk->signal);
> if (tsk->mm)
> setmax_mm_hiwater_rss(&tsk->signal->maxrss, tsk->mm); ---(**)
> }
> acct_collect(code, group_dead);
> if (group_dead)
> tty_audit_exit();
> if (unlikely(tsk->audit_context))
> audit_free(tsk);
>
> tsk->exit_code = code;
> taskstats_exit(tsk, group_dead); --------(*)
>
> exit_mm(tsk);
> ==
> task_acct routine has to handle mm information (*).
Indeed. I missed that.
Thanks, Kame.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-03-31 2:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 17:08 [PATCH] exit: fix oops in sync_mm_rss Michael S. Tsirkin
2010-03-16 17:51 ` Andrea Arcangeli
2010-03-16 17:52 ` Rik van Riel
2010-03-16 23:41 ` KAMEZAWA Hiroyuki
2010-03-17 2:26 ` Minchan Kim
2010-03-30 20:56 ` Andrew Morton
2010-03-31 0:28 ` KAMEZAWA Hiroyuki
2010-03-30 21:37 ` Andrew Morton
2010-03-31 0:41 ` KAMEZAWA Hiroyuki
2010-03-30 22:22 ` Andrew Morton
2010-03-31 1:27 ` KAMEZAWA Hiroyuki
2010-03-31 2:53 ` Minchan Kim
2010-03-31 0:03 ` Andrew Morton
2010-03-31 3:11 ` KAMEZAWA Hiroyuki
2010-03-31 1:57 ` Minchan Kim
2010-03-31 2:12 ` KAMEZAWA Hiroyuki
2010-03-31 2:48 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=z2z28c262361003301948h64378b8bkbbd29ed810862ce5@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hugh.dickins@tiscali.co.uk \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tlb@rapanden.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).