RE: [PATCH 01/12] mmc: sdhci: add support for SD Host Controller 3.0

Nath, Arindam
2011-02-18T17:17:54Z

Hi Philip,

> -----Original Message-----
> From: Philip Rakity [mailto:prakity@marvell.com]
> Sent: Friday, February 18, 2011 9:19 PM
> To: Nath, Arindam
> Cc: Zhangfei Gao; Chris Ball; linux-mmc@vger.kernel.org; Su, Henry; Lu,
> Aaron; anath.amd@gmail.com; Nicolas Pitre
> Subject: [PATCH 01/12] mmc: sdhci: add support for SD Host Controller
> 3.0
>
>
> Arindam,
>
> Could you look at making (Tuning) CMD19 part of the sdhc.ci driver?
> It flow is part of the Host Controller and Physical layer specs.

There are two main reasons for exposing the callback of tuning procedure from sdhci.c:

1. The tuning procedure is part of UHS-I initialization sequence as described in Physical Layer Spec v3.01. Since the UHS-I init sequence takes places inside sd.c, so I thought it better to place it there instead.
2. In future, if we need to add support for UHS-I sequence for sdio cards too, we can use the same callback from sdhci.c without any modifications.

I am open to suggestions.

Regards,
Arindam