From: "Subhash Jadavani" <subhashj@codeaurora.org>
To: 'Balaji T K' <balajitk@ti.com>, linux-mmc@vger.kernel.org
Subject: RE: [RFC/RFT] MMC: CORE: eMMC in Sleep mode before suspend
Date: Thu, 14 Jul 2011 19:35:17 +0530 [thread overview]
Message-ID: <000001cc422f$120d2810$36277830$@org> (raw)
In-Reply-To: <1310567787-14697-1-git-send-email-balajitk@ti.com>
Balaji,
Tried this patch along with disabling the eMMC VCC supply in suspend and it
works !!! Without this patch, if I disabled the VCC supply then after resume
I/O errors are seen. This change also complies with eMMC spec so am ok with
this change.
Regards,
Subhash
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
> -----Original Message-----
> From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-
> owner@vger.kernel.org] On Behalf Of Balaji T K
> Sent: Wednesday, July 13, 2011 8:06 PM
> To: linux-mmc@vger.kernel.org
> Cc: Balaji T K
> Subject: [RFC/RFT] MMC: CORE: eMMC in Sleep mode before suspend
>
> Put MMC to sleep if it supports SLEEP/AWAKE (CMD5)
> in the mmc suspend to minimize power consumption.
>
> Signed-off-by: Balaji T K <balajitk@ti.com>
> ---
> drivers/mmc/core/mmc.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index afabdc3..e8dfcde 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -900,16 +900,20 @@ static void mmc_detect(struct mmc_host *host)
> */
> static int mmc_suspend(struct mmc_host *host)
> {
> + int err = 0;
> +
> BUG_ON(!host);
> BUG_ON(!host->card);
>
> mmc_claim_host(host);
> - if (!mmc_host_is_spi(host))
> + if (mmc_card_can_sleep(host))
> + err = mmc_card_sleep(host);
> + else if (!mmc_host_is_spi(host))
> mmc_deselect_cards(host);
> host->card->state &= ~MMC_STATE_HIGHSPEED;
> mmc_release_host(host);
>
> - return 0;
> + return err;
> }
>
> /*
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-14 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 14:36 [RFC/RFT] MMC: CORE: eMMC in Sleep mode before suspend Balaji T K
2011-07-14 14:05 ` Subhash Jadavani [this message]
2011-07-19 16:01 ` S, Venkatraman
2011-07-19 16:48 ` Chris Ball
2011-07-21 20:12 ` Adrian Hunter
2011-09-08 16:01 ` T Krishnamoorthy, Balaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cc422f$120d2810$36277830$@org' \
--to=subhashj@codeaurora.org \
--cc=balajitk@ti.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox