From: Seungwon Jeon <tgih.jun@samsung.com>
To: 'Jaehoon Chung' <jh80.chung@samsung.com>,
'linux-mmc' <linux-mmc@vger.kernel.org>
Cc: 'Chris Ball' <cjb@laptop.org>,
'Kyungmin Park' <kyungmin.park@samsung.com>,
'Will Newton' <will.newton@imgtec.com>,
'James Hogan' <james.hogan@imgtec.com>
Subject: RE: dw_mmc: fixed compile error when disable CONFIG_MMC_DW_IDMAC
Date: Thu, 16 Feb 2012 12:40:17 +0900 [thread overview]
Message-ID: <000001ccec5c$b34a5040$19def0c0$%jun@samsung.com> (raw)
In-Reply-To: <4F3C67BA.7040309@samsung.com>
Jaehoon Chung <jh80.chung@samsung.com> wrote:
> When disable CONFIG_MMC_DW_IDMAC, can see the compiler error.
> Because in dw_mci_post_req(), called the dw_mci_get_dma_dir().
> But that function is in #ifdef CONFIG_MMC_DW_IDMAC.
>
> I think that function is generic function.
> Not need the CONFIG_MMC_DW_IDMAC.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
I tested it. Looks ok to me.
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
next prev parent reply other threads:[~2012-02-16 3:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 2:19 mmc: dw_mmc: fixed compile error when disable CONFIG_MMC_DW_IDMAC Jaehoon Chung
2012-02-16 3:40 ` Seungwon Jeon [this message]
2012-02-16 23:22 ` James Hogan
2012-02-17 1:17 ` Seungwon Jeon
2012-02-20 12:10 ` James Hogan
2012-02-20 17:04 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001ccec5c$b34a5040$19def0c0$%jun@samsung.com' \
--to=tgih.jun@samsung.com \
--cc=cjb@laptop.org \
--cc=james.hogan@imgtec.com \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).