From: "Subhash Jadavani" <subhashj@codeaurora.org>
To: 'Seungwon Jeon' <tgih.jun@samsung.com>
Cc: linux-mmc@vger.kernel.org, 'Chris Ball' <cjb@laptop.org>,
'Girish K S' <girish.shivananjappa@linaro.org>
Subject: RE: [PATCH 1/2] mmc: core: fix the decision of mmc card-type
Date: Wed, 25 Apr 2012 11:40:31 +0530 [thread overview]
Message-ID: <000001cd22aa$222e3250$668a96f0$@codeaurora.org> (raw)
In-Reply-To: <003e01cd22a2$47e9bf80$d7bd3e80$%jun@samsung.com>
> > > + if (caps& MMC_CAP_MMC_HIGHSPEED&&
> > > + card_type& EXT_CSD_CARD_TYPE_52)
> > Just from code readability point of view, can we add parenthesis for
> > each conditions within if?
> > if ( (xxx) && (xxx))
> Right but '&' is higher than '&&' in priority, so how about keeping on?
Ok.
Regards,
Subhash
prev parent reply other threads:[~2012-04-25 6:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 9:11 [PATCH 1/2] mmc: core: fix the decision of mmc card-type Seungwon Jeon
2012-04-24 8:02 ` Subhash Jadavani
2012-04-25 5:14 ` Seungwon Jeon
2012-04-25 6:10 ` Subhash Jadavani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cd22aa$222e3250$668a96f0$@codeaurora.org' \
--to=subhashj@codeaurora.org \
--cc=cjb@laptop.org \
--cc=girish.shivananjappa@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).