* [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR
@ 2013-08-08 10:44 Andy Shevchenko
2013-08-08 10:44 ` [PATCH 2/2] dw_mmc-pci: enable bus-mastering mode Andy Shevchenko
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Andy Shevchenko @ 2013-08-08 10:44 UTC (permalink / raw)
To: linux-mmc, Chris Ball, Prabu Thangamuthu, Seungwon Jeon; +Cc: Andy Shevchenko
There is a typo when the mapped space is from BAR 2, but BAR 0 is used instead.
This patch fixes the typo.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mmc/host/dw_mmc-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-pci.c
index b456b0c..7d148d6 100644
--- a/drivers/mmc/host/dw_mmc-pci.c
+++ b/drivers/mmc/host/dw_mmc-pci.c
@@ -59,7 +59,7 @@ static int dw_mci_pci_probe(struct pci_dev *pdev,
if (ret)
return ret;
- host->regs = pcim_iomap_table(pdev)[0];
+ host->regs = pcim_iomap_table(pdev)[PCI_BAR_NO];
ret = dw_mci_probe(host);
if (ret)
--
1.8.4.rc1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/2] dw_mmc-pci: enable bus-mastering mode
2013-08-08 10:44 [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR Andy Shevchenko
@ 2013-08-08 10:44 ` Andy Shevchenko
2013-08-12 7:34 ` Prabu Thangamuthu
2013-08-12 7:34 ` [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR Prabu Thangamuthu
2013-08-25 4:02 ` Chris Ball
2 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2013-08-08 10:44 UTC (permalink / raw)
To: linux-mmc, Chris Ball, Prabu Thangamuthu, Seungwon Jeon; +Cc: Andy Shevchenko
This patch enables bus-mastering mode for MMC controller to allow IDMAC
transfers.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mmc/host/dw_mmc-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-pci.c
index 7d148d6..f70546a 100644
--- a/drivers/mmc/host/dw_mmc-pci.c
+++ b/drivers/mmc/host/dw_mmc-pci.c
@@ -61,6 +61,8 @@ static int dw_mci_pci_probe(struct pci_dev *pdev,
host->regs = pcim_iomap_table(pdev)[PCI_BAR_NO];
+ pci_set_master(pdev);
+
ret = dw_mci_probe(host);
if (ret)
return ret;
--
1.8.4.rc1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH 2/2] dw_mmc-pci: enable bus-mastering mode
2013-08-08 10:44 ` [PATCH 2/2] dw_mmc-pci: enable bus-mastering mode Andy Shevchenko
@ 2013-08-12 7:34 ` Prabu Thangamuthu
2013-08-12 10:33 ` Seungwon Jeon
0 siblings, 1 reply; 7+ messages in thread
From: Prabu Thangamuthu @ 2013-08-12 7:34 UTC (permalink / raw)
To: Andy Shevchenko, linux-mmc@vger.kernel.org, Chris Ball,
Prabu Thangamuthu, Seungwon Jeon
Tested-by: Prabu Thangamuthu <Prabu.T@synopsys.com>
Regards,
Prabu Thangamuthu.
On 08/12/2013 04:15 PM, Andy Shevchenko wrote:
> This patch enables bus-mastering mode for MMC controller to allow IDMAC
> transfers.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mmc/host/dw_mmc-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-
> pci.c index 7d148d6..f70546a 100644
> --- a/drivers/mmc/host/dw_mmc-pci.c
> +++ b/drivers/mmc/host/dw_mmc-pci.c
> @@ -61,6 +61,8 @@ static int dw_mci_pci_probe(struct pci_dev *pdev,
>
> host->regs = pcim_iomap_table(pdev)[PCI_BAR_NO];
>
> + pci_set_master(pdev);
> +
> ret = dw_mci_probe(host);
> if (ret)
> return ret;
> --
> 1.8.4.rc1
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 2/2] dw_mmc-pci: enable bus-mastering mode
2013-08-12 7:34 ` Prabu Thangamuthu
@ 2013-08-12 10:33 ` Seungwon Jeon
0 siblings, 0 replies; 7+ messages in thread
From: Seungwon Jeon @ 2013-08-12 10:33 UTC (permalink / raw)
To: 'Prabu Thangamuthu', 'Andy Shevchenko', linux-mmc,
'Chris Ball'
On Monday, August 12, 2013, Prabu Thangamuthu wrote:
>
> Tested-by: Prabu Thangamuthu <Prabu.T@synopsys.com>
>
> Regards,
> Prabu Thangamuthu.
>
> On 08/12/2013 04:15 PM, Andy Shevchenko wrote:
> > This patch enables bus-mastering mode for MMC controller to allow IDMAC
> > transfers.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR
2013-08-08 10:44 [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR Andy Shevchenko
2013-08-08 10:44 ` [PATCH 2/2] dw_mmc-pci: enable bus-mastering mode Andy Shevchenko
@ 2013-08-12 7:34 ` Prabu Thangamuthu
2013-08-12 10:33 ` Seungwon Jeon
2013-08-25 4:02 ` Chris Ball
2 siblings, 1 reply; 7+ messages in thread
From: Prabu Thangamuthu @ 2013-08-12 7:34 UTC (permalink / raw)
To: Andy Shevchenko, linux-mmc@vger.kernel.org, Chris Ball,
Prabu Thangamuthu, Seungwon Jeon
Tested-by: Prabu Thangamuthu <Prabu.T@synopsys.com>
Regards,
Prabu Thangamuthu.
On 08/12/2013 04:15 PM, Andy Shevchenko wrote:
> There is a typo when the mapped space is from BAR 2, but BAR 0 is used
> instead.
> This patch fixes the typo.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mmc/host/dw_mmc-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-
> pci.c index b456b0c..7d148d6 100644
> --- a/drivers/mmc/host/dw_mmc-pci.c
> +++ b/drivers/mmc/host/dw_mmc-pci.c
> @@ -59,7 +59,7 @@ static int dw_mci_pci_probe(struct pci_dev *pdev,
> if (ret)
> return ret;
>
> - host->regs = pcim_iomap_table(pdev)[0];
> + host->regs = pcim_iomap_table(pdev)[PCI_BAR_NO];
>
> ret = dw_mci_probe(host);
> if (ret)
> --
> 1.8.4.rc1
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR
2013-08-12 7:34 ` [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR Prabu Thangamuthu
@ 2013-08-12 10:33 ` Seungwon Jeon
0 siblings, 0 replies; 7+ messages in thread
From: Seungwon Jeon @ 2013-08-12 10:33 UTC (permalink / raw)
To: 'Prabu Thangamuthu', 'Andy Shevchenko', linux-mmc,
'Chris Ball'
On Monday, August 12, 2013, Prabu Thangamuthu wrote:
>
> Tested-by: Prabu Thangamuthu <Prabu.T@synopsys.com>
>
> Regards,
> Prabu Thangamuthu.
>
> On 08/12/2013 04:15 PM, Andy Shevchenko wrote:
> > There is a typo when the mapped space is from BAR 2, but BAR 0 is used
> > instead.
> > This patch fixes the typo.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR
2013-08-08 10:44 [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR Andy Shevchenko
2013-08-08 10:44 ` [PATCH 2/2] dw_mmc-pci: enable bus-mastering mode Andy Shevchenko
2013-08-12 7:34 ` [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR Prabu Thangamuthu
@ 2013-08-25 4:02 ` Chris Ball
2 siblings, 0 replies; 7+ messages in thread
From: Chris Ball @ 2013-08-25 4:02 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-mmc, Prabu Thangamuthu, Seungwon Jeon
Hi Andy,
On Thu, Aug 08 2013, Andy Shevchenko wrote:
> There is a typo when the mapped space is from BAR 2, but BAR 0 is used instead.
> This patch fixes the typo.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mmc/host/dw_mmc-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-pci.c
> index b456b0c..7d148d6 100644
> --- a/drivers/mmc/host/dw_mmc-pci.c
> +++ b/drivers/mmc/host/dw_mmc-pci.c
> @@ -59,7 +59,7 @@ static int dw_mci_pci_probe(struct pci_dev *pdev,
> if (ret)
> return ret;
>
> - host->regs = pcim_iomap_table(pdev)[0];
> + host->regs = pcim_iomap_table(pdev)[PCI_BAR_NO];
>
> ret = dw_mci_probe(host);
> if (ret)
Thanks, pushed to mmc-next for 3.12.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-08-25 4:02 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-08 10:44 [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR Andy Shevchenko
2013-08-08 10:44 ` [PATCH 2/2] dw_mmc-pci: enable bus-mastering mode Andy Shevchenko
2013-08-12 7:34 ` Prabu Thangamuthu
2013-08-12 10:33 ` Seungwon Jeon
2013-08-12 7:34 ` [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR Prabu Thangamuthu
2013-08-12 10:33 ` Seungwon Jeon
2013-08-25 4:02 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox