From: Seungwon Jeon <tgih.jun@samsung.com>
To: 'Jaehoon Chung' <jh80.chung@samsung.com>,
'linux-mmc' <linux-mmc@vger.kernel.org>
Cc: 'Chris Ball' <cjb@laptop.org>,
'Kyungmin Park' <kyungmin.park@samsung.com>
Subject: RE: [PATCH] mmc: sdhci-s3c: remove unnecessary/dupulicated code
Date: Mon, 05 Dec 2011 13:05:09 +0900 [thread overview]
Message-ID: <000b01ccb303$148e84e0$3dab8ea0$%jun@samsung.com> (raw)
In-Reply-To: <4EDC0D14.5080204@samsung.com>
Hi Jaehoon,
> This patch is just removed the unnecessary code.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/host/sdhci-s3c.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index b6558b8..ad0ef39 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -334,11 +334,9 @@ static void sdhci_s3c_notify_change(struct platform_device *dev, int state)
> spin_lock_irqsave(&host->lock, flags);
> if (state) {
> dev_dbg(&dev->dev, "card inserted.\n");
> - host->flags &= ~SDHCI_DEVICE_DEAD;
> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
> } else {
> dev_dbg(&dev->dev, "card removed.\n");
> - host->flags |= SDHCI_DEVICE_DEAD;
> host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION;
> }
Could you explain the reason of these remove?
SDHCI_DEVICE_DEAD flag is needed for external card detection
and is used in "sdhci.c".
Best regards,
Seungwon Jeon.
> tasklet_schedule(&host->card_tasklet);
> @@ -521,6 +519,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
> if (pdata->cd_type == S3C_SDHCI_CD_PERMANENT)
> host->mmc->caps = MMC_CAP_NONREMOVABLE;
>
> + /* It supports additional host capabilities if needed */
> if (pdata->host_caps)
> host->mmc->caps |= pdata->host_caps;
>
> @@ -543,10 +542,6 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
> sdhci_s3c_ops.get_max_clock = sdhci_cmu_get_max_clock;
> }
>
> - /* It supports additional host capabilities if needed */
> - if (pdata->host_caps)
> - host->mmc->caps |= pdata->host_caps;
> -
> ret = sdhci_add_host(host);
> if (ret) {
> dev_err(dev, "sdhci_add_host() failed\n");
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-12-05 4:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 0:15 [PATCH] mmc: sdhci-s3c: remove unnecessary/dupulicated code Jaehoon Chung
2011-12-05 4:05 ` Seungwon Jeon [this message]
2011-12-05 4:18 ` Jaehoon Chung
2011-12-05 4:29 ` Jaehoon Chung
2011-12-05 5:23 ` Seungwon Jeon
2011-12-05 14:33 ` Jae hoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01ccb303$148e84e0$3dab8ea0$%jun@samsung.com' \
--to=tgih.jun@samsung.com \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox