* [PATCH] mmc: dw_mmc-pltfm: include 'dw_mmc-pltfm.h'
@ 2013-08-06 1:54 Jingoo Han
2013-08-09 13:31 ` Seungwon Jeon
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2013-08-06 1:54 UTC (permalink / raw)
To: 'Chris Ball'
Cc: linux-mmc, 'Seungwon Jeon', 'Jaehoon Chung',
'Jingoo Han', 'Dan Carpenter',
'Dinh Nguyen'
Include 'dw_mmc-pltfm.h' header file in order to fix
the following sparse warnings:
drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol 'dw_mci_pltfm_register' was not declared. Should it be static?
drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning: symbol 'dw_mci_pltfm_pmops' was not declared. Should it be static?
drivers/mmc/host/dw_mmc-pltfm.c:118:5: warning: symbol 'dw_mci_pltfm_remove' was not declared. Should it be static?
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mmc/host/dw_mmc-pltfm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/dw_mmc-pltfm.c b/drivers/mmc/host/dw_mmc-pltfm.c
index ee52556..2089752 100644
--- a/drivers/mmc/host/dw_mmc-pltfm.c
+++ b/drivers/mmc/host/dw_mmc-pltfm.c
@@ -23,6 +23,7 @@
#include <linux/of.h>
#include "dw_mmc.h"
+#include "dw_mmc-pltfm.h"
static void dw_mci_rockchip_prepare_command(struct dw_mci *host, u32 *cmdr)
{
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] mmc: dw_mmc-pltfm: include 'dw_mmc-pltfm.h'
2013-08-06 1:54 [PATCH] mmc: dw_mmc-pltfm: include 'dw_mmc-pltfm.h' Jingoo Han
@ 2013-08-09 13:31 ` Seungwon Jeon
2013-08-25 3:41 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Seungwon Jeon @ 2013-08-09 13:31 UTC (permalink / raw)
To: 'Jingoo Han', 'Chris Ball'
Cc: linux-mmc, 'Jaehoon Chung', 'Dan Carpenter',
'Dinh Nguyen'
On Tue, August 06, 2013,Jingoo Han wrote:
> Include 'dw_mmc-pltfm.h' header file in order to fix
> the following sparse warnings:
>
> drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol 'dw_mci_pltfm_register' was not declared. Should
> it be static?
> drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning: symbol 'dw_mci_pltfm_pmops' was not declared. Should it
> be static?
> drivers/mmc/host/dw_mmc-pltfm.c:118:5: warning: symbol 'dw_mci_pltfm_remove' was not declared. Should
> it be static?
>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc-pltfm: include 'dw_mmc-pltfm.h'
2013-08-09 13:31 ` Seungwon Jeon
@ 2013-08-25 3:41 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2013-08-25 3:41 UTC (permalink / raw)
To: Seungwon Jeon
Cc: 'Jingoo Han', linux-mmc, 'Jaehoon Chung',
'Dan Carpenter', 'Dinh Nguyen'
Hi Seungwon,
On Fri, Aug 09 2013, Seungwon Jeon wrote:
> On Tue, August 06, 2013,Jingoo Han wrote:
>> Include 'dw_mmc-pltfm.h' header file in order to fix
>> the following sparse warnings:
>>
>> drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol
>> dw_mci_pltfm_register' was not declared. Should
>> it be static?
>> drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning: symbol
>> dw_mci_pltfm_pmops' was not declared. Should it
>> be static?
>> drivers/mmc/host/dw_mmc-pltfm.c:118:5: warning: symbol
>> dw_mci_pltfm_remove' was not declared. Should
>> it be static?
>>
>> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
Thanks, pushed to mmc-next for 3.12.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-25 3:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-06 1:54 [PATCH] mmc: dw_mmc-pltfm: include 'dw_mmc-pltfm.h' Jingoo Han
2013-08-09 13:31 ` Seungwon Jeon
2013-08-25 3:41 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox