[PATCH v4 0/2] mmc: core: Support packed command feature of eMMC4.5

[PATCH v4 0/2] mmc: core: Support packed command feature of eMMC4.5

[Seungwon Jeon]

This patch-set adds support of packed command feature
for eMMC4.5 devices.

Changes in v4:
	- Add Data-tag as CMD23 argument for packed header.
	- Separate the capability of MMC_CAP2_PACKED_CMD into read and write.
	- remove unnecessary initial value.

Changes in v3:
	- Add a variable member in mmc_host for minimum number of packed entries.
	  This value can be overridden by host.
	- Fix a handling of error sequence.

Changes in v2:
	- Fix the packed read sequence and error handling.
	- Apply checking the exception status for all cases with
	  the comments from Maya Erez and Sahitya Tummala.
	- Fix preparing the packed list with the comment from Maya Erez and Venkatraman.


Seungwon Jeon (2):
      mmc: core: Add packed command feature of eMMC4.5
      mmc: core: Support packed command for eMMC4.5 device

 drivers/mmc/card/block.c   |  475 +++++++++++++++++++++++++++++++++++++++++---
 drivers/mmc/card/queue.c   |   48 ++++-
 drivers/mmc/card/queue.h   |   13 ++
 drivers/mmc/core/host.c    |    2 +
 drivers/mmc/core/mmc.c     |   24 +++
 drivers/mmc/core/mmc_ops.c |    1 +
 include/linux/mmc/card.h   |    3 +
 include/linux/mmc/core.h   |    4 +
 include/linux/mmc/host.h   |    4 +
 include/linux/mmc/mmc.h    |   15 ++
 10 files changed, 562 insertions(+), 27 deletions(-)

Best regards,
Seungwon Jeon.
--
1.7.2.3

Re: [PATCH v4 0/2] mmc: core: Support packed command feature of eMMC4.5

[Chris Ball]

Hi Seungwon,

On Thu, Jan 26 2012, Seungwon Jeon wrote:
> This patch-set adds support of packed command feature
> for eMMC4.5 devices.

Thanks, looks good!  Were you or Namjae able to measure any performance
changes with this patchset applied?

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

RE: [PATCH v4 0/2] mmc: core: Support packed command feature of eMMC4.5

[Seungwon Jeon]

Hi Chris,

Chris Ball <cjb@laptop.org> wrote:
> Hi Seungwon,
> 
> On Thu, Jan 26 2012, Seungwon Jeon wrote:
> > This patch-set adds support of packed command feature
> > for eMMC4.5 devices.
> 
> Thanks, looks good!  Were you or Namjae able to measure any performance
> changes with this patchset applied?
We could get the difference results depending on eMMC device.
I have tested patch set with eMMC device which was not optimized in packed command.
In my environment there is a performance gain only with packed write
if total chunk size for transfer is large.
This is not common case in user scenario as of now.
Currently this patch set with regard to packed command is meaningful
and helpful for device supporting fully.

Best regards,
Seungwon Jeon.

> 
> - Chris.
> --
> Chris Ball   <cjb@laptop.org>   <http://printf.net/>
> One Laptop Per Child
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html